From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com [210.131.2.80]) by sourceware.org (Postfix) with ESMTPS id 98B9D383EC43 for ; Thu, 24 Nov 2022 10:56:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 98B9D383EC43 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from HP-Z230 (w165151.dynamic.ppp.asahi-net.or.jp [121.1.165.151]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 2AOAuVfN030652 for ; Thu, 24 Nov 2022 19:56:31 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 2AOAuVfN030652 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1669287391; bh=z+ayAUwSAUTlcMamwiseSTs544Ucd790qd54DV/Lkdc=; h=Date:From:To:Subject:In-Reply-To:References:From; b=lgkCCyh9coQHI4HDhYiZDxP5IxWrOHIe3EZ9JppV1Y4h/K9qID1K5n4y/AjsQIoKN MT05lJDltzFOhuu1iZtVJzbUzroe6ftpTaia2qW+OhZI3D3Qn2QfnD67SKqJAtzhzv zBzLrip3MWzWeaMI7fC3pKGUP1t5xXs+7NiTd53dhSkRrkxonCSupEDXS4PHmpmb1O JclLThpkTk2u7s0f0AY1NQjX/MW5usbBulxW9mNao5epFfrkEagIW3SjfoYKevOZkr 7L5I/sHvLb5/fh2Fo5DsvhgTazAN5i3bqARu/aGLvlQrudvptNlSCEbY4AFQyWsCX9 ozzxwA6O/NnqA== X-Nifty-SrcIP: [121.1.165.151] Date: Thu, 24 Nov 2022 19:56:31 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: tty.cc and fhandler/tty.cc Message-Id: <20221124195631.c70c82c31e173d5e2d8ca92e@nifty.ne.jp> In-Reply-To: References: <20221122173115.b94b586200e0accf88512309@nifty.ne.jp> <20221123074632.f1799d6f6039973e9bd000d6@nifty.ne.jp> <20221124172402.214c49a8aa0a65fd411b7497@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 24 Nov 2022 11:18:27 +0100 Corinna Vinschen wrote: > On Nov 24 17:24, Takashi Yano wrote: > > On Tue, 22 Nov 2022 10:36:28 +0100 > > Corinna Vinschen wrote: > > > Maybe we could split it up. The extern functions could go into > > > syscalls.cc and the tty classes could go into fhandler/termios.cc, > > > perhaps. There are already two tty_min methods in that file. > > > > or renaming fhandler/tty.cc? > > Renaming fhandler/tty.cc to fhandler/pty.cc is the better solution, > I think. Ok, I will submit a patch for that shortly. -- Takashi Yano