From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by sourceware.org (Postfix) with ESMTPS id 4EDDD388EF9F for ; Fri, 9 Dec 2022 00:48:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EDDD388EF9F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from HP-Z230 (aj135041.dynamic.ppp.asahi-net.or.jp [220.150.135.41]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 2B90mEmB008817 for ; Fri, 9 Dec 2022 09:48:15 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 2B90mEmB008817 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1670546895; bh=jK6viOcN+R3Fe+kylvzV8J4xa4t1vZhEDj/5JFdiPzA=; h=Date:From:To:Subject:In-Reply-To:References:From; b=XgIrKR6/3woGxINPgsu2rxl551AbvoReYmguHFMCvV31IeFayDCDTzvEpsWtR/vbI 09Y/wBQWkdtMIVif85HHCbNsLIM8PAl2FT2D4Thld1x27VK6Uk3XmhDDXwsO6/e0iS 90SESgo2GXpGc6nD1jsSmzjJ1qzqKBnjGWGzseiz1QcfrYBvBOLuo1UmUCyWaBFDs6 tUMeZlJoG3F/rjnnPBdVAHaKWGm0TZOAAxWFCD3HDCyVGEkHfDfazjHj/s2KNObpcU mOl7bw7V0Cahp9/5rU8hfsufZNh9+02o16uG7aGcUWmntqXqTRkPoXqQqpihaGbkjR V3UuHnAlTHCmw== X-Nifty-SrcIP: [220.150.135.41] Date: Fri, 9 Dec 2022 09:48:14 +0900 From: Takashi Yano To: cygwin-developers@cygwin.com Subject: Re: Performance regression in cygwin 3.4.0 Message-Id: <20221209094814.a1b4e632fa16d71e673506ed@nifty.ne.jp> In-Reply-To: <8bf2dfae-1041-0bb7-9dc7-d255747bebfe@cornell.edu> References: <20221208184656.ea6b9796eccc503c1e238f0f@nifty.ne.jp> <20221208235445.eb2a862dac8db77b5be8f6bc@nifty.ne.jp> <8bf2dfae-1041-0bb7-9dc7-d255747bebfe@cornell.edu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 8 Dec 2022 15:56:43 -0500 Ken Brown wrote: > On 12/8/2022 10:30 AM, Corinna Vinschen wrote: > > Hi Takashi, > > As for the code, I have just one nit. Don't use GetTickCount. Use > > GetTickCount64(). I just noticed you're using it in tty::wait_fwd as > > well. Please use GetTickCount64() there, too. This way you can > > get rid of the overflow handling. > > > > Ken? Any more input? > > LGTM. Thanks for reviewing. I will submit a revised patch to cygwin-patches@cygwin.com. -- Takashi Yano