From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2097.outbound.protection.outlook.com [40.107.244.97]) by sourceware.org (Postfix) with ESMTPS id 29A963858C60 for ; Mon, 20 Sep 2021 21:39:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 29A963858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cornell.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cornell.edu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ku5jqtfBkZEZkMJNb6OO/OTMhdvMjBFFnWZznPeYqOlwJ7inmBXF9DH9vd5Ks18tZVAKut61jfWQfd9YMihM2zFirr4TrgDqSfWg5UaT+Q5GmMguYqlHYL9g6vVHIepFbTnTEiIDomgbvtnxt8o7TwawYM8fLGm2aounbiDvT8Twk2NnmWxvN1bPSSK8HP3A1HCzOFxsSqjRXYFibVcrlHIEEYeqinw6KSdwE2+FU384+T/oWOuWJKmy+PCzX51dklhKoGsokmc7DdXX+yXZUH8w6fAR2j1qY+iJlJ2Fy2tLmnaDbw8kMCAjBFpU6P/N8SslCxAK4vQHWVcJgmbiHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ycTMVI3T87JdklLvMcNbKCV0OdQPZgqLep/gfq5byFg=; b=E8xOrvYmr1YHW+Dm8jXCUIsu0+AVmjeMvJnUiuyr4oBap8zWC21GAgJagN8gKpd+JTFnpMzqJjYRtNfhpb456XUSYmWgL5lzTuFWxqS4nCR/yLh+pPzvIwChtPvOTApqoI17QhUMXKrFhoIFrnhqQKdgB9Keyi9tJkEGLjvny2bocjO3Gv2dFJQv+PTru3d6kijnV3jwWKKMrwG80/o3SVjXEs2T1ITFIcuoirYPmAuvoVmWrbM9pjtifjOA4WiTzYe3+DZ2KkJOeTPlG6Apl80HJGzcCgS4YODV0eq+m4qWcdWAAHPRILO2FS3E3QgUk3IQWkWT0xUOWGOg/H80cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ycTMVI3T87JdklLvMcNbKCV0OdQPZgqLep/gfq5byFg=; b=HzdPJBXoQ0r0YqKJ2lr/xW00p9St8ZsCLFIa5WXmoau12qLOKUEe/8WX61cTQYL/lIxGxVcbACY9fFTXx9y8yxmH6Vd4YHqLmXAHdNtXUmPT1kWER8kplhnCdM3Iv6DrwCP/RhBiTXzPsknGH9Hwk4cQTIRCeWO/tflebzCTmqk= Authentication-Results: cygwin.com; dkim=none (message not signed) header.d=none;cygwin.com; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN8PR04MB5825.namprd04.prod.outlook.com (2603:10b6:408:a5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Mon, 20 Sep 2021 21:39:55 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::5113:e84a:b38a:7a66]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::5113:e84a:b38a:7a66%6]) with mapi id 15.20.4523.018; Mon, 20 Sep 2021 21:39:55 +0000 Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? To: cygwin-developers@cygwin.com References: <20210907122631.65452be8d021ec72259431d5@nifty.ne.jp> <20210909124115.555c6be15d675500617d284a@nifty.ne.jp> <20210909170549.506cc3c1f6029d904fece6dd@nifty.ne.jp> <20210909211940.51ef391e27d43f0421962cb8@nifty.ne.jp> <20210909214246.cd1ff1a3062fea27e51ad4ae@nifty.ne.jp> <33386baf-3b2d-d57f-2ad3-1bd328ed7935@cornell.edu> <20210911075734.aaf37697ba7db2ad14d911a3@nifty.ne.jp> <20210911113517.f74fc3ac1971bbf04c7a9bd1@nifty.ne.jp> <20210920215229.cea5722b2c2fcd7e03917108@nifty.ne.jp> <00f4eca0-2b38-f4bb-98f2-e99e7ee941f5@cornell.edu> <20210921062737.13448347e0fc28a9a3dae38c@nifty.ne.jp> From: Ken Brown Message-ID: <2bdbd4bd-a9fd-ee74-58c5-0e102da111e9@cornell.edu> Date: Mon, 20 Sep 2021 17:39:54 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210921062737.13448347e0fc28a9a3dae38c@nifty.ne.jp> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR04CA0025.namprd04.prod.outlook.com (2603:10b6:610:76::30) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 Received: from [IPv6:2603:7081:7e3f:3419:d571:af58:205e:a58] (2603:7081:7e3f:3419:d571:af58:205e:a58) by CH0PR04CA0025.namprd04.prod.outlook.com (2603:10b6:610:76::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Mon, 20 Sep 2021 21:39:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 714e5546-9ed2-4ef1-2997-08d97c7f2fbc X-MS-TrafficTypeDiagnostic: BN8PR04MB5825: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BLVhVtdNGXODqmRDAefoNxUSRQs5AA6pxrxQVMxRoMfUIb/GLcFATDK7jyR61Oz6Pse1uNY6C6utSVTfh/j7HiZSeD2k6Z1nm+yQIxZmCP3YmMl9hHA/SSeQ4VU3/jzEOkXB/mC0e/ky7/EfxavWoUkKE3iBzJhNvyauLujmKvQcUI5vzqUmx/DdFiCo85qF06JUVnKzutTr2MrWRPZZ6hltsPCwq4oVnhvXrwpwwUrStZBykmTgyMfrggYqTaeAG5N8v4wz00O6+IqVekbOO6YNgl+Fx4GDR3TVuULqpsyqUk7DOfkWuqeOBNuQ68nzoJCGGJqsfN8+zcFLkWJfcKASwyvvnG3zLuF8xRJXKhyjvGfmZNc3eoDx8QGRwFzlco2LQlvPzLDcxQR41SOyO9yIWd7mFlR8/6htBeM9dEY5YkJeAjcOClOc8zKuaeAZgL/8KyOIwALZW/MxJ5eIiJXX7SL28rvwR8zqnbGBO6k59DjocIXGkVF9A8aYvGQ2wGjbqLdD7md6YB7AV5TDTmBvQbNNRhaDoGZ2EaeIJpGvpkwJCxAEZEvgJ7O2exAzrtXCzs5DMwSEerp/LzETxfIl/bkCdlGvornWIyVtjipdWQzbshNdbXiwFGo8fNvOCDdPPFEquoaiMAzrZjn1DRU4eSYbJjl1tj/U06TnCMQwouD1aFhQ/um8eTJeF68mGDTsDuYXIvCiHmkwZBGs7p+g5KfQea7gZAlqh+NvMSg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(346002)(136003)(396003)(366004)(2616005)(478600001)(31696002)(66946007)(8676002)(66556008)(36756003)(53546011)(83380400001)(66476007)(186003)(2906002)(8936002)(316002)(5660300002)(86362001)(38100700002)(75432002)(6486002)(6916009)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?cuLFs11LzNfd/QUSaXj2i4lCdP0htBkBZrn6iK0iFXbgCpP4czEJT17o?= =?Windows-1252?Q?MbS68kwwnZ++ukZJLVo054jf2cPAoaEJftzaZLHPjeP2srqFRZPmMoLd?= =?Windows-1252?Q?tTVRzBteTxn6kJ+H7PaXs8/xvcgu0t8s3vuOIP7ak6DOiILOfR37nSdf?= =?Windows-1252?Q?hvtcHUG7el1wntNDyzjpjEq/CBPd3z6gxDOdR8OTUtvaypF295CJQt1i?= =?Windows-1252?Q?m176W3dg2iOUIWN+CN9Zi2ClLuz92cil/egKlR/FWh80RCVA57eMj0Yc?= =?Windows-1252?Q?LqLBK3YxU+hEBB2W/kRjzMeJg1xbAs/E1sF37LcixrxsVateQXOf0Tyl?= =?Windows-1252?Q?E9ph2bQZvqo4RJJd4y76b5zg1BiHmSEb0alwvDRB68f9e0dpDbeWpgJv?= =?Windows-1252?Q?FR2RLWNClDWzDZp0suBEvyS4mPERo/L3e0JemdTAXyxadE93xWMDe9Na?= =?Windows-1252?Q?BeI9Hoacfv9mEob7Pr5PcWbOZ14SSjj8GB6tf2N2JQ+kT7F1Tl+wpT0m?= =?Windows-1252?Q?UmtN/oOAlTXbgiQ53D/IbeyDdbx1ta6PFah12t+ORWhQx+0uLKknXqd/?= =?Windows-1252?Q?KqfAq/px2KGm6KE698KtxdqvUcxrqskqvenCrDh2jlwrbBao0WepbRLt?= =?Windows-1252?Q?8qualVAuEaUn5n5g1JOWl0hqxK8xSA22Eqle1fDdebWzsKszXHibs/U/?= =?Windows-1252?Q?BVE5O14C9B2+WWYTHXI3jT1GJ7IkFGiJlnYya59Wt+2fYmDfYy6JzNYf?= =?Windows-1252?Q?47RMZOy0ML9DV3h2z5THiKm+COnbHuO+n1HV82Z56LGIL2J52XYASjxC?= =?Windows-1252?Q?EwCeqP3hNuRqVJ9VLfNs336+pDlwSbd9Q0O39ATMieEh4SpEXQ5Mv/FZ?= =?Windows-1252?Q?AmABW8JLekxgcEtXtCVRnIDRJc0dEW3dC/df7ZxMO5wijnBOjLtV/hhJ?= =?Windows-1252?Q?4ONB1sQh/M8R7wpkoVqqB2yceTbR1P/7kuMbh95hFW7Rm3NXnIzj0zP9?= =?Windows-1252?Q?e0DrUT6XBbpCRm7lpV8cCanX3W0JeNKw7CnPj2UKb9yUT7pK79MMS3UU?= =?Windows-1252?Q?HfrSpTgtc5rhZvNTO7aevy/pOs/rapQBLNj4CjHuP2VV+2nIvuOtHmyL?= =?Windows-1252?Q?cC51egxhW0DdQ92USykq+s2q+v/2sS/sVa/H0XmwYZYOqMOejbgvA904?= =?Windows-1252?Q?R5AHJ9xqKSxiEekZoRoAQ0eMoZ5gEBfRD3ImdhS6r0wfkwYYfWqnnueH?= =?Windows-1252?Q?AIlPohIYQwrxCx0KVQnW3KqWHcUg0XHbU97nnE1OvnBytYG8LIcG7UDN?= =?Windows-1252?Q?Qn2FeFtUodFi7A0swzbop1Pe2pfpJvgAqox6mQX7jP9MTXFrYrb+Wt7V?= =?Windows-1252?Q?xy2wsddKC7ZbXHoNfXn/7m+LVlbr/11IhVsVS3J6y7qUASxJ7xmkiTW6?= =?Windows-1252?Q?9WkykK2m68V4Kx99zqOrVukFIzstJPIDjp7CT3nGKYPFA+4Yj311sYsa?= =?Windows-1252?Q?k2EsjNHc?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 714e5546-9ed2-4ef1-2997-08d97c7f2fbc X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 21:39:55.4936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LrzeRZNI2ubOsg3QHlqA0foH61kSz0hgF9xeppqCdzeuSJTPDRTmCtW3tyz7ww93zPeNP4TZgeyWg7GKdlg2cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB5825 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2021 21:39:59 -0000 On 9/20/2021 5:27 PM, Takashi Yano wrote: > Hi Ken, > > Thanks for reviewing the code. > > On Mon, 20 Sep 2021 17:09:48 -0400 > Ken Brown wrote: >> On 9/20/2021 3:14 PM, Ken Brown wrote: >>> + if (wcscmp (name, ntfn->Name.Buffer) == 0) >>> + { >>> + query_hdl_proc = proc; >>> + query_hdl_value = (HANDLE)(intptr_t) shi->Handles[i].HandleValue; >>> + qh = h; >>> + break; >>> + } >>> +close_handle: >>> + CloseHandle (h); >>> +close_proc: >>> + CloseHandle (proc); >> >> Doesn't this mean that query_hdl_proc is not a valid handle any more? So the >> attempt to reduce overhead at the beginning of tentative_query_hdl() will never >> work. > > When the handle which name matches the pipe name is found, 'break' > is used in the 'for' loop, so the CloseHandle(proc) is not called. > Therefore, query_hdl_proc still has valid handle after 'break'. Right, I realized this myself. I guess you wrote your reply before seeing my later message in which I said "I see my stupid mistake". > >> Other than that, I still think it looks great. But it's complicated enough that >> I think Corinna should review it too when she returns. (It also uses Windows >> functions that I have no experience with.) Nevertheless, I'm tempted to push it >> so that it can get testing, even if Corinna changes it or reverts it later. I'll push it tomorrow unless you find something that needs to be changed before then. Ken