From: Eric Blake <eblake@redhat.com>
To: cygwin-developers@cygwin.com
Subject: Re: [newlib-cygwin] Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs
Date: Tue, 14 Apr 2015 12:53:00 -0000 [thread overview]
Message-ID: <552D0DA8.3050405@redhat.com> (raw)
In-Reply-To: <20150414084240.119932.qmail@sourceware.org>
[-- Attachment #1: Type: text/plain, Size: 1746 bytes --]
On 04/14/2015 02:42 AM, Corinna Vinschen wrote:
> https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=40653522b942addc65070275c89078d15aa8b4d5
>
> commit 40653522b942addc65070275c89078d15aa8b4d5
> Author: Corinna Vinschen <corinna@vinschen.de>
> Date: Tue Apr 14 10:42:29 2015 +0200
>
> Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs
>
> * sec_acl.cc (get_posix_access): Don't use GROUP_OBJ access to fix up
> CLASS_OBJ mask on old-style ACLs. Fix a comment.
>
> Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
>
> - /* Accommodate Windows: Never add SYSTEM and Admins
> - perms to CLASS_OBJ perms. */
> + /* Accommodate Windows: Never add SYSTEM and Admins to
> + CLASS_OBJ. Unless (implicitely) if they are the
s/implicitely/implicitly/
> + GROUP_OBJ entry. */
> if (ace_sid != well_known_system_sid
> && ace_sid != well_known_admins_sid)
> class_perm |= lacl[pos].a_perm;
> @@ -774,11 +775,12 @@ get_posix_access (PSECURITY_DESCRIPTOR psd,
> if (!new_style)
> {
> /* Fix up DEF_CLASS_OBJ value. */
> - if (type & (USER | GROUP_OBJ | GROUP))
> + if (type & (USER | GROUP))
> {
> has_def_class_perm = true;
> - /* Accommodate Windows: Never add SYSTEM and Admins
> - perms to CLASS_OBJ perms. */
> + /* Accommodate Windows: Never add SYSTEM and Admins to
> + CLASS_OBJ. Unless (implicitely) if they are the
and again
(same goes for "explicitly" - not in this patch, but I've noticed you
often add the 'e' there too)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next parent reply other threads:[~2015-04-14 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150414084240.119932.qmail@sourceware.org>
2015-04-14 12:53 ` Eric Blake [this message]
2015-04-14 14:58 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552D0DA8.3050405@redhat.com \
--to=eblake@redhat.com \
--cc=cygwin-developers@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).