* Re: [newlib-cygwin] Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs [not found] <20150414084240.119932.qmail@sourceware.org> @ 2015-04-14 12:53 ` Eric Blake 2015-04-14 14:58 ` Corinna Vinschen 0 siblings, 1 reply; 2+ messages in thread From: Eric Blake @ 2015-04-14 12:53 UTC (permalink / raw) To: cygwin-developers [-- Attachment #1: Type: text/plain, Size: 1746 bytes --] On 04/14/2015 02:42 AM, Corinna Vinschen wrote: > https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=40653522b942addc65070275c89078d15aa8b4d5 > > commit 40653522b942addc65070275c89078d15aa8b4d5 > Author: Corinna Vinschen <corinna@vinschen.de> > Date: Tue Apr 14 10:42:29 2015 +0200 > > Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs > > * sec_acl.cc (get_posix_access): Don't use GROUP_OBJ access to fix up > CLASS_OBJ mask on old-style ACLs. Fix a comment. > > Signed-off-by: Corinna Vinschen <corinna@vinschen.de> > > - /* Accommodate Windows: Never add SYSTEM and Admins > - perms to CLASS_OBJ perms. */ > + /* Accommodate Windows: Never add SYSTEM and Admins to > + CLASS_OBJ. Unless (implicitely) if they are the s/implicitely/implicitly/ > + GROUP_OBJ entry. */ > if (ace_sid != well_known_system_sid > && ace_sid != well_known_admins_sid) > class_perm |= lacl[pos].a_perm; > @@ -774,11 +775,12 @@ get_posix_access (PSECURITY_DESCRIPTOR psd, > if (!new_style) > { > /* Fix up DEF_CLASS_OBJ value. */ > - if (type & (USER | GROUP_OBJ | GROUP)) > + if (type & (USER | GROUP)) > { > has_def_class_perm = true; > - /* Accommodate Windows: Never add SYSTEM and Admins > - perms to CLASS_OBJ perms. */ > + /* Accommodate Windows: Never add SYSTEM and Admins to > + CLASS_OBJ. Unless (implicitely) if they are the and again (same goes for "explicitly" - not in this patch, but I've noticed you often add the 'e' there too) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 604 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [newlib-cygwin] Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs 2015-04-14 12:53 ` [newlib-cygwin] Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs Eric Blake @ 2015-04-14 14:58 ` Corinna Vinschen 0 siblings, 0 replies; 2+ messages in thread From: Corinna Vinschen @ 2015-04-14 14:58 UTC (permalink / raw) To: cygwin-developers [-- Attachment #1: Type: text/plain, Size: 1955 bytes --] On Apr 14 06:52, Eric Blake wrote: > On 04/14/2015 02:42 AM, Corinna Vinschen wrote: > > https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=40653522b942addc65070275c89078d15aa8b4d5 > > > > commit 40653522b942addc65070275c89078d15aa8b4d5 > > Author: Corinna Vinschen <corinna@vinschen.de> > > Date: Tue Apr 14 10:42:29 2015 +0200 > > > > Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs > > > > * sec_acl.cc (get_posix_access): Don't use GROUP_OBJ access to fix up > > CLASS_OBJ mask on old-style ACLs. Fix a comment. > > > > Signed-off-by: Corinna Vinschen <corinna@vinschen.de> > > > > > - /* Accommodate Windows: Never add SYSTEM and Admins > > - perms to CLASS_OBJ perms. */ > > + /* Accommodate Windows: Never add SYSTEM and Admins to > > + CLASS_OBJ. Unless (implicitely) if they are the > > s/implicitely/implicitly/ > > > + GROUP_OBJ entry. */ > > if (ace_sid != well_known_system_sid > > && ace_sid != well_known_admins_sid) > > class_perm |= lacl[pos].a_perm; > > @@ -774,11 +775,12 @@ get_posix_access (PSECURITY_DESCRIPTOR psd, > > if (!new_style) > > { > > /* Fix up DEF_CLASS_OBJ value. */ > > - if (type & (USER | GROUP_OBJ | GROUP)) > > + if (type & (USER | GROUP)) > > { > > has_def_class_perm = true; > > - /* Accommodate Windows: Never add SYSTEM and Admins > > - perms to CLASS_OBJ perms. */ > > + /* Accommodate Windows: Never add SYSTEM and Admins to > > + CLASS_OBJ. Unless (implicitely) if they are the > > and again > > (same goes for "explicitly" - not in this patch, but I've noticed you > often add the 'e' there too) Fixed in CVS^Wgit. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat [-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-14 14:58 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20150414084240.119932.qmail@sourceware.org> 2015-04-14 12:53 ` [newlib-cygwin] Fix thinko in creating the {DEF_}CLASS_OBJ value on old-style ACLs Eric Blake 2015-04-14 14:58 ` Corinna Vinschen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).