public inbox for cygwin-developers@cygwin.com
 help / color / mirror / Atom feed
From: Thomas Wolff <towo@towo.net>
To: cygwin-developers@cygwin.com, Takashi Yano <takashi.yano@nifty.ne.jp>
Subject: Re: Pseudo console support in PTY
Date: Wed, 03 Apr 2019 11:33:00 -0000	[thread overview]
Message-ID: <58a92b8b-f121-a185-0e8f-7906f79430f6@towo.net> (raw)
In-Reply-To: <20190403080222.GU3337@calimero.vinschen.de>

On 03.04.2019 10:02, Corinna Vinschen wrote:
> On Apr  3 09:55, Thomas Wolff wrote:
>> Am 03.04.2019 um 09:27 schrieb Corinna Vinschen:
>>> On Apr  3 09:18, Thomas Wolff wrote:
>>>> Am 02.04.2019 um 19:50 schrieb Corinna Vinschen:
>>>>> On Apr  2 19:16, Thomas Wolff wrote:
>>>>>> Am 02.04.2019 um 13:02 schrieb Corinna Vinschen:
>>>>>>> Hi Takashi,
>>>>>>>
>>>>>>> On Mar 30 22:08, Takashi Yano wrote:
>>>>>>>> Patch 0003: Support pseudo console in PTY. With this patch,
>>>>>>>>       native console applications can work in PTY such as mintty,
>>>>>>>>       ssh, gnu screen or tmux.
>>>>>> I've now tried your patched binaries on two systems. On one they don't run,
>>>>>> on the other I saw no noticeable effect, particularly no impact on the
>>>>>> pty/console interoperability...
>>>>> Try starting cmd from your shell in mintty and do some native stuff.
>>>> I've now self-compiled cygwin dll on a third system and can run a cygwin
>>>> console.
>>>> But the build process did not generate the cygwin-console-helper, maybe
>>>> that's the reason why mintty does not start?
>> Can you give a hint that enables me to test the patch?
>>
>>>>> You'll notice two differences:
>>>>>
>>>>> - cmd history works
>>>> In the cygwin console, it does not, echos the cursor-up escape sequence
>>> Oh, right, ...
>>>
>>>> instead. See my previous comment that I think ConPTY should only be applied
>>>> if running at a pty. (And for other reasons only when starting a non-cygwin
>>>> app.)
>>> but you got that wrong.  The conpty stuff *is* only applied for ptys.
>> So cygwin running as cygwin console still sets up a pty?
> Still?  It never did.  Call tty in a console and you get /dev/consX.
Misunderstanding, didn't mean "still", sorry.
> The ConPTY stuff only runs if the application requests a pty.
OK, but I think it should additionally be restricted to running 
non-cygwin apps.

By the way, when I previously reported the patch to have no effect, that 
was on a Windows 7 system, so of course it couldn't, sorry :/
Still failing to test the patch in mintty on Windows 10...
Thomas

  reply	other threads:[~2019-04-03 11:33 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30 13:08 Takashi Yano
2019-03-30 19:47 ` Corinna Vinschen
2019-03-30 19:59   ` Corinna Vinschen
2019-03-30 23:07 ` Thomas Wolff
2019-03-31 14:38   ` Corinna Vinschen
2019-03-31 15:00   ` Takashi Yano
2019-04-02 11:02 ` Corinna Vinschen
2019-04-02 17:16   ` Thomas Wolff
2019-04-02 17:51     ` Corinna Vinschen
2019-04-03  7:18       ` Thomas Wolff
2019-04-03  7:28         ` Corinna Vinschen
2019-04-03  7:55           ` Thomas Wolff
2019-04-03  8:02             ` Corinna Vinschen
2019-04-03 11:33               ` Thomas Wolff [this message]
2019-04-03 12:17                 ` Corinna Vinschen
2019-04-04  4:17                   ` Takashi Yano
2019-04-04  8:06                     ` Corinna Vinschen
2019-04-04  4:15             ` Takashi Yano
2019-04-03 16:36   ` [PATCH v2 0/1] Pseudo console support in PTY (v2) Takashi Yano
2019-04-03 16:37     ` [PATCH v2 1/1] Cygwin: pty: add pseudo console support Takashi Yano
2019-04-03 16:50     ` [PATCH v2 0/1] Pseudo console support in PTY (v2) Corinna Vinschen
2019-04-04  5:27       ` Takashi Yano
2019-04-04  8:17         ` Thomas Wolff
2019-04-04  9:34           ` Takashi Yano
2019-04-03 17:11     ` Corinna Vinschen
2019-04-04  8:59       ` Takashi Yano
2019-04-04 10:46         ` Corinna Vinschen
2019-04-06 11:13           ` [PATCH v3 0/1] Pseudo console support in PTY (v3) Takashi Yano
2019-04-06 11:14             ` [PATCH v3 1/1] Cygwin: pty: add pseudo console support Takashi Yano
2019-04-06 17:43             ` [PATCH v3 0/1] Pseudo console support in PTY (v3) Corinna Vinschen
2019-04-12 10:22               ` [PATCH v4 0/1] Pseudo console support in PTY (v4) Takashi Yano
2019-04-12 10:23                 ` [PATCH v4 1/1] Cygwin: pty: add pseudo console support Takashi Yano
2019-04-12 12:29                 ` [PATCH v4 0/1] Pseudo console support in PTY (v4) Corinna Vinschen
2019-04-15  8:18                   ` Corinna Vinschen
2019-04-15 23:17                     ` Takashi Yano
2019-04-14 15:23                 ` [PATCH v5 0/1] Pseudo console support in PTY (v5) Takashi Yano
2019-04-14 15:23                   ` [PATCH v5 1/1] Cygwin: pty: add pseudo console support Takashi Yano
2019-04-15  8:38                     ` Corinna Vinschen
2019-04-16  0:41                       ` Takashi Yano
2019-04-16  9:16                         ` Corinna Vinschen
2019-06-24 10:53                           ` Corinna Vinschen
2019-07-25 14:31                             ` Corinna Vinschen
2019-08-08 19:24                               ` Corinna Vinschen
2019-08-12 12:07                             ` Takashi Yano
2019-08-12 12:50                               ` Corinna Vinschen
2019-08-12 14:36                                 ` Takashi Yano
2019-04-14 16:06                   ` [PATCH v5 0/1] Pseudo console support in PTY (v5) Takashi Yano
2019-04-16  1:49                     ` Takashi Yano
2019-04-16  1:51                       ` Takashi Yano
2019-04-06 21:33             ` [PATCH v3 0/1] Pseudo console support in PTY (v3) Thomas Wolff
2019-04-07  5:05               ` Takashi Yano
2019-04-07 12:02                 ` Takashi Yano
2019-04-07 21:21                 ` Thomas Wolff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58a92b8b-f121-a185-0e8f-7906f79430f6@towo.net \
    --to=towo@towo.net \
    --cc=cygwin-developers@cygwin.com \
    --cc=takashi.yano@nifty.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).