From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2111.outbound.protection.outlook.com [40.107.236.111]) by sourceware.org (Postfix) with ESMTPS id F2D7E3857818 for ; Fri, 3 Sep 2021 20:05:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F2D7E3857818 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cornell.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cornell.edu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gEcKTo9uhfAwjyQW7PrFuKp36MXbSpM4tpuyQGVQo5QgJt9IQqCyE+RVEtd2ThSavuj+HAwhpzdqdzFz1f+sYdrCsBpYI9yPaPwEStA5+hsNOuGedIV8eHurKd7akgl/Vftsfk/U7VY65k1R1QFX94YyvU1GikDg+f7D2yyKVKmqUY+d7QvmeBdpDlpEasnCLfSnmYUu1aKm2BRiidkm7Y/dYV41s7KF3WF6Ow11idQRNQa5hnf4ykfjXpW6btPz60CqblE+mKfYjk4ehfjCaNjPYGK4Kpo5BLbboCOwzIInmQGaAUbG5AfnMNeiZiDGHeYJZlC7MVBdlfrSL4J3CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3/2KUmrkGd+0i1FRo8lg7RDGALOAdpVx2UvTsmCIe9A=; b=QsDatuQ9DTnkVLovUyN+eVXH4+V1dP9n8crUbE4j8CYt0R8Gk/zUjhv2g8yfUXDRXNn72FkN62kGnashSqmF0K8Ip9lTdfrWdsCuD5gnBK2grJdlr/R4UbzxMIrVqSgv/0sfO7dYnKJQVzXbGxXTZ4SvU1kG/tEiVr9HNbLO9qVDjE8IGG2zu+FUqe69z6Cqd7ZYBFNupWQDan+bky6KajN60LM6RaemhQpaj/GoxaVH7c6Nw1KWdXRF/Gue2Z8+dkIhcOqFtGbgt1AIKvQI0Efow+rSJynCWGwy1WuuYGF/rScjOGMFJ5IofLyQRup6nfVcKMfAyOZ7DZmDMBzPEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3/2KUmrkGd+0i1FRo8lg7RDGALOAdpVx2UvTsmCIe9A=; b=BuQWVjGVN3hECIfCUZ7nUNfoDX3hh6GVkge8T1IE1IdzEmRCZ87O97dbhkvCEiNtONuLbZ7psbRvZ712o0Jlz53S5+9csHAe2R6YX2lmu66fcCyMN4n8815ONDZ+Q1b6uoBTiDCwnSzr0N0pnGgtfsu262yNpXuBglTE15RgcBY= Authentication-Results: cygwin.com; dkim=none (message not signed) header.d=none;cygwin.com; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN7PR04MB5171.namprd04.prod.outlook.com (2603:10b6:408:d::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Fri, 3 Sep 2021 20:05:46 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::b510:889b:1fd0:d80e]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::b510:889b:1fd0:d80e%7]) with mapi id 15.20.4478.020; Fri, 3 Sep 2021 20:05:46 +0000 Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? To: cygwin-developers@cygwin.com References: <24138e20-aa97-cfea-bf48-198fc67755ea@cornell.edu> <9ba687eb-f4a0-18f8-b10b-76e7e51e123e@cornell.edu> <152bfc0c-2f72-c684-6fc5-aa7c36c136b8@cornell.edu> From: Ken Brown Message-ID: <83822af9-b8cd-e5dd-970f-79996e5942a3@cornell.edu> Date: Fri, 3 Sep 2021 16:05:45 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CH2PR18CA0037.namprd18.prod.outlook.com (2603:10b6:610:55::17) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 Received: from [IPv6:2603:7081:7e3f:3419:4172:b7ad:cdf5:53cb] (2603:7081:7e3f:3419:4172:b7ad:cdf5:53cb) by CH2PR18CA0037.namprd18.prod.outlook.com (2603:10b6:610:55::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Fri, 3 Sep 2021 20:05:46 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b0829cb-44e1-451d-a13b-08d96f1637d0 X-MS-TrafficTypeDiagnostic: BN7PR04MB5171: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6p8C3HOkz7y4sv3m0vLtxcXRvDhKdWfPNkRDSPbGc/XXGrjEs8bxbQxcHm+OVdpt4hYYjBG7ZAQxFjGiPyaVFx4KK2WjxL/NTYakxQtLEp7IhY9sJdk8s7vahemzcanvoIkTHGsnW/4LDUmJxIn2dX4ce8IXKU/LI862ftGRmHFr7kXrcgcUVPqqDrFG7wBxRSgVvfLS2EBo9VrWqTPUJjYOH13lPdpxprJQTAPkc4X2foVAj5KgRhFMB+kUgmyjUiDVuxCU0aLQIAADc2oigb5gFnObYQ4DovS+YzCfIflUb+BZ4OQnIzGtD7KfOylsK+BSRWcd8gLSQaERn03Y5W8GZc+iz043DKMcKYUHViC0bXmOkLxJgb0mx8gIEmu1YlndtaaLdE/j1M0Vxn91dG6KWQV20t4InGFZSLjWtyNLwcz5pL3bRfFkmfACLmr8ikhM8NAgPrppWV6Wux6UewUfBX4PBl9eO4nJzV/mOnmKhvu3Oq0yFyN8ur5SZk1VVwkgzsWq+k+MFl96wXwsBcc/nxTPbAVLRaVr2SwtUqG87xwrJ93h3PL4DtkjwIaNUqT7GGq/Sy/Q+Hd+8l58P9QEfE31R7mQpnhlbAzfhK4CsDv08y72hB5RkB2g00JZoWctlaj0CW0UDR0WxSu4kUKzlnrBqMcByqtYT+JyxuX1guGQbzAtuKi4yCEXkrAvBX02omZCq68sd3eCUL95wbKYfliFEaQ+Whn1AEg4yMM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(396003)(39860400002)(346002)(86362001)(75432002)(31696002)(2906002)(66476007)(66556008)(66946007)(2616005)(478600001)(186003)(38100700002)(8676002)(8936002)(6486002)(36756003)(316002)(6916009)(31686004)(5660300002)(53546011)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?je3Smci/6MFb2sCSs1s0/r2Wr+zKumrWTXfLL5VrUMOLdF6ofJxkp+4n?= =?Windows-1252?Q?FjpFP3TmYO2OrEXBTFn2XSEi8IvM6DS0AX3NcMeX0dM7qQKhG0IioF5I?= =?Windows-1252?Q?qD5nNQ3Oy9WMAguXk2mi0IvkQco7oYOX/kk/11E/7c9Ou1i9PST9GY//?= =?Windows-1252?Q?DPgvrgkc03dOGYvk3XAdeRBjeO94zxOgatwVaccthlygTWIpoGpriPvR?= =?Windows-1252?Q?a/3xMqN+9V+N/WhNH1d+DODcKKcS7UbUh80r1jYZ23VmY12JsdcGDPUr?= =?Windows-1252?Q?i9wT5IMDC6ZhVkDu9aJamLhNPNm4cuMgreUjLnUve0w4xo9FDsCasugj?= =?Windows-1252?Q?yfp7gYotPqXqsyBzm+XRF73KuQ3OweN/3+rpFPzsLpdY9TTjGB5k/p8R?= =?Windows-1252?Q?QLI8Fi0XxV/Ese4iuMB4dfVhV/cqELwhAUCgyHoTInoCmFG7sDkgwkvp?= =?Windows-1252?Q?4J9rSnITAEJtwmS5iy52Dw0NyNzS9mvoWds0rkv589A8beFqX7q5ZQq9?= =?Windows-1252?Q?ZDfR1/c6qdzuXmLDwPofJeEmojf0oglBOYz9LhHkk9ECjv+R/qUNt8VS?= =?Windows-1252?Q?RQHpqL3j6YfyGzr/U0rNBFfo4gWSfp5iqxxyLTYYkmh2Sz8tHwByi26l?= =?Windows-1252?Q?E3QuJDBN8uDQIWy6Ngto5cYMi0gjU5gDjQ66iDcgmojINpmezKPrTTET?= =?Windows-1252?Q?LMfN6YEpNvnfK2YTPSw+YGO7F/NlZvpoXx3oaLGBFmQour8nrZgrcbb5?= =?Windows-1252?Q?9/40cUz+cgB8PB2Ovoap/NwMY/wL2R5mWm6TxCD6HlRUmIG3PxNPz3Vy?= =?Windows-1252?Q?cr22M3OiDHZAVQ/0NgHFeNYmP7N6WYyln80h1HiJnOB+c8DHJHuo2aWr?= =?Windows-1252?Q?xbDm9XC6GwmlqZ0wGpqhpDHF77PmK2byyDZMTSJeb7QYrzTdW/94yhu6?= =?Windows-1252?Q?nqSCDTHY5jH9/4fR1P7lrK21lfnvCM903v2msrUDYSOVV01maYJCOVXI?= =?Windows-1252?Q?r8kIzKOOsr/LkSGl+TFOwrvsOU8ZxIWlY7Q0b0KrVro2Bkxs0xfN4v1p?= =?Windows-1252?Q?y19adw0Vz49hCrUGUjC+sctqMT2oZNHttArod+YB2VTiEqN5HxXhh1rR?= =?Windows-1252?Q?XlGyupdU/fjOpLkgYW0UcU81NPUqvqTe3Kv4x+twQdI9anLUbYoltFit?= =?Windows-1252?Q?NKkoqDLF1526mR8+0X1LASATfAY6gFoeg9OmqGx9mmi6zK3ydlnnlyf0?= =?Windows-1252?Q?LxviTk2hNJVVSh9S976Zjln0J6QrufpI6tY1aRPm3OGk6pwYB40SbPAF?= =?Windows-1252?Q?vOscZquf23X2vG5ywYzoBhnpUc+7FbeujDcnwZEaaT5vmpod24ZvGAiF?= =?Windows-1252?Q?GHrZQseR8N9/sExlQX2Zq5bk6UB74ydGE4PMD8xm5+BpVtbk1i5u2BT4?= =?Windows-1252?Q?SlgGQoJdfyFKazVpeDujSjIooO91uSfx2Rc8wR0CsdMsFiRoEiMljdi1?= =?Windows-1252?Q?zNOzWHn/?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 3b0829cb-44e1-451d-a13b-08d96f1637d0 X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 20:05:46.7478 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SELbgyCpSi3/gG6EuVNc8RtXdnJ3UY8QSLvrgbId1qJfHOIzGtFSP6sM8BEVMEgG0xkQy5Zkp2AUsMZ2YfdwHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR04MB5171 X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_INVALID, DKIM_SIGNED, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 20:05:49 -0000 On 9/3/2021 3:54 PM, Corinna Vinschen wrote: > On Sep 3 15:00, Ken Brown wrote: >> On 9/3/2021 5:12 AM, Corinna Vinschen wrote: >>> I pushed my stuff to the topic/pipe branch split into hopefully useful >>> chunks. Kick me if anything is wrong or not working. >> >> Some of the bugs you fixed in the pipe code exist in the fifo code also. I >> started going through them and fixing them, but then I realized that >> fhandler_pipe::raw_write and fhandler_fifo::raw_write are identical. For >> ease of maintenance, I'm thinking we should have a single function, say >> fhandler_base::raw_write_pipe or fhandler_base::raw_write_pipe_fifo, which >> is called by both of them. >> >> WDYT? > > Returning to fhandler_base_overlapped? :) Touché. > No, seriously, the cleanest way is probably to implement a parent class > for fhandler_pipe and fhandler_fifo, derived from fhandler_base, and > just collect the common code there. For a start it could simply provide > raw_write and nothing else. fhandler_pipe_fifo, perhaps? Sounds good. Thanks. Since the new class has only raw_write for now, I think I could just define that function in fhandler_pipe.cc rather than a new file fhandler_pipe_fifo.cc. But I could also do the latter if you prefer. Ken