From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by sourceware.org (Postfix) with ESMTPS id 799DD3858C50 for ; Tue, 18 Apr 2023 00:25:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 799DD3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-5e5b5da22b8so4403026d6.0 for ; Mon, 17 Apr 2023 17:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681777557; x=1684369557; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Vk9EMtGVcTePN3V0w7w6Qh5KYGvaRqHxUibEybYllwY=; b=DzsSuG8zoRlCddJtX6hndOkcT7Zryj0nlBQmy25HP3DSeF1tLqtSLV6MKdEAIjz74w AOla1wlfkn3vR6cj1R/StqtKNsWDRnKWCzo2X12VKf04tuPK0EIMShQpEbhC93MtoWHk rbvg+Dw8lbBUqA4zlXqAfLc/qzAaRu7W103382ayWjbP9+qd3oE4BCDiQAuGtRS7CbmU Z5b4vkn5syyKflb+xfQPMGK5Qeb5vQvrzDUlsxieGwKY2vm5hUOaDdz8gmIbsBCCPg99 REBqzBFsKSui2k5XJvjnbhkAEPqEG+Mw/7H1kCh3FwU3iAPhCaypAIYdd5+jf3mXw7+N GZdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681777557; x=1684369557; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vk9EMtGVcTePN3V0w7w6Qh5KYGvaRqHxUibEybYllwY=; b=Oh3zAuuaOPj6zqHPM5vmQhcVv8isKYDG57HJjwTCt1ztKMpTNwzxIehq1IUCMXzgvd LhzjYqSAVOSiJleyDQNCThEPJv7V0GOX6UOVb8UpT4ROPPp0iPJkZs1OhIuYQcF3WAos Qkhl2TRbaTM1xgUKpsE7lxBX1yhCQOxzp4YAKv1ba0FAqLg4ki9tQzwjtUHYIaCi53aK mcorxUuAHcGxCQ2qFuAOTAbx3WpUJup6AM5+hK2x87oSMd1lOfUSCzPL3FT9cVQ4ngeN MvTW6meE6Kg0l4PzugIRLrNMXaWfkYk2Tp9twmYRtlr4FGw3AmL1laH1e2G3y1W55qI4 /8hQ== X-Gm-Message-State: AAQBX9e0sF5AzbuvE5en+kCb+7t/lWQglKGf/XyeRC0f2m7uJ20XmT2r ZAT0fCawhfXMuNjJlvySRjaW+lPks/s= X-Google-Smtp-Source: AKy350aXDCeURUKrkKGrlSzzRypdcVt2RRXp3tmczqqWZPAeMwkI9co8miSYpWS0/JRUEi7mP3eykg== X-Received: by 2002:a05:6214:d6c:b0:5da:b965:1efd with SMTP id 12-20020a0562140d6c00b005dab9651efdmr19338322qvs.2.1681777557488; Mon, 17 Apr 2023 17:25:57 -0700 (PDT) Received: from office-nix (hlfxns018gw-134-41-48-72.dhcp-dynamic.fibreop.ns.bellaliant.net. [134.41.48.72]) by smtp.gmail.com with ESMTPSA id eb3-20020a05620a480300b0074b5219b63esm2622397qkb.121.2023.04.17.17.25.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 17:25:56 -0700 (PDT) From: David McFarland To: cygwin-developers@cygwin.com Subject: Re: [PATCH] Cygwin: cygheap: fix fork error after heap has grown References: <20230413023517.62725-1-corngood@gmail.com> Date: Mon, 17 Apr 2023 21:25:55 -0300 In-Reply-To: (Corinna Vinschen's message of "Thu, 13 Apr 2023 18:16:29 +0200") Message-ID: <87bkjm6nos.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Corinna Vinschen writes: > Can you please append > > Fixes: 2f9b8ff00cce ("Cygwin: decouple cygheap from Cygwin DLL") > Signed-off-by: David McFarland > > ? Sure. > > Good catch! Please move the subtraction of CYGHEAP_STORAGE_LOW into the > allocsize call, along the lines of the other usage of allocsize in _csbrk. > > Is that what you mean in your followup mail, perhaps? Yeah, exactly. I'll follow up with a new patch.