From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20727.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::727]) by sourceware.org (Postfix) with ESMTPS id 1161D397268E for ; Thu, 8 Dec 2022 20:56:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1161D397268E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cornell.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cornell.edu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J1wUpDOgGPkFpECxS8rIqoTqQBnUtaw3SfV4DBDyhgFIy2D5roPIUE7sZtkD6fv6gSzg59X5XNiVhGsFhE+5PKyXY4QIzZqFNrZAbjLA6SdkUtP5OIv0ZMNZQmyKaAifWByyWuBQ2EFV8e5E74vqacCkgfyGwH0uRTJkELr+tM7PHvA7MuskEabbcccF4iDGI8lU1uD79wjDNQVk2Iw91fDpdW4hApZj0fGPfoIjVYhmzFpsC/rSAG2rgRSsUWyb4e/Q7lXIjfj4Hovg0FZlaQnCnNRo1bAy5ja67gsh91o70dv1Fw+KDUnc7wrwfVhD9paJUigGaqFHLBkHmKa9GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sFVQM/PkHNoPGwLVpVCen+JH/iayqV3+PiAnq/uWuWE=; b=dn3LEdUj3FbptyTsiX/BsW3DVA15S3UNF+NWPu13KYyPs0fbFmVNSMbeWTKkPqmWQlWUdTSfiVG8FvdGup7AjIVYUroJWw4VYS/KEeTMQP3efypPbvsGqL8d5cZUepsE1f+yH3Ll6Z2FeGS0KCLYNoDfnTRp419KZTlT0i0aNuJl+FxcUjFfJwSIqrV2ueezDHTlU7gj1XYDu7KlZ0nrB/4bza9ZXHYbBY95y5SrhlvJ+NPiwVupvTVZiUWGIby2D4AmrEdGvm9ExGncHD+vXOYcLF2KTMFp0Hb4Ez/TzDP17ozQvjeVMYkFiCUPQoCTnhg1kDQVCcDsp22agM3H+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sFVQM/PkHNoPGwLVpVCen+JH/iayqV3+PiAnq/uWuWE=; b=arHMRduN6WyqxTlzzxZaKZdV29nbih5sRyNKSV96duhF5qTzZi4QXwjaEkwQAinkzXywzjXUPye0KyjdFJM962Q7W8VSd3/XOqkBfhpcpeGiq2pdk6M3XOjBNWTzsW3Qru3s/+1d/9l0fERMGRgEkvBH9bCGMrxbzXIVFVAyNGw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Received: from SA0PR04MB7322.namprd04.prod.outlook.com (2603:10b6:806:e2::7) by BN0PR04MB8061.namprd04.prod.outlook.com (2603:10b6:408:15c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Thu, 8 Dec 2022 20:56:48 +0000 Received: from SA0PR04MB7322.namprd04.prod.outlook.com ([fe80::f2c3:ba60:bf61:17a1]) by SA0PR04MB7322.namprd04.prod.outlook.com ([fe80::f2c3:ba60:bf61:17a1%5]) with mapi id 15.20.5880.014; Thu, 8 Dec 2022 20:56:47 +0000 Message-ID: <8bf2dfae-1041-0bb7-9dc7-d255747bebfe@cornell.edu> Date: Thu, 8 Dec 2022 15:56:43 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: Performance regression in cygwin 3.4.0 Content-Language: en-US To: cygwin-developers@cygwin.com References: <20221208184656.ea6b9796eccc503c1e238f0f@nifty.ne.jp> <20221208235445.eb2a862dac8db77b5be8f6bc@nifty.ne.jp> From: Ken Brown In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR05CA0060.namprd05.prod.outlook.com (2603:10b6:208:236::29) To SA0PR04MB7322.namprd04.prod.outlook.com (2603:10b6:806:e2::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA0PR04MB7322:EE_|BN0PR04MB8061:EE_ X-MS-Office365-Filtering-Correlation-Id: 58492a2e-e994-4ae0-04ad-08dad95eb7e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kFje/71Jh3yDluN//jVWVjZq6wXYo1aXeBSciSZ6udqRyxp8jSBQ583iRzSwzQplmNDd07kCMYhe1awyqycPpi2ai0nr0qfJTLf9Z0fErxL3EXqiY6oPi/h7405og18Rf56Hk2ga4xDV6usGQfgwT9wp5z67iKIr9o5vnaQUR+//ZlTIYt6oEtRhNUkyreWk9B+3SSUAK6/C96mM6AydJkTclQIt7ezzRjYfAcjysnjTEmEv69Ta1wUw3UETS4odEOxZRHpou2kq8z/D4mnxhzp3OQD2CFwYpRlKbhliryPjdticZN0wriyqODWqFwpNZv0YR6GR8gdgo2wsACTGoxy5jVLX3aY68NtTUjq/+ec2PZkHIeevvMGYrx8tO5cPh7WGs+MW35/js+yuc4dt713SuoonaTgKUiXkGLa2f7LA6GM0crvVnxAWoeJQ/kpPjLMAFkWbW4VC+FF04IKCSY5tbrsCqKwoJ/bRzfpLMpWdbw96eSrUwy10i/oZ25E0RSM7DWwa2YsTNL4kbAwio2jFs/42XwN5QvTgsKU5m+td4kCHnuwUP/I4e2XkX4ik24fK6onYDm3Nt5Dxjjg+WVRSKzrc5+tiWbFBp9n3EtMFhTjcTMb5NLHUglCJA5QaIchdR+kkgQ/hPoDqsaEUt4XWAOHniy7PTvGHGys59KF6Fm6BMvy5MQ1A5H9T6l0ayF4B7OscR11Oa77Kz3rdFTdlXqCFldc2nIP3dbHKJvI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR04MB7322.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(366004)(451199015)(36756003)(31686004)(2906002)(75432002)(31696002)(86362001)(8936002)(4744005)(5660300002)(38100700002)(478600001)(83380400001)(2616005)(66946007)(6916009)(66556008)(786003)(6486002)(316002)(8676002)(41320700001)(41300700001)(6512007)(186003)(6666004)(6506007)(53546011)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUE5S0JJZHJHT01CL1BvdjNzeXNnUXV0ejlWdmIydmFxczZYSXA4VGZkSEVx?= =?utf-8?B?NVovRmVZOE9zK2VsVGJkeGVyR3JpVUtHVGVyZUNzdXlYblRlMUVYTHdmNVBv?= =?utf-8?B?eWlnYjdPUFFYd0EwZHpUMzVaeHQ0TDJDVFN6cEhQcWZDdjFiRGd0ZzltK0tK?= =?utf-8?B?R0xkMUk5bXhuUHhJNFU4dDZhaEQ4bXRUQk5icHgzdmd2bjJmd0hGdTRNSWNP?= =?utf-8?B?SlM4NHdzM0FIMzVIMzczcXpZUVV6a2YvdXJrNTJvL2N2b1VWaDZxSERqNW12?= =?utf-8?B?dm9PRnRLVDRzNitTdzBtUUNseHovSWpROFBqalFyQzdnU1V1blhPRDFyQm50?= =?utf-8?B?SEJrZ1ExYlRvMHNKYTRsdzAvM0dKeHpNZmlXTzAyb0FQTUtNOGkwWHpvWkxS?= =?utf-8?B?TzJpakFZN2xrc21JcThzZDdZWVNpODlRWXhNMEdVbDQwbStndW94RGJHallM?= =?utf-8?B?aGNhNFpwRVltZWVDeU5ib0FhL2c4TVVhcm1QaWd4MmEzWFQ2NjFGNHBNcjY0?= =?utf-8?B?OVkzVlJyd0pVVWVVWFJ3S2plWjNVWEc3VUVQR3Q5MndwUUU5OVZpbmhSdTdQ?= =?utf-8?B?ZVg0akhMcEQ1SndJQng0TysxbWl5ZXNscktldHBwTjdRMVlwVTQxd01oQVVL?= =?utf-8?B?UDB6aWY1M28xazQ4d3dWQllyMkhtNE5mejh4K3MvYlIrcm9yQWVZQ2pWWTFC?= =?utf-8?B?UWFCcDBSSHZGS3Z6Q0xjNlJOYzlDL09jSFV4YUFsOFdoZVM5VmdVZk9FamdC?= =?utf-8?B?WWRRbkIyS1orR2xQVmxsdXd1UDF3Q1lSaHR0cHFrZFV4ZThuREVKWTJYYnph?= =?utf-8?B?RnVFdFMrZUE3eURaS0NidWNIODlHM25uNGZXb2IxVmNJR05TSmp2VTNpSmFK?= =?utf-8?B?a3JGVm84NXJYM0IzbXNjNFZnVFp3em9WNkV6aklqcDY4ZHpRZUFWWGdrUHp1?= =?utf-8?B?bGp3d2JHVnVVSmpuakNCY3hJb1NiMVNJSEtmWW1QRHpSa2tTVXVLVWl1Nmsr?= =?utf-8?B?c1dUbkx5ajBBaFhXbzlzalU0NkNwc3dTclhzTUwrS2hQWVBibk9BZlNtZFd6?= =?utf-8?B?SzFLRGxRcm5QMlJDNm5lbjNwSFFBMW9yN2dUNnpqajlOWVNsR3oyQ1dCNFpO?= =?utf-8?B?S3hCYk9IWFpMYmtpWFNsOUJJMzFmK3ZFUlQwekl3MTh0Yjd3Nys5L21hcjFU?= =?utf-8?B?amEyNFdsVU1PbXI0bkFkYVZ2bHJwbVgzV1QyTGRKSnBHakpaWktacXRFOVNx?= =?utf-8?B?aUJ4UXhWSkJrVy9qcWUyZG1wMXlwQ2F4a213cDUzVURjMHZVNCtVdWNyNHRQ?= =?utf-8?B?dFBadGoxZGIxaUtkMDB3VjhRdlRkL2NlY1E3SDdCclFJcnAyV2Y5MmRWMXpk?= =?utf-8?B?eXhRSUx1a1NkRVRIYjJOM2w2Mlk1KyttaDl4dThvUlBHcGVBa0srSW9aZXgr?= =?utf-8?B?WHc5OVpZYUtCV3JWU3N1eHQ4T1VGM2kwYUxCTmV3YUhqVUVwOUphK3lWQSs2?= =?utf-8?B?UVZMaDdaYkk2aDdiRmNPeFRxTzE3QzBQdzYxTkZsR1Q1eDBXTGZ0OWVJYXY1?= =?utf-8?B?dmNIaEpxaHJaN2UvNlJZNEhCV0hkbVhGWmovWTJUNWRrMW80S2dCVzg3Vk41?= =?utf-8?B?RHBaZkVxSTMzc2pGNlNod1hXUVlaQUdmYVIyTk1DdWdFT1pLUU9pZ0VkZWRv?= =?utf-8?B?MUxJYkVXQS8vUjRKL3BtcHhDNGFKT254eGJTN0htb3htbzI3WkczbUNlcXFt?= =?utf-8?B?UGtmcTVCTCs4cHlNTXhxc0NqdkNqbnlhd1NsaGVRTFZhb0tKVUN6cHpleFVE?= =?utf-8?B?THhza1FpMmlnOEp4THZUNE9JNFViUFlEUmY0LzA5cDk5QnhpZjNnSC9EQi9D?= =?utf-8?B?VHZhNkExWEJZS1gvUXZOWjNHQzFjeXFiYmQ4WFE0RWQ1dmxSNm1oSG1uWlNG?= =?utf-8?B?eEtxMlMremt3QUNJdjZlNTN5TGUxY3FPZStwMDJZWUJDOFFiaWNCT1N2N3du?= =?utf-8?B?UjNGMHBXb1pLWmluVmRiRU1ueFNhaVNZQlRGV2QzSVBIaFZXVU5Db1JSNjBR?= =?utf-8?B?OFYxcEwrclZJTVZOL1M2L2ZkVU9KUU95Z01OWlN3ZVRTNCtYZWJSRisrU3VB?= =?utf-8?B?TDkvdkpwTkVYQzdEb1RXYmk0cjFmY3p3bnh4ZzJRUzVRQnMwdkpTbkJUZWtM?= =?utf-8?Q?upiO8+DRbmOPdA14n2t5fzOerkudJ5FjGKHOqZzmpGO5?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 58492a2e-e994-4ae0-04ad-08dad95eb7e0 X-MS-Exchange-CrossTenant-AuthSource: SA0PR04MB7322.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 20:56:47.8432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rUjcSNn5/soZUhuh53LZcCbGoCYI80i6YzNM4tr9LzH/7A4p+ry9VaRYNr7Nvow721oPllvdBSfiyXBrxUg+Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR04MB8061 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/8/2022 10:30 AM, Corinna Vinschen wrote: > Hi Takashi, > As for the code, I have just one nit. Don't use GetTickCount. Use > GetTickCount64(). I just noticed you're using it in tty::wait_fwd as > well. Please use GetTickCount64() there, too. This way you can > get rid of the overflow handling. > > Ken? Any more input? LGTM. Ken