From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2117.outbound.protection.outlook.com [40.107.94.117]) by sourceware.org (Postfix) with ESMTPS id B35B13858414 for ; Wed, 8 Sep 2021 17:43:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B35B13858414 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cornell.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cornell.edu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iinbpXe04ODiiPIBOYWrziZawFvk2XYQbBbBwUOEHhZoIX/ktb4zVikx3fbOVUGkgw2dUEpSguSbxU3AYa+mD5AcC3GdITmsLCgUlUXhRihntYVUF/2akE03TE+FKTHfdppJcc125SArgYN9AkqWLzGC2DhPchhwiplZ8sub1c1ZKf0lofTnNA8/2uJmNsjz3VyflJIN/tPnizrdWpxligzi8ve2PBmidO5ooZ/8RWPJaYyjJlJnzzRX8tG77MmFpsJwYjnGXDLvIy1PGXxJM6GrX1faYOSBfGN5QYg+QXliCEfFd98XxODqPCW/O0Ob8if/+xZ1fAH/Wpbfs0gJhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YdR59iTbxlxzlaUKXwxjv3NGe893qZs3rBJrKFcgqoo=; b=RhTNz2uCAHMsb5w/K6e6s14XFFgVB+481twMQuZnZ3GcDpjxf1pQHmGkqfHF4J90mDJY8P1ODPL+5Pkuzk9VrqnrUXEaRndTG3fuCKPVvpt7GAUHuYWyd6+MNRCN31QN7iVKeQPpx/MBzfv0jPX8bnMXYQwnw6/dxNrJICr4mNr7HfI1431vRVzjiY/UmjQpoQNABvLavpInIwKVkcOSXCoSBR8/Wlj43G4ORJrBEifJ0HhEehACK2bnbXwFcC3bM2UrxgYMdcIY9t4F/zsJWfpmE+qruVqkP5IAk7OxU56V9um3BkKCLOKYV1cAZ+C92Sm5SRV1mnEjcQguOARM0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YdR59iTbxlxzlaUKXwxjv3NGe893qZs3rBJrKFcgqoo=; b=ZOfRsZPpgN80qaprSOYYrUU6TI+X+vJe3G35f6zZHfJxSzAfuGpLIVIeaZ2GBJ1ATM8cMgosLGOZTKI2bgHWUvROVpp6XPHhpGwv6ZEM4ONvK6OOuTzQzDV3eFew2knwrswFfszY9xmfchU+K1lVV305t4v183zIuJ6AjEZeHBk= Authentication-Results: cygwin.com; dkim=none (message not signed) header.d=none;cygwin.com; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN3PR04MB2323.namprd04.prod.outlook.com (2a01:111:e400:7bb6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 17:43:30 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::b510:889b:1fd0:d80e]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::b510:889b:1fd0:d80e%7]) with mapi id 15.20.4478.026; Wed, 8 Sep 2021 17:43:30 +0000 Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? To: cygwin-developers@cygwin.com References: <20210901172339.1039604b7067e0492534a20f@nifty.ne.jp> <24138e20-aa97-cfea-bf48-198fc67755ea@cornell.edu> <9ba687eb-f4a0-18f8-b10b-76e7e51e123e@cornell.edu> <152bfc0c-2f72-c684-6fc5-aa7c36c136b8@cornell.edu> <20210908203234.8cc6215e05108d9ad0507bd3@nifty.ne.jp> From: Ken Brown Message-ID: <9207824e-bd76-d99c-8801-b42fdbcb4d17@cornell.edu> Date: Wed, 8 Sep 2021 13:43:29 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR04CA0071.namprd04.prod.outlook.com (2603:10b6:610:74::16) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 Received: from [IPv6:2603:7081:7e3f:3419:8129:b439:48b:c2f3] (2603:7081:7e3f:3419:8129:b439:48b:c2f3) by CH0PR04CA0071.namprd04.prod.outlook.com (2603:10b6:610:74::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 17:43:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7dd6fc9-6a3f-417a-784e-08d972f02be4 X-MS-TrafficTypeDiagnostic: BN3PR04MB2323: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5U75pb+DkTmgDNY3zt2eJFuyltHFW1rJSa0KB+XcikSSxIj3m9v4juQILInJunBgL9UEewrPgFLHh4C3TritNNXE5hMrLFwsn5Abn1297rw+gYOWr+0qRmayk+eaXGu7RUxvuAwYQRuZT4FoeTb3bbTfqvCS1/RC+0hyF6IZpqyKVHsolxkBoZN1/9yTG9vnZ8z8ZJ6aH0ramkAmm8JQnu8WkhCq00E4JcYOSRgjshJm4JoJI1PKCdS1hVF5xzI0keRJ8NIZCuQ0dtP1Swn7uDxwtjK7ozTpkE7ksm6xMQ/Il8kU5ky6wp+E1EiITsvs0mZXm5zbH59B2TZiqzgmOlVROO+Q31pZ6N5P8y6ImKvzjNL98JCPHbVxRXYOepP61XolEolw8kJ1X+IfC0jt6ktOWrp575rP4UqWKaqrpeQG6KwKGBkPWDE75eQC1H0oX7buufFq1Zr/TsOD+It6Zm1b2ooEQpML/O5P+7udZaoKXaLUtIwo1Df1qPxmod3QIbbUT+shxBdsUEcYaeVtgRFJ7w/s2Q5gDLfnapWACqqPPbJXjsHpTOVUpF+kSsDyJmegZWlUlk3/VADiPlo64hTBFPhNkU0MCnayR0Bykyr/Of+csLk6ujPUkiyeDBZ/L02GiPcWW7XTeppP4pT4pR0kwKNl0IvN0p9d1cmBcpO5OnnqDJO0ipvYDhi7d0v/w0en4JzQUAdgZj/2Vr0t3R6mC/ZYg+XWq1z1lh+pz+I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(376002)(366004)(346002)(136003)(6486002)(66476007)(8676002)(2906002)(66946007)(75432002)(66556008)(36756003)(31686004)(53546011)(31696002)(6916009)(38100700002)(316002)(8936002)(86362001)(478600001)(186003)(4744005)(2616005)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?9rqgXm2j0Y1DmF/WPuv6T/73bEKOai2qx88MMUC6sjLB4mVz9IpcgWOT?= =?Windows-1252?Q?W7sjodiV1fohc9D2AzxWiozQdj5uhx+vftPtyrSFzzNNnDD1RNPa1CVP?= =?Windows-1252?Q?JzXnMyAgkPkFGXUMtCJW2gu86AdBr8MeobyBQ9zu7bGT41nAv+v6cPfE?= =?Windows-1252?Q?khZK6Tmtz0Yo97rNiGidnogNYARDaUFIyJSQv2FuX8mKngIoMsKxGNir?= =?Windows-1252?Q?ulu8pvCCxecIrRxbVWlZUQTne9GTq0ZQ89UhxYUdHKVb2ImAHjX9J1Bn?= =?Windows-1252?Q?8NV+Qfvmf+e4bioEbpWkBeWalu01TtvV1AjaBDI+1NOmA8Pb8NO79hNg?= =?Windows-1252?Q?zNbhIWYDkxuiSX+8cKQHNKR8lrJ0kQkXbm+bFDVwWCkF4kZr8/CFBJuV?= =?Windows-1252?Q?+CuG7KISoDX6aeQXB+NQpaF74pESlqVINc4BZ0BZ6mns1WQj6n2tueBP?= =?Windows-1252?Q?JG9dhlVsXTR1oheGG6G8GLuwUkwFfpFpotsUy4N/VpvGa/7Y5zTaOorq?= =?Windows-1252?Q?j3qblglSyeYVM9cmyEPY4N5jwTS7EyfMTYnMeBjZSTfTBcEXNbzmZMcN?= =?Windows-1252?Q?+grMInL7/q8eljJwHfaIUQafCn6bWbVoPsS/O1fEiHvKuc7wvcRiko5P?= =?Windows-1252?Q?XPNzLREVrC3gcdBlLmH/u8014Le8rnwaXrU4jrWjFMPxplJolHYughMi?= =?Windows-1252?Q?cersf7IqO3/b1tRMk9vbOw0tKZznyCcX6EgY1I44A0HwXcF9Gzddry8O?= =?Windows-1252?Q?+RusKBVJtkKAkn1j0D4k9SIn/efx53Hvj+SxS/oT7Qh4KbzWamMrLgDI?= =?Windows-1252?Q?px9d7YEWeuMg8KeiuZZzkBovEP9HIDAWk1frKgHZIIoPBFw3jypIzXNM?= =?Windows-1252?Q?gUFmzUxhG4ziZZQ+ClYl8esglBffendHSSE8OehO5aNLM5mNze1V/tyn?= =?Windows-1252?Q?fBihvg+jhhU0Jlf6IJFGDLPwUsvYUvwmiIh/dGSpd4x7l3u2rr9vhvzy?= =?Windows-1252?Q?38XctjJy+U3j6I1xavvBGQzGkszgm1tMfuFM+cz+wv0d+/pmEpWe99PM?= =?Windows-1252?Q?gPKo3w8PqxYJbkN78uB538A8yQSJcuhcFOiqfh/GH5lDPrQ+XhB6grU5?= =?Windows-1252?Q?c7JIMC389A+aDSbWgW7auGFV4dfgYuXlhCkjz3vwQDEAg6YSwt4kRMKF?= =?Windows-1252?Q?NJAQSjulbDfNa+Oloiyah05EdETbj4bIimJnaHVP8gPIkArzq5LDd4b1?= =?Windows-1252?Q?lcYbEqLlZcs3bTD0loiI1DUJzrVMNwcvyGPSAT4cfxqnNVWowgHdD/Z7?= =?Windows-1252?Q?USkBaL7ZicZXGJwKZClR4OQR+jxxwunTMD9p1uWWR+c3EMsznpmeX2Uu?= =?Windows-1252?Q?AlnkSka9D6X/PtyW+U+21tPVJTatsu4v0PWBWVQlLIUlZfXSiCKVq4LU?= =?Windows-1252?Q?qUXSRr/J2bABcFAyVha6BQR0jOMcv7XuSVnbE+F9mYZvRS7lpjHOXSe8?= =?Windows-1252?Q?YHN9YYFT?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: d7dd6fc9-6a3f-417a-784e-08d972f02be4 X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 17:43:30.5455 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AG5v92GZC7FCVJXYqx7VWyhexYUb3zaTq4zaQGvM8J1Y+EzxqLBYnSIjhXMXEAUxf854cu9u36eJOcqBs3Vyfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR04MB2323 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 17:43:36 -0000 On 9/8/2021 7:55 AM, Corinna Vinschen wrote: > On Sep 8 20:32, Takashi Yano wrote: >> As for this patch, read_mtx was introduced. This handle is initialized >> only for read pipe. However, this seems to be NULL even without >> initialization in write pipe. I wonder why initializing read_mtx in >> the constructor is not necessary. >> >> How do you guarantee that read_mtx is NULL on the write pipe? > > fhandlers are always calloc'ed on the cygheap, so you don't have > to initialize anything to NULL. It doesn't hurt, of course, but > it's certainly not required. Takashi and I both asked this question, and you had to answer it twice. It's likely that future readers of the code will ask it again. Would you be amenable to a code cleanup patch that answers it once and for all? I would suggest (a) removing all 0/NULL initializers from fhandler constructors and (b) adding comments explaining why they're not needed. Ken