From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m0.truegem.net (m0.truegem.net [69.55.228.47]) by sourceware.org (Postfix) with ESMTPS id 550D63858C3A for ; Tue, 21 Sep 2021 09:28:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 550D63858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=maxrnd.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=maxrnd.com Received: (from daemon@localhost) by m0.truegem.net (8.12.11/8.12.11) id 18L9SW5c019800; Tue, 21 Sep 2021 02:28:32 -0700 (PDT) (envelope-from mark@maxrnd.com) Received: from mfone.maxrnd.com(127.0.0.127) via SMTP by m0.truegem.net, id smtpdYHMJDu; Tue Sep 21 02:28:23 2021 Date: Tue, 21 Sep 2021 09:26:09 +0000 (UTC) From: Mark Geisert To: Takashi Yano Cc: cygwin-developers@cygwin.com Message-ID: <933038b4-7dc9-485f-ac87-598cedb00fc5@maxrnd.com> In-Reply-To: <20210921173035.d3f61cb132b7dab80fed352c@nifty.ne.jp> References: <20210909211940.51ef391e27d43f0421962cb8@nifty.ne.jp> <20210909214246.cd1ff1a3062fea27e51ad4ae@nifty.ne.jp> <33386baf-3b2d-d57f-2ad3-1bd328ed7935@cornell.edu> <20210911075734.aaf37697ba7db2ad Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Correlation-ID: <933038b4-7dc9-485f-ac87-598cedb00fc5@maxrnd.com> X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2021 09:28:36 -0000 Sep 21, 2021 1:31:28 AM Takashi Yano : > On Mon, 20 Sep 2021 17:39:54 -0400 > Ken Brown wrote: >> I'll push it tomorrow unless you find something that needs to be changed before >> then. > > * Add name check when cached information is used. > * Confirm Name.Buffer returned by NtQueryObject() is not NULL. > * Add error check for HeapAlloc(). > > -- > Takashi Yano Sorry if this is a dumb question, but why HeapAlloc? If the buffer is only needed temporarily wouldn't alloca work? Or malloc? .mark