public inbox for cygwin-developers@cygwin.com
 help / color / mirror / Atom feed
From: Mark Geisert <mark@maxrnd.com>
To: cygwin-developers@cygwin.com
Cc: Takashi Yano <takashi.yano@nifty.ne.jp>
Subject: Re: [PATCH v7 1/1] Cygwin: pty: add pseudo console support.
Date: Sat, 17 Aug 2019 18:10:00 -0000	[thread overview]
Message-ID: <Pine.BSF.4.63.1908171109430.88493@m0.truegem.net> (raw)
In-Reply-To: <20190817083626.GA11632@calimero.vinschen.de>

On Sat, 17 Aug 2019, Corinna Vinschen wrote:
> Hi Takashi,
> On Aug 16 01:09, Takashi Yano wrote:
>> - Support pseudo console in PTY. Pseudo console is a new feature
>>   in Windows 10 1809, which provides console APIs on virtual
>>   terminal. With this patch, native console applications can work
>>   in PTY such as mintty, ssh, gnu screen or tmux.
>> ---
>>  winsup/cygwin/dtable.cc               |  50 ++
>>  winsup/cygwin/fhandler.h              |  42 +-
>>  winsup/cygwin/fhandler_console.cc     |  32 +
>>  winsup/cygwin/fhandler_tty.cc         | 843 +++++++++++++++++++++++++-
>>  winsup/cygwin/fork.cc                 |  24 +
>>  winsup/cygwin/select.cc               |  22 +-
>>  winsup/cygwin/spawn.cc                |  55 ++
>>  winsup/cygwin/strace.cc               |  24 +
>>  winsup/cygwin/tty.cc                  |   8 +
>>  winsup/cygwin/tty.h                   |  24 +-
>>  winsup/utils/cygwin-console-helper.cc |  14 +-
>>  11 files changed, 1093 insertions(+), 45 deletions(-)
>
> It looks like there's some timing problem in terms of stderr output.  I
> just made up the example for the Cygwin ML discussion about the mcmodel.
> When I start the code built with -mcmodel=small I expected the output:
>
> Cygwin runtime failure: /home/corinna/dll/main.exe: Invalid relocation.
> Offset 0xfffffffd80348989 at address 0x40000103b doesn't fit into 32 bits

That particular error message doesn't go out on Cygwin's stderr.  It's 
done by a Windows WriteFile() on STD_ERROR_HANDLE followed by a 
FlushFileBuffers() on same.

Not sure that it matters, but perhaps it does.

..mark

  reply	other threads:[~2019-08-17 18:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 16:09 [PATCH v7 0/1] Pseudo console support in PTY (v7) Takashi Yano
2019-08-15 16:09 ` [PATCH v7 1/1] Cygwin: pty: add pseudo console support Takashi Yano
2019-08-17  8:36   ` Corinna Vinschen
2019-08-17 18:10     ` Mark Geisert [this message]
2019-08-19  6:36       ` Takashi Yano
2019-08-21 15:41         ` Takashi Yano
2019-08-23  3:19           ` Mark Geisert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.BSF.4.63.1908171109430.88493@m0.truegem.net \
    --to=mark@maxrnd.com \
    --cc=cygwin-developers@cygwin.com \
    --cc=takashi.yano@nifty.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).