From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@maxrnd.com>
Received: from m0.truegem.net (m0.truegem.net [69.55.228.47])
 by sourceware.org (Postfix) with ESMTPS id DEE563870887
 for <cygwin-developers@cygwin.com>; Fri, 13 Nov 2020 06:02:20 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DEE563870887
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=maxrnd.com
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=mark@maxrnd.com
Received: from localhost (mark@localhost)
 by m0.truegem.net (8.12.11/8.12.11) with ESMTP id 0AD62JJq037509
 for <cygwin-developers@cygwin.com>; Thu, 12 Nov 2020 22:02:19 -0800 (PST)
 (envelope-from mark@maxrnd.com)
X-Authentication-Warning: m0.truegem.net: mark owned process doing -bs
Date: Thu, 12 Nov 2020 22:02:19 -0800 (PST)
From: Mark Geisert <mark@maxrnd.com>
X-X-Sender: mark@m0.truegem.net
To: cygwin-developers@cygwin.com
Subject: Coding style question for Corinna
Message-ID: <Pine.BSF.4.63.2011122152520.95690@m0.truegem.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: cygwin-developers@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin core component developers mailing list
 <cygwin-developers.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-developers>,
 <mailto:cygwin-developers-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-developers/>
List-Post: <mailto:cygwin-developers@cygwin.com>
List-Help: <mailto:cygwin-developers-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-developers>,
 <mailto:cygwin-developers-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Fri, 13 Nov 2020 06:02:23 -0000

Hi Corinna,
I'm about to submit the patches for a small improvement to Cygwin's malloc 
implementation.  There are several places in malloc_wrapper.cc where I 
have minor code repetition inside an #if.  But it could be coded 
differently.. so which of the following forms do you prefer?
--- form 1 ---
   if (!use_internal)
     user_data->free (p);
   else
     {
#if MSPACES
       void *m = get_current_mspace ();
       if (likely(m))
         mspace_free (m, p);
       else
         dlfree (p);
#else
       dlfree (p);
#endif
     }

--- form 2 ---
   if (!use_internal)
     user_data->free (p);
   else
     {
#if MSPACES
       void *m = get_current_mspace ();
       if (likely(m))
         mspace_free (m, p);
       else
#endif
         dlfree (p);
     }

Thanks,

..mark