From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by sourceware.org (Postfix) with ESMTPS id 8C3D83853D67 for ; Wed, 23 Nov 2022 09:08:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C3D83853D67 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M5PyX-1owOpF0Gmb-001UKC for ; Wed, 23 Nov 2022 10:08:12 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id 955B3A80A35; Wed, 23 Nov 2022 10:08:11 +0100 (CET) Date: Wed, 23 Nov 2022 10:08:11 +0100 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: tty.cc and fhandler/tty.cc Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20221122173115.b94b586200e0accf88512309@nifty.ne.jp> <20221123074632.f1799d6f6039973e9bd000d6@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221123074632.f1799d6f6039973e9bd000d6@nifty.ne.jp> X-Provags-ID: V03:K1:O5DVxwIeRL71+B+bm9iCyeST2XpjOF0BNQX5zVClbtsy/BEAb7F HnwSHPGDLlLqrKf2R9i5UsTCKZ+AGjzb/Zg0ZaVcpOCqUzE2kNR6DiXzhbAjUaXqdaVbU+N LSaqAn6rPFPTkJlcA666ucoX/k2yK+XfXmTXRDgSEFioJxdLBqt5e6nXxmGr2+X3CG+IirG 0eqIbt5e+TTAWkxqZWaBg== X-UI-Out-Filterresults: notjunk:1;V03:K0:BcbYwmxkaAQ=:rzdRjlOZt+goDwPLJTjFBg dqbrhPzdkuIqNcvvYHWfvD9SlodETURef1cA3Jnf9somdUEvxOBMvwkFtLpI8ADlRjL+OLUJn toWesuYyNRYUn7wEEZSrdpqxj/Rd9uJ0FYxRS5KfXku06fd/BBzCBrAemlafMxBpf61U2f5Y7 LeFc6psVl8np2qXbq488qB5lB9WXnHG6B9r/2Wzwg+0DFNACvFIW7wyB9rDvY/uhedH+DVBg/ iBmD349vaq6Xr9LJ2NNxXPFyMNhtNkguSqGTxolO0MYL9xQc9sNTNdys3LPw5qZqkhCQIJd9P H5xuLbus82c8D1V3iioUJKITu4nWX+hTaeCZRuiu0UAeui7rqOHI1gnRAzuPvWWmgEFwecbHf nurwTsVhHNMbR8Dh8PED8r53sN/HSbrccUrLsD8ohvmJHnOiGXpBP5CTJZFY8+Pr8G9LPW4qT 5/dXCp53eKNTvgA1CwYr1mRbwrSNXoeai9Y1Bf6k38tzRBrnyHO25c0baizcSBZ/bxmzdJucD tLXs9XxiWbNgb+1QBDLOdXJjbaJrlnZZGzZtwA/7RVPF/AVixhIdFo9P7C38v5ChkwIumXFSQ SNWe0lWwwQY/oDAXWNF/c+ZBvnQnL3+BEqN1FRwwAHibkINbsZvkZhW0rOePYpxrxAzJPKLCx fgzObAX87qQojjJs6D2H7u74VVzLBjepp8T8iiGxfCd/keApdF3BwnCnFiXIglrBtEd3dec9c Gxfmtqmwl3qEqxuhYAEetTAxON9Q17x/VA9wx0nQ+OBgt3vs00+9ZEFlzr2Uk1SvsuAyZzwOj YqHWcnBboHD4LxndzuA6j27+uSBtQ== X-Spam-Status: No, score=-96.1 required=5.0 tests=BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_DMARC_NONE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_FAIL,SPF_HELO_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 23 07:46, Takashi Yano wrote: > On Tue, 22 Nov 2022 10:36:28 +0100 > Corinna Vinschen wrote: > > On Nov 22 17:31, Takashi Yano wrote: > > > fhandler/tty.cc is defining fhandler_pty_{common,master,slave} class, > > > so, what about renaming fhandler/tty.cc to fhandler/pty.cc? > > > > Maybe we could split it up. The extern functions could go into > > syscalls.cc and the tty classes could go into fhandler/termios.cc, > > perhaps. There are already two tty_min methods in that file. > > > > What do you think? > > It looks good alternative. > > On Tue, 22 Nov 2022 10:50:46 +0100 > Corinna Vinschen wrote: > > If we don't split, maybe something like tty_helper.cc would be more > > feasible? tty.cc mainly implements the tty/tty_min classes and at least > > the latter is used for consoles, too. Pty.cc might be a bit misleading > > Well, I meant > winsup/cygwin/tty.cc > and > winsup/cygwin/fhandler/pty.cc > . > > Not > winsup/cygwin/pty.cc > and > winsup/cygwin/fhandler/tty.cc Oh, right! Yeah, that makes perfect sense! Thanks, Corinna