From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by sourceware.org (Postfix) with ESMTPS id EC85B3858284 for ; Thu, 24 Nov 2022 10:18:29 +0000 (GMT) Authentication-Results: sourceware.org; dmarc=permerror header.from=cygwin.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M5wc7-1oqkmt1xTn-007Y3q for ; Thu, 24 Nov 2022 11:18:28 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id D4274A80A35; Thu, 24 Nov 2022 11:18:27 +0100 (CET) Date: Thu, 24 Nov 2022 11:18:27 +0100 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: tty.cc and fhandler/tty.cc Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20221122173115.b94b586200e0accf88512309@nifty.ne.jp> <20221123074632.f1799d6f6039973e9bd000d6@nifty.ne.jp> <20221124172402.214c49a8aa0a65fd411b7497@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221124172402.214c49a8aa0a65fd411b7497@nifty.ne.jp> X-Provags-ID: V03:K1:ab7XlkMrfBMH9gYyyLzWZBN80kAOJ606VpaIaKcu8AA+RChVnzs XOZ8mBv50ffubasTkv8ZEyyiM/4PvnapEjpzWKj61rgrIPxAVtxnGfFBYF8CJ+yPQKVxO0X o12BlrSy7XsRlKuMuVU1/GIPa1T0fI+D+q2DBbeguEEmdcfXu0bpM6zZm0e658gFI87P4HR Y2XPCRasFURsD7InqJtxA== X-UI-Out-Filterresults: notjunk:1;V03:K0:AdS83OSnwxo=:LT9BtBXt1PcNq4exG21peJ xqqhE7WIW003uMZpbQay4+SmcmdJwDm5Xi/bdHFmaYO1kze6Ty5BAEowG3FxdYtXGtsarTCtE QM7Si/amBksVJ9DislbK+Nx80trSg3tMr+BSkCS7yhG09N1z2ZHmfS09kgGJpqGLX6Z6+SUAo vVYymSnb0uyxv0ibHh+gGnJiZR+OqzdGBRBhtKVVxbxbeuBjbsHcP3phT7gA9SDvaC9cDf7G/ zbXboliOrNr4bt4X82cMOHgY3n8ltRoTkrf6oKw4s1FHy6mQaPauL0SbzGKXl4LQYBUPIowrX S8Efz6VyY+EW9XarTh9rNhbVv9zeuXA6wWfwaNmFcpynF2F2tB08yKnUw5BCmn8Cpp9O5dxEO TPTHBRGT9cX0xqq3IGgCh4ek8CkLFMQqGDpbBoB1v1BkkJJzvfgeohnS2ZjOqkWBZLm3rikcf 99fPTfuEfriYKTZSGCnMAI+sNSzRkuSzce4O1HLdxCJgm721xjlpTEpcJwCdijLymqguyzmq9 VUA8HjxiKZpVd5rcosDCZ0/Qza6z1/xcSwBqcNYR1prHpQUzEzVCIA6adMrBZX8jIHmLpvJTe vcBpQZeGi62Thc2LjmBmZ/182qAytjWbmg5u5RKEQfG6e79L6XGJ/feeTK8D0O0jW7sKiQGf3 CFGmtbXd3jl5eAhZyLX+WarW49LiCLb/ZwHB88Y5YtuNLI2gcRmvLEwY2Xp5FC6ErQ1bPF0r6 qMDEimkcB+LiFQ5c2S01eMfx+bJz7mMySFmC6dhPjbYntXxkf/qotkGQTSkUBYR87DNzvyhJ+ WAFUWgHJzSQZKsEOWqR6Y6l/gmXyA== X-Spam-Status: No, score=-95.3 required=5.0 tests=BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 24 17:24, Takashi Yano wrote: > On Wed, 23 Nov 2022 10:08:11 +0100 > Corinna Vinschen wrote: > > On Nov 23 07:46, Takashi Yano wrote: > > > Well, I meant > > > winsup/cygwin/tty.cc > > > and > > > winsup/cygwin/fhandler/pty.cc > > > . > > > > Oh, right! Yeah, that makes perfect sense! > > Then, which is better solution? > > On Tue, 22 Nov 2022 10:36:28 +0100 > Corinna Vinschen wrote: > > Maybe we could split it up. The extern functions could go into > > syscalls.cc and the tty classes could go into fhandler/termios.cc, > > perhaps. There are already two tty_min methods in that file. > > or renaming fhandler/tty.cc? Renaming fhandler/tty.cc to fhandler/pty.cc is the better solution, I think. Corinna