From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.134]) by sourceware.org (Postfix) with ESMTPS id 8A29C3858C66 for ; Tue, 22 Nov 2022 09:36:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A29C3858C66 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MSLEm-1oUuV32D5E-00Sba2 for ; Tue, 22 Nov 2022 10:36:29 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id CFD28A80974; Tue, 22 Nov 2022 10:36:28 +0100 (CET) Date: Tue, 22 Nov 2022 10:36:28 +0100 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: tty.cc and fhandler/tty.cc Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20221122173115.b94b586200e0accf88512309@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221122173115.b94b586200e0accf88512309@nifty.ne.jp> X-Provags-ID: V03:K1:MWQJ4NR8xn2z3VPJpNZqffFodlDnGvhBoFXNf5fKi1yR30zJA4W yLw3noQqatxYOMZIprA4qbJLZp+/1nrzjHQUEi3XT7ALNax2d/p9cvaNgl3pSmIrHAjJeaY KIX/hdD0AP0X4W5ILtG/216K93ZW9gqcLlmMz7YMP8WqfPBq3g6dfHXBxYnEXFJ2UP3mvYH ONGJUE6+oJFLLfAXcwfEQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZTcBqwiW/nw=:v4ndv2g9zag9bY0FAI+M6Z oTvtOJnrdvnHV8g3DAtWvux3m9BLcRQE/HTpUsWXoHByctNwPekntvay2yaMt05H1bd0knxUy NEvSF7xHIdIGsB+TVcmBg2sgmnCC4lnjuu+9AHBXPNmnOuiFJuWZZibgmRtll8iXiVFetvIeM LApWZhT4Oob2LXACT35+g6/SO10bOoTxrvTd4/ZkGZG9R9KAqJcjnLJM7Rvc3CHRM3tNdfC7E 1ODwFRXAqSeoCHYp2hacXrxJoKlokP9UpUmLa6oE81NV9XprZvPYl1vjMAOxxjj9ViIb5yd2X c+p0990q60v5zHH56lN97oEa/HcpuF5f+yxwafvP3VGzYCqfhZ5j4whj+Esmp9ms+T0pzal11 9zChKQy1PHYJejhbJTHd6IKsn8w92Rmq3xFPpL1E2uwVE45Op+48Pml7gLHxddxwpqzCM5tjZ aszIZqkhGN/aIXTzZ6RlREVE/Eid4lwt01FcP25xMlinwjoDl++kefaloG6kOEGGrpiwonyXV TCdsY0Jokb/RYeSfHA4d5tAclfaxeWJLhiXMiv0Vg4SG+gXnsBMl+ZjfXXaPIr4XpkkNqxW/O 7nB/ZEIJh7R8hHPWIpEP3+KAIW8so4TbvShiRHhlZptdROAG/XuNEXU97OSpOxJds64rcXcAq ZxlDcjcyLZOZ8WAYipkBJstSSoOKrUN7sXNuDYMthbP5ayorAp3ypUbBEHR/BuWD1xdotabWs 4MKoUhK9ikRhN76l7oxHLkj4UCem0FS3aBRcyx+eYIG7yLN/9l49Q/GOVGzRo5yw/QHO/cO6G M7oildz/b+cWadvnFZwQ0WGgP2XrQ== X-Spam-Status: No, score=-96.1 required=5.0 tests=BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_DMARC_NONE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_FAIL,SPF_HELO_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 22 17:31, Takashi Yano wrote: > Current cygwin git master has two tty.cc, one is winsup/cygwin/tty.cc > and the other is winsup/cygwin/fhandler/tty.cc (it was originally > fhandler_tty.cc). This is somewhat confusing. > > fhandler/tty.cc is defining fhandler_pty_{common,master,slave} class, > so, what about renaming fhandler/tty.cc to fhandler/pty.cc? Maybe we could split it up. The extern functions could go into syscalls.cc and the tty classes could go into fhandler/termios.cc, perhaps. There are already two tty_min methods in that file. What do you think? Corinna