From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by sourceware.org (Postfix) with ESMTPS id B1A253858C54 for ; Tue, 22 Nov 2022 09:50:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1A253858C54 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mlf8e-1pOGDV0gSo-00ilDe for ; Tue, 22 Nov 2022 10:50:47 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id 2A229A80974; Tue, 22 Nov 2022 10:50:46 +0100 (CET) Date: Tue, 22 Nov 2022 10:50:46 +0100 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: tty.cc and fhandler/tty.cc Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20221122173115.b94b586200e0accf88512309@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:xHuzSYH3tR6c49d90PnJ0L2jQEOwDuHGH/alAp4S8XCPpqCHjxm gQqykRnBcRAN55mvFDmd9OQldCTPFtXE+PoaXTWUTAJey1GIXXfSQ41bemGYzpGVm8Q1/lL k6ixRuB6hP5V5Ewvj9/Dr6kW6XBuH9EAEgqcNKQKjC64ti1UcSpHm7tuky7tVF1YyTkX5EX U55s12PBBc+pdzQp8ruWg== X-UI-Out-Filterresults: notjunk:1;V03:K0:yALDbHOg5/E=:A1/Qj3asIpxre/Jo3twq0B oSyvsiHgm7mYZHjNxE+dg9xxEcflzn2oAt9zXP6ZguqHXp0S69vB7ktS9iHi5qz53+AY+kM82 meK3oO9ZgrcPmeC+tVY+Gi/twNwbGN5x20/ruPr7En5Yo9R/KLoMo5I0xIZMEaXhfkH2YL4o9 3RVU/QTVz9sU6/f/eshf9JhV76RCQZCJ3sVmzwLrPw66YJF1JGHZ1kJwPzrAaMVLlDJb9t2KT J0XWj/epc+3W7mkjoeYz2DhJpmpPOvHh6PVBu18sR3YHzRX1xzdzCo8RToS9l8WbaZ+jnuxeh wnDB2xU3YXXNQVJVmCRwObjaWUcS72kuS5OqfThmTDK7n760KBBXloIpPxzPYVfqptY+mLua5 3HmombTWkd/3dmEkW8jvSzIgwD626PDooknzpumMjz/x7xYsUw+xa65Z/aLP3s70Ie2p90mx1 +ShBLS6RcMW9Pe6/NlQyGxeFMGiC1sf9JJbEl6HbIwWOcqddekKP4tcvWu+M5/72l19zE64IV uKJyUjWhWMb8tzdNXCitwY5KZX6kCiGymr0qlmQzrnjMh6+jggw5gaM5MAGz8wjX+eaTIcuKt TTtjsPskNFdEB/N6PsxgTSSXguLTbqru7XWCObMNiYl80xImuML+/MzAgCWR/Ehpb/xa/TODe JtKeStFZe33iRrYdHT1LBB9/No2kLm0PHmpjQF378sfw5bYNQss9czWw4P/BwF04M0LOzpsrT Bh3OLWkjTN7GB95S+CJ+bV5FqaZrSpuqCELF6OKnirwQUaoKOpRXX5rHunf6nimGAQiiodIFM O+7xAcyL1V0k3/vg1RjVXHtD0Yd5Q== X-Spam-Status: No, score=-96.1 required=5.0 tests=BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_DMARC_NONE,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_FAIL,SPF_HELO_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Nov 22 10:36, Corinna Vinschen wrote: > On Nov 22 17:31, Takashi Yano wrote: > > Current cygwin git master has two tty.cc, one is winsup/cygwin/tty.cc > > and the other is winsup/cygwin/fhandler/tty.cc (it was originally > > fhandler_tty.cc). This is somewhat confusing. > > > > fhandler/tty.cc is defining fhandler_pty_{common,master,slave} class, > > so, what about renaming fhandler/tty.cc to fhandler/pty.cc? > > Maybe we could split it up. The extern functions could go into > syscalls.cc and the tty classes could go into fhandler/termios.cc, > perhaps. There are already two tty_min methods in that file. If we don't split, maybe something like tty_helper.cc would be more feasible? tty.cc mainly implements the tty/tty_min classes and at least the latter is used for consoles, too. Pty.cc might be a bit misleading Corinna