From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by sourceware.org (Postfix) with ESMTPS id 270F3398C02C for ; Fri, 19 Feb 2021 17:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 270F3398C02C Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MWzXd-1lNlQb2w2b-00XK3Y for ; Fri, 19 Feb 2021 18:15:40 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id 44230A80CEC; Fri, 19 Feb 2021 18:15:40 +0100 (CET) Date: Fri, 19 Feb 2021 18:15:40 +0100 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: set_open_status Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <562a95df-6685-c6cf-d57d-dfd292925b23@cornell.edu> <827688d5-b3d0-ba02-a81d-9dac62af5c98@cornell.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <827688d5-b3d0-ba02-a81d-9dac62af5c98@cornell.edu> X-Provags-ID: V03:K1:/hC126JNz/vzlb9cIcXZ59kPmCv9xycykXJyInqORTT2kcaQTJY EEKAbmOKWLtxXuiFIIFQtW1O9vfD57E1LUaz4swA1kqWdLWHhMXb6c1OBpjG/580jh09XeD fE3kK1A9foO2z5bWwgjTaIGCUc9fissW5etvGp0tJwGfI1mWH1nbrsQWsU+T2dbH1emrzUE CCIiLJqUFyHruztSis5TQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:pe5fhmCGL00=:Z29yHrauis3ruZ9Cvanr6L GE7Hr8i1U+qPmWljAFzZSGsv5odHENPhdvCms19orS6UggTAE1PgS3rhNjTlEiOwoiGIgfIW4 xEfvqgoYOMH744iy8+jCRXUJbsGPlqWuH9JmpT4qi08fd84FhWt3CVFsJYa+u+dL9l2R3jtDG dDarQbzczMX++TPPDOhuk80FUGj3a/urtgtOcA6SCNSVpvcby+urwYzkgqcXe8DS3RE2kd00x DjLyQsfpz5VFr0Hy/E2dBLw0LOWJ8Hl4yR9ugH6OXa3j88VHMZUMvAx9NKUGBLYBkRySRHQEa ISkMjvRA4ADDP5iI22ZjKJ7z2ICny+g/7OK/70x2vS9dW8VExGsBb4AtkXYjEqpQ3VBPnING5 He8mn26WtAnbipvLKKID1OI3OHbV7UKYH1Cvx80BwEVPDiryUsFo9gVqrw8oAIYcF9vqysYnV D70PaJ3X4Q== X-Spam-Status: No, score=-107.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 17:15:43 -0000 On Feb 18 16:23, Ken Brown via Cygwin-developers wrote: > On 2/18/2021 8:07 AM, Corinna Vinschen via Cygwin-developers wrote: > > On Feb 18 10:07, Corinna Vinschen via Cygwin-developers wrote: > > > On Feb 17 16:35, Ken Brown via Cygwin-developers wrote: > > > > Most fhandlers call set_open_status in their 'open' method before a > > > > successful return. I just noticed that fhandler_fifo::open doesn't do this. > > > > I thought at first that it was an oversight on my part from when I > > > > overhauled the FIFO implementation, but I just checked fhandler_fifo.cc as > > > > of cygwin 2.9.0, and I don't see it there either. > > > > > > > > Is there some reason this would be wrong for FIFOs? > > > > > > I guess this was just an oversight. It's certainly not fatal, given how > > > open_status is used exclusively by fhandler_base::reset_to_open_binmode() > > > in turn *only* called from setmode(fd, 0). This is quite a bordercase. > > > Combined with FIFOs supporting only O_BINARY mode anyway... > > > > > > It won't hurt to add the set_open_mode call to FIFOs but it won't change > > > anything, except avoiding to report O_TEXT mode after a call to > > > setmode(fd, 0). > > > > > > Maybe it would be better to change fhandler_base::reset_to_open_binmode > > > instead. Right now, if open_status hasn't been initialized, it prefers > > > O_TEXT over O_BINARY. That's unfortunate, because it forces us to call > > > set_open_mode everywhere to make sure the mode is stored correctly for > > > this single, and seldom, invocation of setmode(fd, 0). It would be nice > > > if set_open_mode would only be necessary on fhandlers supporting O_TEXT > > > at all. > > > > On second thought, this should do the trick: > > > > diff --git a/winsup/cygwin/fhandler.h b/winsup/cygwin/fhandler.h > > index e457e2785e9b..ac9ee7c9e787 100644 > > --- a/winsup/cygwin/fhandler.h > > +++ b/winsup/cygwin/fhandler.h > > @@ -274,7 +274,8 @@ class fhandler_base > > void reset_to_open_binmode () > > { > > set_flags ((get_flags () & ~(O_TEXT | O_BINARY)) > > - | ((open_status.wbinary || open_status.rbinary) > > + | (((open_status.wbinset ? open_status.wbinary : 1) > > + || (open_status.rbinset ? open_status.rbinary : 1)) > > ? O_BINARY : O_TEXT)); > > } > > Yes, this looks right. > > Ken Thanks, I pushed it. Corinna