public inbox for cygwin-developers@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-developers@cygwin.com
Subject: Re: Question about non-blocking Windows pipes
Date: Tue, 6 Apr 2021 14:57:38 +0200	[thread overview]
Message-ID: <YGxawgspQygCK8PC@calimero.vinschen.de> (raw)
In-Reply-To: <d670ecbe-7270-03bb-c2ea-cc34d5e1bca5@cornell.edu>

Hi Ken,

On Apr  1 10:39, Ken Brown via Cygwin-developers wrote:
> Hi Corinna,
> 
> There are several places in fhandler_socket_unix.cc where you make a
> distinction between the blocking and nonblocking cases with code like this:
> 
>   cygwait (evt ?: get_handle (),...)

I only see this in fhandler_socket_unix::listen_pipe, actually.

> Here evt is an event handle in the blocking case and is NULL in the
> nonblocking case.  See, for example, fhandler_socket_unix::listen_pipe.
> 
> What's the reasoning behind this?  Why not just always create an event or
> always use the handle?

In the nonblocking case, the status code returned from NtFsControlFile
is either a useful status code like STATUS_SUCCESS or an error code,
or it is STATUS_PENDING.  STATUS_PENDING only means the call is still
not finished.  To get a useful result, you still need a useful status
code.  You get that by waiting for the handle.  Note that waiting for
the handle doesn't mean to wait for the connecting client.  Rather, it's
signalled as soon as the async NtFsControlFile call finished.  If the
status code is STATUS_PIPE_LISTENING then, you know that no client tries
to connect, so you can return EAGAIN.

The completion event object OTOH, is only signalled if a client actually
connected, so that's blocking mode.

Two problems with using an event object in nonblocking mode:

- The event object is referenced in the call.  If NtFsControlFile returns
  STATUS_PENDING and you leave the function, you have to use a globally
  available event object, because this address is used as event object
  until completion of the NtFsControlFile call (and a client connected).

- You also have a pending NtFsControlFile until a client connects.
  This is contrary to what you want in a non-blocking call:  You only
  want to know *if* a client connects, not wait for it either way.

Does that help?  I'm not claiming there isn't another way to handle this
scenario, that's just what I came up with.


Corinna

  reply	other threads:[~2021-04-06 12:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 14:39 Ken Brown
2021-04-06 12:57 ` Corinna Vinschen [this message]
2021-04-06 13:33   ` Ken Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YGxawgspQygCK8PC@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-developers@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).