From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by sourceware.org (Postfix) with ESMTPS id 017DE3858401 for ; Tue, 31 Aug 2021 09:43:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 017DE3858401 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MfpKZ-1mvxfv0xmD-00gD9w for ; Tue, 31 Aug 2021 11:43:14 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 6FDE3A80D9A; Tue, 31 Aug 2021 11:43:13 +0200 (CEST) Date: Tue, 31 Aug 2021 11:43:13 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20210830092259.52f7d54fc3fa340738373af4@nifty.ne.jp> <20210830170204.fa91eaf110f310f13b67abc3@nifty.ne.jp> <20210830210423.00df7f37473b0ac1251e880f@nifty.ne.jp> <932300c9-2e09-5ee5-bbb1-3c060d33e3e1@cornell.edu> <474e1343-9cba-6b3c-b952-c92004968d8f@cornell.edu> <368caf0f-c5db-50bf-d116-391de61db748@cornell.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <368caf0f-c5db-50bf-d116-391de61db748@cornell.edu> X-Provags-ID: V03:K1:rT1Hsg0oWzM3kf8QMETOnmutVmWbBBCH7D+H+TqabxvkgTOna5Y yj56gfcaAzcBokKmMukPDQPT8rknXv5dvQBykJKQylifknDs/OdyE913iPN84xILfKCAQdF 8cGktXfUKvPpJKMBhGTK3cx/8yOQkL7Vy3T32/mM9z5+N3kSyovhgJGNomj8FVxRzOyT4zP yBse4fpn2kfTPcK7zbJEg== X-UI-Out-Filterresults: notjunk:1;V03:K0:kjUsQiKOAsA=:EWtSBLdgSE+aUPlovOM9Sp KPR0YIFTSOY7CAap6yOMRGzi4ejSx5ShTMb/TJn7uxKYUrI5F06XBekFWoVdWl2v+OCDyx2gu wsZ/FNy1lohAv7a9cZait9TBxwWKh8cMYUb2LjHyGgfoG9lDe+bmGQcSvnlFDuW/QLhQPIrBb cTaBtD4qej4jjZriUCDl6TpZBbXYInJflVDnKPWdaWnwI3/dceaxCcTB/kBtBuqTheNObT2if lc14FAH2K7K+POgqAiwtgajE52S5fVM+Pv1uKBKd+BvrJl2Ub/qAn3hljvx138+1NOfU51fS2 yo4WGubdWbp+xqUeuyk35RYIC/dm0y4QA5Or2eCW8uKkIZIpOGuiHpWRcFyRwbRjJzgQ/ITw7 GmJTIfAd/GAryx55WS+hWuE1kJtruifg8B8O+vlbjHcu4NnLzeidBgEUlCZMOzd+GaL+CHFfR 37p72RlOpPbXiY0Ass9UxpevB2GCuz9lESqvl4nBtbu6+bQyPZnpt56HWGSg+gVyAuCR7vcLV onyjC3P0xKWve7iN8sNnFVfcTQGiJkFUO4hvZZzDEqj9sQFhoGGytQJSqgU6LlgEHNDRqC40j R86grYwNgeuE0X6sglvxp+Cq15NBcP25HcuLtYJSYrNtkSOV5j/Ajqa/ETihCxDV6vu8ebnu6 feTSX7WRDkkoqY1q3n8vXi0YOJbqtsXhaE8lL/910+7rphzHLKLzW5Zm2Ofnm4y6mbdNuHfGD bokQuXBZyYLZHoIBjo2loNKXpWRmfxm05v3c7W+fPy4E1nJf+qLWKp2aYBE= X-Spam-Status: No, score=-100.0 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2021 09:43:18 -0000 On Aug 30 11:43, Ken Brown wrote: > On 8/30/2021 11:19 AM, Corinna Vinschen wrote: > > On Aug 30 11:00, Ken Brown wrote: > > > On 8/30/2021 9:51 AM, Ken Brown wrote: > > > > On 8/30/2021 8:55 AM, Corinna Vinschen wrote: > > > > > On Aug 30 21:04, Takashi Yano wrote: > > > > > No worries.  The same should apply to the NtCreateFile side of the > > > > > pipe, btw. > > > > > > > > I'll add my thanks.  I should have checked the default flags that are > > > > typically used for other devices when I wrote nt_create.  I'm glad you > > > > caught this. > > > > > > > > So I'll reinstate the use of nt_create and then let Takashi recheck everything. > > > > > > I've done this now. I'm still not sure I've got all the flags right. For > > > unknown reasons, I've used FILE_SHARE_READ | FILE_SHARE_WRITE in the call to > > > NtCreateNamedPipeFile, and no sharing in the call to NtOpenFile. Should I > > > also use FILE_SHARE_READ | FILE_SHARE in NtOpenFile? Is sharing even > > > relevant in this context? > > > > This is only relevant if you want to open the pipe from another context, > > calling CreateNamedPipe/CreateFile. As long as the pipe is only > > duplicated, it shouldn't matter at all. > > OK, then I think I should remove the sharing from NtCreateNamedPipeFile, > since it could confuse someone reading the code. I reverted both "fix flags" patches for the time being. Removing the sharing flags results in NtOpenFile for the write side to fail. Corinna