From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by sourceware.org (Postfix) with ESMTPS id C92733848432 for ; Fri, 3 Sep 2021 15:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C92733848432 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MkpvV-1mphFw1c0V-00mNjy for ; Fri, 03 Sep 2021 17:00:15 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 7A392A80F98; Fri, 3 Sep 2021 17:00:14 +0200 (CEST) Date: Fri, 3 Sep 2021 17:00:14 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <9ba687eb-f4a0-18f8-b10b-76e7e51e123e@cornell.edu> <152bfc0c-2f72-c684-6fc5-aa7c36c136b8@cornell.edu> <20210903190046.663c60fb11c936e344821383@nifty.ne.jp> <20210903191340.c28ae366e79ca14799bacc1f@nifty.ne.jp> <03d54bd7-0bd1-0e46-828e-53bb1389e8d3@cornell.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <03d54bd7-0bd1-0e46-828e-53bb1389e8d3@cornell.edu> X-Provags-ID: V03:K1:yGcpOMLbfe8aLfpwDYpBKY9RRE0DZMQ6i0AQmqCXvtljV1XsaFd oiFTI+VLHTVvgSNrbEj7FW273gRhzW3NL3zf6XtG43aCSeY8QyzS6p+UTO4Sfi23M5xO7kU oIg9GjnxSpMXNdTBw1aJvPd5viWWrb07TT4n4/m/XnBc5GU8b1KUk9ht/+o/bwtyk8how3G NhY1R2PfBYBYTVPZ3iXCg== X-UI-Out-Filterresults: notjunk:1;V03:K0:L/RxsE+bgVk=:6VEAioeVxcjJdJF/AVCUwP vAAMbXWFa9hqoiFPtLRP6Zl18+BGFlk7R+kGiHTVQNNVQ65wkmM+U3/U8oPN5TdFh4Q8VDRAI cr83CpBd/HeF4CpKoWpLP2KoShDOFby5cQ15V7EX2JqcbgveLT9AnED+MsAc6PcQYT5YlzszQ y0AOK18uYJbvVzatH66G9lZYxgdzzZJxigwmWWUOrkjz6jTOivQb/yTesaYt5jjDxLK9Co7O+ C4bsD7gNCy3lPucha5WugI2038ESIiO+tPSUbiPVlcg/SoQBESx/a9US+Bs7PAPVzXOEqP9nF L6l8Rg+nPzVr+SS1gYXaNnAuR6opF9z4c0xmMpQNG4nzrV33eWrfmefPYUctU9izqPTeRFyo6 VQ9DjZWTpeQa0JU0Y01sB2O9sskkq65DyiphxpuwkdN53daO4Cv19uFDAvaEkahVHxmtry5ZN UjNYIjq19Y/Rgc25TOT6Fuah94a187jGJLgIB/+EsEiO0gpPzSRm87evYFD9CoMfqisIoSqPk z4zpAHk04vr96Xvb1hWtnLk/vAMXsjANWDaUZB9IQ2ChpDWfDrWNxL4oqAfBag7iD8fU4s1yw JM+CNhc0jUYLcIZXyDHB3blu29qkQ3t4cihulxoJD1NoHmFpikLgVKjNaX0NKxQcAoZIgfr7i UOw+H/GLHdbA0ksjj4Wbizg3j2REeTj0xuRMFPVTR/iHmsy7aAjXgnBwQqGx+LAW4qbYv5RMU sAusL4csAANcAksKMdJWZNekm1EYPz6cWatc85zaPAmG/6oGauRQocnKWsA= X-Spam-Status: No, score=-100.0 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 15:00:18 -0000 On Sep 3 08:13, Ken Brown wrote: > One tiny thing I noticed: get_obj_handle_count can return 0. So the line > > reader_count = get_obj_handle_count (get_handle ()); > > should be > > reader_count = get_obj_handle_count (get_handle ()) ?: 1; > > Or else get_obj_handle_count should be changed to return 1 instead of 0 if > NtQueryObject fails. We're in the reader with a valid read handle asking for the number of open handles. NtQueryObject can only fail if the handle is invalid. I don't see how this could be the case here. Corinna