From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by sourceware.org (Postfix) with ESMTPS id 20569384B13A for ; Fri, 3 Sep 2021 15:17:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20569384B13A Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M2Nm2-1mOulT360E-003tRA for ; Fri, 03 Sep 2021 17:17:05 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 32BF4A80F97; Fri, 3 Sep 2021 17:17:05 +0200 (CEST) Date: Fri, 3 Sep 2021 17:17:05 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <152bfc0c-2f72-c684-6fc5-aa7c36c136b8@cornell.edu> <20210903190046.663c60fb11c936e344821383@nifty.ne.jp> <20210903191340.c28ae366e79ca14799bacc1f@nifty.ne.jp> <03d54bd7-0bd1-0e46-828e-53bb1389e8d3@cornell.edu> <529cb095-179c-8604-722c-dc336b104569@cornell.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <529cb095-179c-8604-722c-dc336b104569@cornell.edu> X-Provags-ID: V03:K1:P6dyd/9qd3sSNAcyvIbVzedlvNjH4L1RvBzbeccFq/C2ACJj5c+ 7HqDzfoAutmMxRX3+BX4W+8X9+Ey8TaYlT51MnUYV6TPbL/7ctZuhr+XMu/qSywvYYZZmad Un91hFRDUjXzg3INYJwxMUPObLmrO14N7jfswexiy0AEtFVQDULgm+GSkm1/ZJk8nwXwV+U aS2FCglYwykD1nAROde2g== X-UI-Out-Filterresults: notjunk:1;V03:K0:slPp2a4a2XI=:ssViOfM6KCO7OrdCsk2L/d GvQeOL42GPdMrSWqOSIoRtqiLUzU1h4zsV6/Z8WFzveFULEpx1wvrFR8RD7H4st2GwTDcpJdK IjsutK7Ob9POrYrTTxorOvAZsO3+qaZwQx/Kqe+C3//L7T6Cqk4LOcqP0LaT0oqkG8yWSwZps S7926fpzOIQND1Harue6OWkwHpuF0Ift2ZDfJvsqvjMwmpYp4nOjp5PB196ZxWKlFyZbowWFM E7OA13eeSUyXG/5x5kyPkRv/TdFfqVAe87IKqCW1j9SOccoBMN1J83f4eklkaZskxmJFSprJy EidhyH6D/mmPE4vlDztfYLTkzk9OENieoQTMf7NyQ7K0qaKURp+reilR7jbUklKZkU88eooO3 Cvm30nq/6REaZB+wz4CNTEQMx5I7NOJJPh80Ll808CPhICNFtJTJaScng6gCMeG7NjvKZBzY8 W74RZmQglVl0RFAXlUYUcQJlsgyayZnHOLovzmtPM3JzUnEEEK1P9poKSgB/EfygVZb3gfoGQ zFXVRYYzlj5J2Xq6iFddOYGPVIV8Vly+GPflYFiadbtv9Tju4D5gi+UVTkuuot0tZtxD4UpKP VGh2vCKtBDLwSgE8VIXVA6MN9RhlUTnIlpVv8U+nb91OIR0/g33k93qYgmHrj+L+7B24pzvzZ 3UhBVF45rq5o1XsdQXxQjid4isTUkX1bXuFkOn8EuoOJ/goFNlSslv+S2+R/UY6GD9nJ9AYpH 9SBORhszQsDC+64+68dUOSt4o/RtBY/EDXi6beFNfAHOtx7vqbj4t06rSgI= X-Spam-Status: No, score=-99.7 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 15:17:08 -0000 On Sep 3 11:14, Ken Brown wrote: > On 9/3/2021 11:00 AM, Corinna Vinschen wrote: > > On Sep 3 08:13, Ken Brown wrote: > > > One tiny thing I noticed: get_obj_handle_count can return 0. So the line > > > > > > reader_count = get_obj_handle_count (get_handle ()); > > > > > > should be > > > > > > reader_count = get_obj_handle_count (get_handle ()) ?: 1; > > > > > > Or else get_obj_handle_count should be changed to return 1 instead of 0 if > > > NtQueryObject fails. > > > > We're in the reader with a valid read handle asking for the number of > > open handles. NtQueryObject can only fail if the handle is invalid. > > I don't see how this could be the case here. > > I don't either. I was just being paranoid and wanted to avoid the > appearance that we might divide by 0. Good point. Corinna