From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by sourceware.org (Postfix) with ESMTPS id 3FB803857817 for ; Fri, 3 Sep 2021 19:54:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3FB803857817 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MJW5G-1mfxyO2Xmq-00Jqd2 for ; Fri, 03 Sep 2021 21:54:20 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 2ED27A80F97; Fri, 3 Sep 2021 21:54:20 +0200 (CEST) Date: Fri, 3 Sep 2021 21:54:20 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <24138e20-aa97-cfea-bf48-198fc67755ea@cornell.edu> <9ba687eb-f4a0-18f8-b10b-76e7e51e123e@cornell.edu> <152bfc0c-2f72-c684-6fc5-aa7c36c136b8@cornell.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:IFe6RlKoV0QNNSQ0XnyYFCNIioWZ6tS1s4dqTZIXVFrsgbEQbIy d+vEBPCLCM4mctYymJUZqtnvsHCo1P3KIy36an29i17CND7AMDn6UQQ5iv1f5ZIEYjgcEDa 3QBdRas1AJqqR4yJXy++Z9a1kgpp+aLdobNocoH/D8/bLykR9juUnQh1p2CIozpXA3cdQ8M 7j9cYwQTZuN+2oMtE97QA== X-UI-Out-Filterresults: notjunk:1;V03:K0:i74bNwwXZTM=:fMAtfrqxv168ImiAYhHPIJ zz1mEhHdzXVDNDuiIXKRRMekFvMDJXu1ampEtR5fxWqV2a4C6CqLDLCBGxdpBWk38gdsTqEdd 7pYA+c3/u7Buu5SxeQiVCP7RfDatv3GGxjb5CXzRf5Up2Ne+8d5LA0rMnc2QGcj5/Y+c1PVov Bk06vU/FYwxC/pz8wIEz95xthZVkdcwBMGevd6tNy6OHfbCjsFajm++CgCwKu/EU5fHpaYgc2 JTXJ7YBO8K0EjaOUmV6Xbiw93U03xGCE6zA4Sg0AnNLW/voBbJgns2CUusAimDpfOBGClLqzC fOd+ij1FKb4tYodC37tsh6Alesi2hBQMRbv28RFHOHrynas/nfECPALlFUP+83QK3uouuKVfr OY2yN6KGm2GyME0kEYyd24blRf3oAbbgV/oaAflJdl8XnB3leSQoPK+3c9Y+MUWBiJGe3+DdB 2QG9idb4IQ8QZoJCZ3juzCkdjoJ0P5aaLpBg+c2A7t1xrm+itHlwa5iuUcKKnPI5AR0JeTTN1 Y5aKrTAvADWMlPS1TneMcatAaU+/CY1zdmH36ZTkKaG14d6lci9H0FLMIagD2rukV3zy7Cui1 UjydnGYWNNAKkEo8ZjjgFQgR85XV+hpFV1mUSmcRRZQTT76oLPJK2CaoZ93Mb40EUfAN9xxcT vJ9tofutcigRDP1ZYxyJ8pAGZb7X34SzIgdsgDWs0FsbWCJQXGBLQdCpXC1SENjlviuaJqObL AzzzTv66Sbhip3jMn67IUood8M8oUMd8Uc4RNwhRH6xMmuthU0sSfPDMpz4= X-Spam-Status: No, score=-99.7 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 19:54:24 -0000 On Sep 3 15:00, Ken Brown wrote: > On 9/3/2021 5:12 AM, Corinna Vinschen wrote: > > I pushed my stuff to the topic/pipe branch split into hopefully useful > > chunks. Kick me if anything is wrong or not working. > > Some of the bugs you fixed in the pipe code exist in the fifo code also. I > started going through them and fixing them, but then I realized that > fhandler_pipe::raw_write and fhandler_fifo::raw_write are identical. For > ease of maintenance, I'm thinking we should have a single function, say > fhandler_base::raw_write_pipe or fhandler_base::raw_write_pipe_fifo, which > is called by both of them. > > WDYT? Returning to fhandler_base_overlapped? :) No, seriously, the cleanest way is probably to implement a parent class for fhandler_pipe and fhandler_fifo, derived from fhandler_base, and just collect the common code there. For a start it could simply provide raw_write and nothing else. fhandler_pipe_fifo, perhaps? Corinna