From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by sourceware.org (Postfix) with ESMTPS id 2434B38618AD for ; Wed, 8 Sep 2021 11:55:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2434B38618AD Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MpDRp-1mjVru3MAJ-00qjUs for ; Wed, 08 Sep 2021 13:55:41 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 476D5A80D76; Wed, 8 Sep 2021 13:55:41 +0200 (CEST) Date: Wed, 8 Sep 2021 13:55:41 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20210901172339.1039604b7067e0492534a20f@nifty.ne.jp> <24138e20-aa97-cfea-bf48-198fc67755ea@cornell.edu> <9ba687eb-f4a0-18f8-b10b-76e7e51e123e@cornell.edu> <152bfc0c-2f72-c684-6fc5-aa7c36c136b8@cornell.edu> <20210908203234.8cc6215e05108d9ad0507bd3@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210908203234.8cc6215e05108d9ad0507bd3@nifty.ne.jp> X-Provags-ID: V03:K1:103oQi0uZH6Gj1cQiOv3f6z72Fqq8ytYuC8XXxbgFDTpltv0nuc vASEV32+cEqovqUudYaWSvNhTcjL65eRqfqo2pDX8lVEubs6osi7TJ3fM5kdoUy9lMESS1M aCR9gfl22ymuK9n47Ao3N4cxHQPjldv0AQVLihATwelIgmYnQScKcnyXC5xVtDzqQX9AUJk xIwTplF7ZMNVumD1Ecukg== X-UI-Out-Filterresults: notjunk:1;V03:K0:QI5HTzeeEm0=:HnnP6bgo26DfgRF+PJt92w zUkJW5JB4VTw6BDpY5OAaY6fb8d0jpoQXPugRTL2MM3OrTzClLXifStxmdGP+a14y8Zh1VqBU KPXYbXfjKgkExRJbHq4AbFwYD7LM+DYuWpZ/iYTgjA2rkGUOFxBnb2MtKkolp3N21nCZIvj8o 8FnHq5t+EwPa0iXPNpcdGsksrrfCfCFmso1kbs3/NuWxlc4fS0Oew6hZxZJRSWCohe2KjB5ka 2+/hB0BNUyCyM9ZmEih2zVj9IQH6EB/WX3dZCEWRi1u2fpE5VwAwk6euoqRULulEIWo2RyrwU S2t9Ih0Kb4/k6y0TeBAjTlo4Jk+28kDtmOfHWd80fXJag90FjifYOsZ7y1AUHR2J83Rc10A1I UZJwDnZIMUonIKkowccTkSqcXSF1hvrXLOXdCzMrrlqNdiygysjDhRkgMaOQ6bZ+xrY0AFlrO bHPwscWWim9xl1mdzWQ/Zy4Hz7wQ+/iEseMn8kuLbx/lrKt8/2cc8XJpOkBr8olYtW0t0/P6g rP5N+k2aj2NlXbOnY3aVKCNbDBaL5G13O1zT8tu8GhFMvdX6rCUY0mm/mqa2irGv2/ZGOuvei g7aCiqRqSByuFDM+BH6lyX5jbc5aQ7vyj0IWZXcxLpf57qU38cRPZ8D3mmH5iHBlxyOIxVKeE oCA5HkqZAAzLf3L/zJnbnFuOFYbGCY4XvI9V3EnZPdEQxAtWr6n9Trz6Big38EAFRX0kmev22 iy6csuh1vjy4HqA2rK9nrSuO87EGzCMDAIt2RLBdZB3R6PbmWeOKR4ejBHo= X-Spam-Status: No, score=-100.0 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 11:55:44 -0000 On Sep 8 20:32, Takashi Yano wrote: > Hi Corinna, > > On Thu, 2 Sep 2021 21:35:21 +0200 > Corinna Vinschen wrote: > > It's getting too late again. I drop off for tonight, but I attached > > my POC code I have so far. It also adds the snippets from my previous > > patch which fixes stuff Takashi found during testing. > > [...] > > Patch relativ to topic/pipe attached. Would you both mind to take a > > scrutinizing look? > > Sorry for replying to old post. > > As for this patch, read_mtx was introduced. This handle is initialized > only for read pipe. However, this seems to be NULL even without > initialization in write pipe. I wonder why initializing read_mtx in > the constructor is not necessary. > > How do you guarantee that read_mtx is NULL on the write pipe? fhandlers are always calloc'ed on the cygheap, so you don't have to initialize anything to NULL. It doesn't hurt, of course, but it's certainly not required. Corinna