From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by sourceware.org (Postfix) with ESMTPS id CD8283858C2C for ; Thu, 9 Sep 2021 11:41:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD8283858C2C Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N7iGi-1n2BOy0W1q-014gdL for ; Thu, 09 Sep 2021 13:41:30 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 89B8BA80D76; Thu, 9 Sep 2021 13:41:29 +0200 (CEST) Date: Thu, 9 Sep 2021 13:41:29 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20210908131141.bf63a795ce13c8dd8f5c13a8@nifty.ne.jp> <20210908184511.75c901b132c71911aaaa6ad6@nifty.ne.jp> <20210908194529.148fe98ca7593b079d0b1e65@nifty.ne.jp> <20210909122141.ad3fb87c03395a59d961fc3d@nifty.ne.jp> <20210909195547.506b52eaa3bcb36c88006a96@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210909195547.506b52eaa3bcb36c88006a96@nifty.ne.jp> X-Provags-ID: V03:K1:q4z9yA8FlypMupDN+69FXaiqQcw4tai36jsWFFX7oWm+aYR9/vb vs4f4VO27kmSXNRmzrldZWHXe4YySafUhPmroqwWcqhFuvygzwecxc2wJUDSx/jfw/bUngq KP6eJswQmaVoRHVfqXsvTHDVY9QnY7oOTDtYOfXv/U9vplwJzO8uiuPARkzTf26oV1bGeDz kmK96OILMPGJtQfge2z5A== X-UI-Out-Filterresults: notjunk:1;V03:K0:C2gltp6NQLU=:ivrYYqCdP7zkTBEJ0FXVcN A4URrVs7mTzXgLc54yjdG7/obZkAlj0a+FPAx19Fvs8q0Nsv7Sem4OzzOs1uTPFT1THncOjw2 3HOnYUdnSXB/6DVOYUJKYPIe63Ys328RrpR7fwFye3QBDW78uYtS9mGf5JDvirrY7JyUY/a9F tlTBJNLOe4IvuenO/IZ7fc638q1PsqktFvrJdzneBG+8Gcfsfmpu8MKyeFtOn1tydSTx2jLRt fXPjne8+Z5DhdbYGi0Hphk3r2gHUlxy+wf9XHosQrCbj+J97TZohJ043j1o8qTSe5VevgjRDl ExVK3wiodbaaCCF8PbM55Evtpryis2vwktA3fxZ4nnEp+4mZIfvYzckhgBhK2ZgPlRg6f6hQh RIywSvaxE/hjeb2IxKd7wSXa9wXDSpGZ9U8SP8/yjXUAtEuN5RXVcoKg7qEBKvjYK3S1JUbjt 6ro+QM/BgKQDe/7UmxRgYvtWpuE+ZSFzMTsdzgD2EYg73RQz69ZCx19nX8GqmmTK8yUxeQ/R3 4HAYoknJ1Y6F7ZBQKOCuU71gLky5CRxyJS5upOA23u1cJSOeUiW17WSRyxAzmEGc/sqFnO+Yt 1AVHaUkje5wr3XG4bcIk5DYbqu4G2EjFpgqo3ldF0COrt17xoVfrIfzWIXsSmUuEVZAqlZZPt qHKmb7MDTwAFQIJNlW73MI/amVcVz8mhjlecw0ZCcEqW8GMqJyi3aCjmFWYFbFx/8lZpz4q07 ahYEIg537w896CIDUw9gDlNrnkj752of9cvUOyxoe5SCZ0jEBrmCAYp+uuw= X-Spam-Status: No, score=-99.7 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 11:41:33 -0000 On Sep 9 19:55, Takashi Yano wrote: > Hi Corinna, > > On Thu, 9 Sep 2021 11:37:06 +0200 > Corinna Vinschen wrote: > > On Sep 9 12:21, Takashi Yano wrote: > > > On Wed, 8 Sep 2021 12:51:31 +0200 > > > Corinna Vinschen wrote: > > > > > > Just one question. Would you mind to split your patch into two parts, > > > > > > one being just the revert of your "Improve select/poll response." patch > > > > > > and one introducing select_sem? > > > > > > > > > > I split the patch as you advised. > > > > > > > > Pushed. > > > > > > Timing of select_sem notification is fixed by the patch attached. > > > > If I'm not entirely off-track, I think this isn't quite right yet. > > I assume you want to release the semaphore in all cases some bytes > > have been read or written, right? > > Right. > > > If so, this should cover the STATUS_THREAD_CANCELED and > > STATUS_BUFFER_OVERFLOW cases as well. But then again, the > > ReleaseSemaphore calls are a bit spread out over the calls. > > > > I took the liberty to create a followup patch to the attached one. It > > merges all cases potentially reading or writing some bytes into a single > > if branch, so only a single ReleaseSemaphore should be required. I > > dropped STATUS_MORE_ENTRIES because it's not an error, subsumed under > > NT_SUCCESS, and IIUC, never emitted by the underlying code. > > > > I attached the patch to this mail, can you please check it? > > Thanks for the patch. LGTM. I also confirmed that your patch > solves the problem which I wanted to fix. Great, I pushed both patches. Thanks, Corinna