From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by sourceware.org (Postfix) with ESMTPS id BF55D3858436 for ; Tue, 14 Sep 2021 08:47:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BF55D3858436 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MHnZQ-1meu4T2q62-00Exfe for ; Tue, 14 Sep 2021 10:47:31 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id EE925A80D65; Tue, 14 Sep 2021 10:47:30 +0200 (CEST) Date: Tue, 14 Sep 2021 10:47:30 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20210911075734.aaf37697ba7db2ad14d911a3@nifty.ne.jp> <20210911113517.f74fc3ac1971bbf04c7a9bd1@nifty.ne.jp> <695ce1f4-4f7d-f3f3-6dd3-087467d67b28@cornell.edu> <20210912174849.3d38107568065a95aeb19c7c@nifty.ne.jp> <20210912200423.667e40eb1adc52461bbefa20@nifty.ne.jp> <20210914043718.f420491c6723f3dc2e2d9753@nifty.ne.jp> <20210914170716.39d5b48d129c9193b410b2f3@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210914170716.39d5b48d129c9193b410b2f3@nifty.ne.jp> X-Provags-ID: V03:K1:mzwVrWOmGD5cUM9c14TEg490JdXOz9cIjwSmoH4uFskYOytcENb 2OhBKiq1w4O3x6PEn8RPhq8xWS2GcRrtgCbuuhy4JlOxOMpReYVErZCS8NugEnr2pu7uWgM H/fBMYh4e6KE9kkbeA5lnjr5NJxLfPBqBAEG8dwLakteKRRwXY7oVrIUyNmj1Htsh+CyHJb CBs9x5CZJFQcnP+KPKgMQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:nVdpuVf2cIc=:8YYU0u4wwh9BgBgu+lq0LE mLx8wQtKtxGql7EDJfTBMhfAw6ef1oSIIB7WkY+g3aexEY5ZYXP2TuZKFOawzhblAqyDfhtNR B44djGMLg9v3LAZ+8C0osL0kk8wI+HCKwAiFn6vgM4VE+ZDbZpf6lJo2xbA+PQICzB8b3gx7k Joo2Tv8S8k+nEYLC2gJX4agxfLQ/8HURoxt0MV+nTyfLACt6nhq3lcf1WGiNT7BuxoXi+2vqd Gryc+Qij8jk+11v+5apEMmEND0hsY8uEtA3aRbkGByDJR7DyhG75lE0wcmbagzOtnSdeeXrPT 85mo1Siej2e0eF5+e+C0fGD6aramCqefIANa3scUxSftTw/WBVND/9LvXghdWxs8amKreABA1 Cv0FexgJi1H6dg6PU0z3hxXQm6UrHJExhiTIz0uDeNQVxVa8gjQIVXHfTu0ZZK8tRIMvgdEfZ Y3dDJD/JmERM338K8mjOsrdEGHTsnfJ+Ov6KSgNp+v6KW1yjZfqfLLuKySF2ILX7MUz37YvoQ iPkXLN2Vo77aFyqc25FMbwS7JK6yAk6h3y1pZEl73pwXxVEfH4PoF1xr8LcwPxzAmh0jqVRKf UB5WbTIkbVrMKUYlOqbhY2iUfCOy2PhjaP/P6zMQEqDSY6CUBpx2G/tuSPJ6OpogT+ln7CX6X H5MV7nOKYP/ykE4mD0XTdd1jxXfhCnzVKVvfTDJ5fRCiVkGne2/MnvMn6K1qtWCkvWXwq/0NQ 2s9ZTujrSNK38ivpmT2fu9xflEStIZMjDqcCxCO1HB48W1w8hXzoBsM8ZVo= X-Spam-Status: No, score=-99.6 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 08:47:35 -0000 On Sep 14 17:07, Takashi Yano wrote: > On Mon, 13 Sep 2021 22:15:25 +0200 > Corinna Vinschen wrote: > > That should depend on the O_CLOEXEC setting, but identically for > > all handles in the fhandler. > > I found the cause. set_close_on_exec() in fhandler_pipe is missing. > set_no_inheritance() calls for all adjunct handles are necessary. > > > I pushed two more patches to topic/pipe in terms of inheritence, > > maybe that gives a clue? > > I attached two additional patch for this issue. Uh oh! This patch to fhandler_base::dup made me check other fhandlers and, yeah, we have more unconditional inheritence ignoring O_CLOEXEC (fhandler_tape for instance). We should fix that at one point, but that requires your patch to go to master first. Let's just keep that in mind for now. I'll push both patches in a bit. Corinna