From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by sourceware.org (Postfix) with ESMTPS id 4C5683858402 for ; Tue, 14 Sep 2021 14:15:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C5683858402 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MWzbr-1mOGZz3Q0f-00XHhW for ; Tue, 14 Sep 2021 16:15:10 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id E0FD7A80D65; Tue, 14 Sep 2021 16:15:09 +0200 (CEST) Date: Tue, 14 Sep 2021 16:15:09 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20210911113517.f74fc3ac1971bbf04c7a9bd1@nifty.ne.jp> <695ce1f4-4f7d-f3f3-6dd3-087467d67b28@cornell.edu> <20210912174849.3d38107568065a95aeb19c7c@nifty.ne.jp> <20210912200423.667e40eb1adc52461bbefa20@nifty.ne.jp> <20210914043718.f420491c6723f3dc2e2d9753@nifty.ne.jp> <20210914170716.39d5b48d129c9193b410b2f3@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:ZZNPnzTW+kPlOcDYIIPuCxtqpnXuIlbvnOvRthfOJFZvhsTjE0Y KQ7FimxSfNbZGqeTEpv/VvlOqMxAoJgTCSaD3vsB9l1POgA3+/HzxcFNkV1KAC8H8MqkBum Jsp0wDWsxu3PPfPlypK776UDjb2CyjCiDVLPn1FkEKUNKM4og+1prfgfVDBj8u9ICWhOuH1 Xbk82lUx9rQ3h7mTaB7Kg== X-UI-Out-Filterresults: notjunk:1;V03:K0:xVTMV+XEWmw=:4E0zFk/ImDi2rX3eQVfGAD 5nTx6BNI1fDFr43nfwkLS6nNKm59h6uxMgbKCt3/IRlSevnyVyg/ricmeXY1qlUzfAF47Rzx6 UsvcVfj360cPko5WrpgQp3eIt46kwh+j3045LYGxd6VMkcQ6aaJ5873DUpPRGsmM+rscFBILQ dKboZEGI34tzdHZqxKn1313/FxNhjhopQZDYRU/397pmZNw8tJzMjdjM9s2NE5XdT54D2MPOF Agtfs3ToEYaAIKHKSEHBaVUmkalIeoFD1Qq9ty7N3xfP8q5cugULT4fu3Ss6zdN0RwJUC52+Q QwjLL4FwWNf73YoQVOAUZvfdFZyrvqh//aqdOHNHw814IlvcojF3IZYNtefhWwGmNqS0CPN4u Xk0w8ovFS3n5GztOsAegrAl9FUHQo2suhN7d57tR4y/XUNBtijuytLLi6ktV5t+VBF2sCRX+n y/BAFtSnPRus+cEzFsqcbtYxUceX92pb8i6qX0LuaBXNKErm9MTSZRljx1A0aq7NDrOS338VT gshS/tsm4/CaNDWH32tzI+y/cTFrLfRbZTiL+TZKe79C+Jfe2tudsv8SIgoeczSByj9i1mw4Q Sn4pKIhQZQl6aWI0W2M4a7DwdrtOpKGs/ePpgUzDUGu0Hy6+Ho/FCsEiKLJi25/hdSRWd3VFY IY6wfqtjh5CjkpNo06Mn0GWCkZ628ElixbTbzCy13sWsOOUDrGeiaMFoFDqv2hRTVbX+smCcC w7jg9koMSNiooYkzqhdN/MHUvzBxPti4JnrLnQEJZbZteFktTXZjM/S6uGU= X-Spam-Status: No, score=-99.6 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 14:15:13 -0000 On Sep 14 08:38, Ken Brown wrote: > On 9/14/2021 4:47 AM, Corinna Vinschen wrote: > > On Sep 14 17:07, Takashi Yano wrote: > > > On Mon, 13 Sep 2021 22:15:25 +0200 > > > Corinna Vinschen wrote: > > > > That should depend on the O_CLOEXEC setting, but identically for > > > > all handles in the fhandler. > > > > > > I found the cause. set_close_on_exec() in fhandler_pipe is missing. > > > set_no_inheritance() calls for all adjunct handles are necessary. > > > > > > > I pushed two more patches to topic/pipe in terms of inheritence, > > > > maybe that gives a clue? > > > > > > I attached two additional patch for this issue. > > > > Uh oh! This patch to fhandler_base::dup made me check other fhandlers > > and, yeah, we have more unconditional inheritence ignoring O_CLOEXEC > > (fhandler_tape for instance). We should fix that at one point, but that > > requires your patch to go to master first. Let's just keep that in mind > > for now. > > I think the change to fhandler_base::dup was unnecessary (technically), > because dtable::dup_worker takes care of that with > > newfh->set_close_on_exec (!!(flags & O_CLOEXEC)); Right... and that reminds me we have to check all fhandlers for set_close_on_exec being correct, too :} > But the code is certainly more clear after the change, and I agree that it > should be changed in the other fhandlers also. :+1: Corinna