From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by sourceware.org (Postfix) with ESMTPS id A7ED53858C3B for ; Wed, 15 Sep 2021 11:49:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7ED53858C3B Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MFKCV-1mfbZz0Wuf-00Fl1G for ; Wed, 15 Sep 2021 13:49:46 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 936ADA80D6A; Wed, 15 Sep 2021 13:49:45 +0200 (CEST) Date: Wed, 15 Sep 2021 13:49:45 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20210914210507.be6c950c948033704542bc42@nifty.ne.jp> <20210915092100.796985ae33039f3184483450@nifty.ne.jp> <20210915094454.42ef1d085d9bf92a1af8d39a@nifty.ne.jp> <20210915095911.415d174ea38fb2d2ea8e5432@nifty.ne.jp> <20210915194858.845bcd54c0c63246b40703a8@nifty.ne.jp> <5be76f40-cf62-6fdd-46ab-a66e88879089@cornell.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5be76f40-cf62-6fdd-46ab-a66e88879089@cornell.edu> X-Provags-ID: V03:K1:uGauktIp9TAP2gSV6q06PcC0Qat8sYppiBmvgJoNpjoWI/NyAUH PD4KIvwr3cmJqSPty0iGL0erkvtYyMY+GPGf/nYM20d32c84gTJ0zidnQt6ZkeoUo3EXgD4 fOnSK1d1On5hRagDvSpLT5xgfvUDVHbLWDb2X34o362d8vH5iOlDKH3MZZqL/isxXD1PMA8 1RidFxrnvz53HKGnqTNnQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:C1v069OeBVg=:JjHL65v/yVdn2fV+boVt1X dvjaTfd7tOMOIiX267HND4yCxK7FIfJmgxUCKMd2FPQIGCr5dAbMfzVUUWJ0r+WhBakABDlBo /nQWCcUU2zGjn4GTh0j93iAV4n9U2YrW1RXJwi4boKBbD9lPkLQ1KmZIXKxxIPvwCxVFOvj8Z urUuBaON1vWqzxaR8QeukrHtxPl+hV1JXJI3UBM3Mpqq0Fx+8CRF18lz/gzeBKwwqMG0W2TQE o/GorVU2tcHF90T35A7o3TpSOVFJk0sBWmv3JsPTEc2SfJwN6OTrx9mdjyXvpBHa5cc+bRLst 27OGR+2uAgMhoYYVItnmc/jc3OHWlrjHi6SkYYvKAB7iJAXuJd27hGwdOF5yJKFzuOsFTECH3 pJKCEVqsZCMJozOK+Ax9GfmpUnstJsCTKJOiqhJ8YMVvkjK4afZz767SDT3sPY9nqY+PVuCSm pE2XlP20sn4YoFl6dcQo/GRmb9AqhvR0m3HHNARpCNQDRSJUG2VhodGgALsJocPWNv10Un9DI jK4YzbMw3sfKFIGVQnUokmgWbNdXMPHKUYyMU563cwlEgwPUWejx+WfMIzcuJ4BbLHu45+wQ0 T61ZKdwYRNu22EpAFpYdrbHh7sFkyEk7hMQxlLICBdiGpXSr3zqU+Hr64uT8lbw0srLC6hEi1 KOoEyXxkgNUUpUBLOkHYoUQhajDM/l0N+7Vx606+cEo5SwmQ3mhyzKsFpdC7RZFBfgQwQF7LD Loh+/AMSUMjiUZ7HohysNE9fI+v075iEKCFnt/M0aFzXfGDgOW00khCPECE= X-Spam-Status: No, score=-99.6 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 11:49:49 -0000 On Sep 15 07:41, Ken Brown wrote: > On 9/15/2021 7:13 AM, Corinna Vinschen wrote: > > On Sep 15 19:48, Takashi Yano wrote: > > > On Wed, 15 Sep 2021 11:57:44 +0200 > > > Corinna Vinschen wrote: > > > > ...but we're unconditionally using NtQueryInformationFile at the start > > > > of pipe_data_available. If this is the read side of the pipe, isn't > > > > there a chance that another (non-Cygwin) process is performing a blocking > > > > read and this call will hang? > > > > > > I will check that. > > > > Something like that comes to mind: > > [...] > > if (fpli.NamedPipeState & FILE_PIPE_CLOSING_STATE) > > return -1; > > Maybe we want to call NtQueryInformationFile in all cases except FH_PIPER, > keeping in mind that there are callers of pipe_data_available other than > pipes. That way we can still test for FILE_PIPE_CLOSING_STATE at the end in > many cases. Ouch, right. I totally missed this. Corinna