From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-developers@cygwin.com
Subject: Re: malloc crash
Date: Wed, 27 Oct 2021 11:01:26 +0200 [thread overview]
Message-ID: <YXkVZji0jA1D10SK@calimero.vinschen.de> (raw)
In-Reply-To: <20211027094456.07db314033f2fc513604f458@nifty.ne.jp>
On Oct 27 09:44, Takashi Yano wrote:
> On Tue, 26 Oct 2021 18:49:33 +0200
> Corinna Vinschen <corinna-cygwin@cygwin.com> wrote:
> > On Oct 26 12:36, Ken Brown wrote:
> > > On 10/26/2021 12:03 PM, Corinna Vinschen wrote:
> > > > On Oct 26 10:32, Ken Brown wrote:
> > > > > It might take a while to get this right, and the bug has existed ever since
> > > > > I overhauled the fifo code. So I don't think you have to hold up releasing
> > > > > 3.3.0 while I work on this.
> > > >
> > > > Try the below patch instead, per Takashi's testing and subsequent discussion.
> > > > [...]
> > > I agree with Takashi that this fixes the problem. Thanks to both of you!
> > > This saved me a lot of testing and the risk of introducing new bugs.
> >
> > Below's another incarnation of this patch. I wasn't quite happy with
> > the first one. Statically initialized SRWLOCKs seem to be the natural
> > way to solve the problem...
> >
> > Ken, Takashi, can you please test it both, just to get as much testing
> > as possible?
>
> The new patch also works fine for me.
Thanks guys, I pushed it.
Corinna
next prev parent reply other threads:[~2021-10-27 9:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 21:46 Ken Brown
2021-10-25 8:56 ` Takashi Yano
2021-10-25 13:37 ` Ken Brown
2021-10-25 8:59 ` Corinna Vinschen
2021-10-25 12:35 ` Ken Brown
2021-10-25 15:39 ` Corinna Vinschen
2021-10-25 21:29 ` Mark Geisert
2021-10-25 22:02 ` Ken Brown
2021-10-25 23:36 ` Mark Geisert
2021-10-26 0:18 ` Takashi Yano
2021-10-26 0:54 ` Mark Geisert
2021-10-26 8:30 ` Mark Geisert
2021-10-26 8:52 ` Takashi Yano
2021-10-26 8:59 ` Mark Geisert
2021-10-26 9:26 ` Takashi Yano
2021-10-26 9:31 ` Corinna Vinschen
2021-10-26 9:28 ` Corinna Vinschen
2021-10-26 9:27 ` Corinna Vinschen
2021-10-26 9:24 ` Corinna Vinschen
2021-10-26 14:32 ` Ken Brown
2021-10-26 16:03 ` Corinna Vinschen
2021-10-26 16:36 ` Ken Brown
2021-10-26 16:49 ` Corinna Vinschen
2021-10-26 17:10 ` Ken Brown
2021-10-27 0:44 ` Takashi Yano
2021-10-27 9:01 ` Corinna Vinschen [this message]
2021-10-26 16:44 ` Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXkVZji0jA1D10SK@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-developers@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).