From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by sourceware.org (Postfix) with ESMTPS id 15F373858C27 for ; Wed, 27 Oct 2021 09:01:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 15F373858C27 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1M730b-1maQ9Z24XX-008ess for ; Wed, 27 Oct 2021 11:01:26 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 0A1B4A80BC1; Wed, 27 Oct 2021 11:01:26 +0200 (CEST) Date: Wed, 27 Oct 2021 11:01:26 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: malloc crash Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <97873b16-7ec3-02d7-1861-3ec62a79c37e@cornell.edu> <4b322eb0-4941-6b8f-6f46-aa76caf5a66f@cornell.edu> <66ba46c1-afcd-5f31-58ef-06f96209127e@cornell.edu> <20211027094456.07db314033f2fc513604f458@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211027094456.07db314033f2fc513604f458@nifty.ne.jp> X-Provags-ID: V03:K1:GQfAchZDJkvIgFJTIn3X37l4U875UbomR/jBZihf17KJPs1Vp0o 5dcCpEQT8V9XnVJ/lfSS6JpX3VHrb0uZI5gOayqFmuell/b7OlO0MOZc124+OI6Q5elfMj0 rLC+/HGObS3KZdD/n1YINWTZCcXftmXPwjThxU60DXCE/hspqQZbT91yEWbmtbXTEvJxqrO cxQ0lwsv3bFiA4itxOZkw== X-UI-Out-Filterresults: notjunk:1;V03:K0:u4rGUadtKKI=:K+xr9PgSu3QDAQr8wEtWIr i16L/9EbWXNKqiWdb/CGUkbYzCKFLihXOFYbH5ViTPY++/9dcHHpV7m0dXIHgUxcFycHFNI2f H6obfA4tmMpYRgXU9cueVKD1PzTJ0yiaARXF7whb7osozI39FW8vNDlcPYc0f49fWDQpgWce1 k0R9ibeTzJifcSMsV0Z+KHai8qub+eZ3OTt4d8g3G8CF7cXEw/Au84z8PHPRjq69ztLuSLNbV hV/hEjkucTjFHvs8gT/+kXPYrr3dW9Ncp8vopGQGg63w/n5TN913qsD92f4KchiWCwE9w+g9k /aWanRA3evjnJ5CWVsG/U18kF0PRbYDDEjrDjLIo6NJQKQxku/KRxbHGH68hg9vKRanSbrd63 vSvc8cilRPq3ygFyUaxMtOtkC43H72OOLocZT9lld6TVrtppTSAdguF5w/OTvSIZAJKRXpjVt QtGm3HG+lNOZaQ05EbU5knh7jaRDdezEHb+XAQnkN75eTXVWE7mn2TqzEbBd1wNPwYMgxxCbZ GZAqgRFbBeMjGnTRleLj1V6qIJjxm6CW8uYfQ3kP3Lm1rj4h7dx6fMVp/f2FpO8REs0jG0dd6 3iuPSgOV3+1xvU510VCNVwjsBPuwHNenbz7/NmrCETs0ZbLydBBim39qt6m2lfiGgCI4Nfkat xu20yA4G8ICpQLE9BLFBiy952ZOql7ppLXIQ+kXOTeioqRImyCjU+nxTaqVimTZTpFI2zKEcD bZewC8XR4MxRjs4B X-Spam-Status: No, score=-99.6 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 09:01:29 -0000 On Oct 27 09:44, Takashi Yano wrote: > On Tue, 26 Oct 2021 18:49:33 +0200 > Corinna Vinschen wrote: > > On Oct 26 12:36, Ken Brown wrote: > > > On 10/26/2021 12:03 PM, Corinna Vinschen wrote: > > > > On Oct 26 10:32, Ken Brown wrote: > > > > > It might take a while to get this right, and the bug has existed ever since > > > > > I overhauled the fifo code. So I don't think you have to hold up releasing > > > > > 3.3.0 while I work on this. > > > > > > > > Try the below patch instead, per Takashi's testing and subsequent discussion. > > > > [...] > > > I agree with Takashi that this fixes the problem. Thanks to both of you! > > > This saved me a lot of testing and the risk of introducing new bugs. > > > > Below's another incarnation of this patch. I wasn't quite happy with > > the first one. Statically initialized SRWLOCKs seem to be the natural > > way to solve the problem... > > > > Ken, Takashi, can you please test it both, just to get as much testing > > as possible? > > The new patch also works fine for me. Thanks guys, I pushed it. Corinna