From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-developers@cygwin.com
Subject: Re: 3.3.0: Possible regression in cygwin DLL (Win10); fixed in snapshot
Date: Sat, 6 Nov 2021 18:20:03 +0100 [thread overview]
Message-ID: <YYa5QxKpJ5bvdL9B@calimero.vinschen.de> (raw)
In-Reply-To: <20211106231336.e55208f1377b1600cfa3db02@nifty.ne.jp>
On Nov 6 23:13, Takashi Yano wrote:
> On Sat, 6 Nov 2021 13:02:50 +0100
> Corinna Vinschen wrote:
> > On Nov 6 12:42, Corinna Vinschen wrote:
> > > On Nov 6 15:10, Takashi Yano wrote:
> > > > P.S.
> > > > Unfortunately, these solutions do not resolve the issue
> > > > which is another issue with C# program:
> > > > https://cygwin.com/pipermail/cygwin/2021-March/247987.html
> > > > This still needs FILE_SYNCHRONOUS_IO_NONALERT flag.
> > >
> > > If we want to add FILE_SYNCHRONOUS_IO_NONALERT, this would have to be
> > > solved by running NtReadFile/NtWriteFile synchronously in a thread,
> > > started on every invocation of raw_read/raw_write. raw_read/raw_write
> > > would then call cygwait on the thread object. To break on signal or
> > > thread cancallation events, it would have to call CancelSynchronousIo.
> > > That's certainly doable.
> >
> > That would be something for 3.4, though. For 3.3.2, we should just
> > fix the other problem. Ignoring 0 byte packets is probably the most
> > easy way out.
> >
> > With this fixed, I think I should release 3.3.2 soon. We can have as
> > much 3.3 bugfix releases as we want, anyway.
>
> We are not sure at this time if the byte pipe causes some problems.
>
> So, I think it is better to adopt the idea of ignoring 0 byte
> messages for the time being,
Sure enough. Are you going to send the patch to cygwin-patches?
> and take some time to consider
> adopting the byte pipe and enabling FLAG_SYNCHRONOUS_IO_NONALERT.
We probably don't really need byte pipe, using a synchroneous pipe
and threading should already do the trick, no?
Corinna
next prev parent reply other threads:[~2021-11-06 17:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEv6GOB8PXHgHoz7hdJy6Bia2GWEmUDnTd252gTGinz2vuv=hA@mail.gmail.com>
[not found] ` <20211105123950.b118a7f2ba38379764df4c12@nifty.ne.jp>
[not found] ` <CAEv6GOA-y58YrftXgEgFrjqtOTHmfdu2Vrq76Lwn0suZpZ=U9w@mail.gmail.com>
[not found] ` <20211105170542.96ce6dd4ca32880ddfddd660@nifty.ne.jp>
[not found] ` <CAEv6GODiM88Xfhk9R3AcEW6UTYSzACzYe4C0gPoTYm=u9ZTqRQ@mail.gmail.com>
[not found] ` <20211106044116.698b465a5d8ed6ce2cc75c99@nifty.ne.jp>
[not found] ` <2cfa5de7-3b95-9062-4572-f36d304bc916@cornell.edu>
2021-11-06 6:10 ` Takashi Yano
2021-11-06 11:42 ` Corinna Vinschen
2021-11-06 12:02 ` Corinna Vinschen
2021-11-06 14:13 ` Takashi Yano
2021-11-06 17:20 ` Corinna Vinschen [this message]
2021-11-07 3:01 ` Takashi Yano
2021-11-06 16:38 ` Ken Brown
2021-11-06 17:20 ` Corinna Vinschen
2021-11-07 3:46 ` Takashi Yano
2021-11-07 22:20 ` Ken Brown
2021-11-08 8:23 ` Takashi Yano
2021-11-08 9:46 ` Corinna Vinschen
2021-11-10 8:30 ` Takashi Yano
2021-11-10 10:34 ` Corinna Vinschen
2021-11-10 13:30 ` Takashi Yano
2021-11-10 20:35 ` Corinna Vinschen
2021-11-10 21:32 ` Ken Brown
2021-11-11 16:11 ` Ken Brown
2021-11-12 8:38 ` Takashi Yano
2021-11-16 23:46 ` Takashi Yano
2021-11-17 8:10 ` Takashi Yano
2021-11-17 15:12 ` Ken Brown
2021-11-11 9:52 ` Corinna Vinschen
2021-11-11 11:12 ` Takashi Yano
2021-11-11 11:33 ` Corinna Vinschen
2021-11-11 12:02 ` Takashi Yano
2021-11-11 13:20 ` Takashi Yano
2021-11-11 16:07 ` Corinna Vinschen
2021-11-12 8:33 ` Takashi Yano
2021-11-12 10:02 ` Corinna Vinschen
2021-12-12 13:26 ` Takashi Yano
2021-12-12 13:36 ` Ken Brown
2021-12-13 11:15 ` Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYa5QxKpJ5bvdL9B@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-developers@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).