From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by sourceware.org (Postfix) with ESMTPS id 80E7A3858401 for ; Sat, 6 Nov 2021 17:20:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 80E7A3858401 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N6szR-1mfi5z3Xpv-018Hkv for ; Sat, 06 Nov 2021 18:20:04 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id D2DCFA80D53; Sat, 6 Nov 2021 18:20:03 +0100 (CET) Date: Sat, 6 Nov 2021 18:20:03 +0100 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: 3.3.0: Possible regression in cygwin DLL (Win10); fixed in snapshot Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20211105123950.b118a7f2ba38379764df4c12@nifty.ne.jp> <20211105170542.96ce6dd4ca32880ddfddd660@nifty.ne.jp> <20211106044116.698b465a5d8ed6ce2cc75c99@nifty.ne.jp> <2cfa5de7-3b95-9062-4572-f36d304bc916@cornell.edu> <20211106151047.4d8f626bd6ebe9e4d8017f3b@nifty.ne.jp> <20211106231336.e55208f1377b1600cfa3db02@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211106231336.e55208f1377b1600cfa3db02@nifty.ne.jp> X-Provags-ID: V03:K1:5zr8OTPVBbXW97E0TamK40a2Im4d1WPqPsEbBCYH4jbXqUufiH4 gVbNhdOyJxV4qOI/b8+Py60QQTWQsIWLC/5XyulG1eqEJg1QWqP9r0n2QNIAJVTNYQcLpWq d/E9QPnaQTWh2GkgVFGwigSPfNfUJ7mZHUA8QQF/l760uirQcQ9bzL+jFVza1nx7swu3J5E sdNJ9AIFw8MnqVuDum51A== X-UI-Out-Filterresults: notjunk:1;V03:K0:mbhKk1bTks0=:29A+NgM3+/xZgIW1pmY3+a wlHliInLZy/FxzDgPIaLYvUhz4Im3nnnRBY+7E/hnJ5Bn6DAPxOd6Yd+F3/Oz5ywTO6u/5OS8 U2cl13keKS3opoznMHqZRqCbbUuvXcYdNvCZgtKjl4T4sC70QUJKQJqfnL12Ej/9cJ29iVrdg Q6uT1RBpS+qyFI573DfGcTy43Wz8hZzIMF/igAQROuxSR1PjFtuMaA0Y7Hwz6xurLsznP1geO i0HOYpc3BN/gjEW3X2Ll/OFRN1+bB6dUjcMYgyE8xNgzV7aDbdQA0LOOlrNvx64yZtdDN4rtK b/YXHqtsRwNixSD3odgMRqPboQcayiOBzhE+v0b4hpu7LNJPZnRQvzRkAse+xFGrLjgL6fS3I B9KTNL8/e548vxuk0ienlzKMZjk4/J4KtIBAUww27Mf7ma4bAGdgOEUBBFGfcsNHozZoWxXJI qYLwscd5iBcNhKzT73dSfcNzPbi0AuQ4wRp6Y9sMjKSm346akjq5u0xgs2y0uF++ru2OzT921 NAW5uOVs2hSyXmh8ZY2eKDyrUGkUi2pe6bummmtnEyNrBAdQdabWcWiavGS8y0LiG18LEelh2 jLXB3poPWZ6p6bnEacAQY81/G/YcpOPe50uyEb/cX2kUya1rBUz1xzsg52PHezbZJ6N3Oc6uu cUA7WRbqvEzVUU5t3GJxtj4+Z+3PpaZac0zDezyGj6em42qsT7W8NAOVx5brDteJmGNBHhtCj Ep9rgTfCFZ1qazWS X-Spam-Status: No, score=-99.3 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Nov 2021 17:20:08 -0000 On Nov 6 23:13, Takashi Yano wrote: > On Sat, 6 Nov 2021 13:02:50 +0100 > Corinna Vinschen wrote: > > On Nov 6 12:42, Corinna Vinschen wrote: > > > On Nov 6 15:10, Takashi Yano wrote: > > > > P.S. > > > > Unfortunately, these solutions do not resolve the issue > > > > which is another issue with C# program: > > > > https://cygwin.com/pipermail/cygwin/2021-March/247987.html > > > > This still needs FILE_SYNCHRONOUS_IO_NONALERT flag. > > > > > > If we want to add FILE_SYNCHRONOUS_IO_NONALERT, this would have to be > > > solved by running NtReadFile/NtWriteFile synchronously in a thread, > > > started on every invocation of raw_read/raw_write. raw_read/raw_write > > > would then call cygwait on the thread object. To break on signal or > > > thread cancallation events, it would have to call CancelSynchronousIo. > > > That's certainly doable. > > > > That would be something for 3.4, though. For 3.3.2, we should just > > fix the other problem. Ignoring 0 byte packets is probably the most > > easy way out. > > > > With this fixed, I think I should release 3.3.2 soon. We can have as > > much 3.3 bugfix releases as we want, anyway. > > We are not sure at this time if the byte pipe causes some problems. > > So, I think it is better to adopt the idea of ignoring 0 byte > messages for the time being, Sure enough. Are you going to send the patch to cygwin-patches? > and take some time to consider > adopting the byte pipe and enabling FLAG_SYNCHRONOUS_IO_NONALERT. We probably don't really need byte pipe, using a synchroneous pipe and threading should already do the trick, no? Corinna