From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.131]) by sourceware.org (Postfix) with ESMTPS id E37EE3858401 for ; Mon, 8 Nov 2021 09:46:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E37EE3858401 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MaIvV-1nG4rb0FoT-00WEun for ; Mon, 08 Nov 2021 10:46:54 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id 64739A80D53; Mon, 8 Nov 2021 10:46:53 +0100 (CET) Date: Mon, 8 Nov 2021 10:46:53 +0100 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: 3.3.0: Possible regression in cygwin DLL (Win10); fixed in snapshot Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20211105170542.96ce6dd4ca32880ddfddd660@nifty.ne.jp> <20211106044116.698b465a5d8ed6ce2cc75c99@nifty.ne.jp> <2cfa5de7-3b95-9062-4572-f36d304bc916@cornell.edu> <20211106151047.4d8f626bd6ebe9e4d8017f3b@nifty.ne.jp> <5819b4c3-ea10-8292-2449-23d79e6bc896@cornell.edu> <20211107124606.f68b27d7e5600b203e37fc7a@nifty.ne.jp> <3ba531da-6691-1fba-7892-4e52273d92d8@cornell.edu> <20211108172314.fa447a10fb8b2671f8f3c7ad@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211108172314.fa447a10fb8b2671f8f3c7ad@nifty.ne.jp> X-Provags-ID: V03:K1:DXJ+tc+dqEilDk3p3KWF5xreIKcB6u5fOzci5nn31oSOIrr97BF jEksE3AVYEVU4ZyhEwbTHHjxB5bBIbPsQAYnQLUHlETvcCFEA4Z5lNAsu2jf5BeLvYF+n6e SPflZLBgCkMN1NMevNkfIQn5XwXZB/wW2+DgPYKwanUBtO+c/sfVqNfUvl/Ipy0iutTPNN3 nHRIbSqa0hI+6mg1kBdlQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ksBAAdkT9p4=:pyHvlN6M4bWsFqxXWGXn9d AT+9ThPSRLmmvqU680U3YQ9+d2uN3/yGx06Xksun3kFLQjvonbR4vbQ40WqynkwYarQ4MuGoE Iw/L6ApBZhBkd97Mkwsm3SHVwmBngCYY3KyDH7LAhX6JB6FMF7qIlL1D0aqOeGxU0AaLwKCUX UOWrkVHwkyR1kU4tlGLbOcM6m/p+tbRKKfGCkMHf7fkp8XQS18ze9zVrlEbDaJpw+FO01aWo6 3+ORYWhQSK1qz7MqLf/dtv1sZONTTA1miFPQqOlyWUYXZaRnkBmySIw9bkuexltiSZuYQ9Qca /Uwj5WBquKSln/rMcd4RtM8f3m1yvZ81c8ylvlKDOVhXB70iDnc2o2OR2fz4bjGpEMN8yrJi4 R69g8eUfuEjPQwKoJejfJ4nCqNoWzEvQ8BztjAZU7id22eipz9veDLdl4bOUztr14xDrFqCRE zQfR8M4UEHJrBu5wrSOwJeG5ai9mRFJrxSRocRS1o0gnjoc5r0FZb/N56WSU6LrgP8y4plVBB oSSWF2j8QgyrSkWa4Tzgs8dIy0f/0WQ1p82W4j8qmIF7iSU0dpg1I14+FyEGpb1q/K7esDhcW z8/sg+gxDSFNkRoLBWA4aAqnTxril6O4wKGo705zrL88dhFL+8fW8fInxwmcok8fvmYYxN+Gz 3NlcYDwvDbX1xvotIJzwPyyt9IrRHVCMz+q5d2y6K0KCO7T1SuIbsR4wKAD4347gPvpmkvOq2 wTS5yrJ7d0rvGb7X X-Spam-Status: No, score=-99.5 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 09:46:58 -0000 On Nov 8 17:23, Takashi Yano wrote: > On Sun, 7 Nov 2021 17:20:46 -0500 > Ken Brown wrote: > > In the meantime I found the commit that changed the default from byte mode to > > message mode: > > > > commit 31d2bedc585420092eb53895c5f5646651f13215 > > Author: Christopher Faylor > > Date: Sun Oct 23 19:01:47 2011 +0000 > > > > * fhandler_tty.cc (fhandler_pty_slave::read): Use consistent way for testing > > ReadFile return. > > * pipe.cc (fhandler_pipe::create_selectable): Open the write side of the pipe > > in message-mode to force writing as "chunks". Explain why. > > > > [...] > > I also found discussion on the mailing list on the same day as this commit in > > which cgf referred to fixing a bug (that *I* reported, coincidentally): > > > > https://cygwin.com/pipermail/cygwin/2011-October/197953.html > > > > I'll try to test more thoroughly tomorrow, but a quick test seems to show that > > the STC I submitted in connection with that bug report now succeeds even with > > CYGWIN=pipe_byte. > > The STC attached to that post is checking pty behaviour. Currently, > the named pipe for pty is always configured as message type regardless > of CYGWIN=pipe_byte. Ok, I guess we proceed with the patch Takashi sent to -patches for 3.3.2. For the master branch, if you like, go ahead and switch to byte mode and sync IO. Or we can do that on the topic/pipe branch and merge into master at one point, that worked nicely the last time, too. Corinna