From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) by sourceware.org (Postfix) with ESMTPS id E6B34385781A for ; Tue, 16 Nov 2021 09:28:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E6B34385781A Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N33AR-1mhAVV3mwv-013Q1I for ; Tue, 16 Nov 2021 10:28:28 +0100 Received: by calimero.vinschen.de (Postfix, from userid 500) id 314A6A80D6A; Tue, 16 Nov 2021 10:28:28 +0100 (CET) Date: Tue, 16 Nov 2021 10:28:28 +0100 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: cygwin 3.3.x: another problem that may be related to pipes Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: <20211115171811.844dce9cce2b4d13262d64f2@nifty.ne.jp> <20211115235021.0f0f64b1b0e2a7bd6d16be80@nifty.ne.jp> <9a7bdf86-0721-870f-b7ea-00d958967c98@cornell.edu> <20211116015239.57d5f981ffdb3196039258da@nifty.ne.jp> <3bf5793a-d9fe-6ca8-9812-d50fff3cffe9@cornell.edu> <20211116083544.88b6674b42deff69ba39db10@nifty.ne.jp> <7d27160f-9084-22f5-630e-34edb0cac5c6@cornell.edu> <20211116122841.affbe62105961125622113ef@nifty.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211116122841.affbe62105961125622113ef@nifty.ne.jp> X-Provags-ID: V03:K1:sWbv2E/nW9+wMT1GFpcrCSrRpYLsiPLLwp6sBqHSPVEncPEtCKe 9rCma9gL0YhnbItB3Jd3FjKIRZoFZDnvdyZtuOfy1dGptSPbN7LB2bQ1O25eHYYulu++Vut JET4Zvebj74pWn65Lphnl6is6rHhiBBEyTyqTqfVKqjBBmz1nmgqzmHPwcmOTk3GTKw8HNL L1WUFmZ7QE5naQkS5+w/Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:YIJMwJM44U8=:IiErKJ/xrYj4twCyKJwajV dQ8KOqNigfpPc8W18hbEZz+oE0yH+wsnLXhKpJw+3vEq7MnXRfec5GmpRMyVhnd7EyYZTP5dp CSoAMfT/UCACaW927sM/16upLsAqRn777cETkklpfSsp4MOxy6OrGJ1sE43zecvsGuYewumwu smoDxHQVRDsxhsnuIbo0SbvVSjfy0res2n6iUHynFVimAjDi4mNhT+wm9yp8OXSZ/2KKZTGYg RS8wf0seyYRtSK6GCNuIKvl0LhOa3tE9llCCfNksUD7JEkYN6oAaRDIt6bIRiUZCNC1IFTVhb 1xxHWQ6+W1t3PvJNt9jwM0CJHEFfcPfCtXtPJ2MawODQj27iHofxw9J+f094MpHNm1SjuewRa 70OrGqaDIA4jOZz5VR3wM5RYqaR/rPBeOWV6RK0k8Xx6AeYYV1m1GMORKcHPDymVG2rrBE0il c508MCRHD9eXcI7bYorQeXKn0STCpa8Pekv6qTgXGfkpS3FgNE3/TDunKGYynWT2GcmzXg3Jb ATgxr/jAcJOWQA0IFyEKR0Z2kYS0GWt/96Jdg54n3rFChnf3DsXdPyvSPqCK59gcBALojMFEr Yl4/aXtlL3uEtSQ7+jhIRKO1zvDHo2R+Y0HYMITyL0y6kHVJ1bPpd0TjfUEBKxv/FFCkmCB9R JwqtHxFGV2eSZ1hd4fuAkfVR/+nerbXwjqX2NfWQ4hqClm0P/3eQ6/Mtu/sTegiPTXnTfyG+L HnXHeQzon4vfH2Dj X-Spam-Status: No, score=-99.3 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 09:28:32 -0000 On Nov 16 12:28, Takashi Yano wrote: > On Mon, 15 Nov 2021 18:49:34 -0500 > Ken Brown wrote: > > On 11/15/2021 6:35 PM, Takashi Yano wrote: > > > On Mon, 15 Nov 2021 13:47:44 -0500 > > > Ken Brown wrote: > > >> On 11/15/2021 11:52 AM, Takashi Yano wrote: > > >>> So, currently we have three options. > > >>> > > >>> 1) Call CancelIo() immediately after STATUS_PENDING like my patch. > > >>> 2) Wait for pipe handle after STATUS_PENDING for nonblocking mode > > >>> like Ken's patch. > > >>> 3) Create evt event even for nonblocking mode as Corinna mentioned. > > >>> > > >>> Which is the best solution, do you think? > > >> > > >> I'm completely unbiased, of course, but I like option 2. > > > > > > OK. Shall I make a patch? Or would you like to do that? > > > > If you don't mind doing it, I'd appreciate it. I have a lot of Real Life things > > going on at the moment and might not get to it for a couple days. > > OK. I submitted the patch. > > > BTW, I think we have to do the same thing for fhandler_fifo::raw_read, but you > > can leave that for me. > > > > > What should we do for master branch? I think topic/pipe > > > is still under test. So, should we apply the same patch > > > to master as well as cygwin-3_3-branch? > > > > Yes, I think so. Then we can rebase topic/pipe onto master. > > How can I rebase topic/pipe to master? > Are the following steps right manner? > > git switch topic/pipe > git rebase master I always use --interactive here, but... > [edit fhandler_pipe.cc to resolve conflict.] > git add winsup/cygwin/fhandler_pipe.cc > git rebase --continue ...otherwise looks right. Corinna