public inbox for cygwin-developers@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-developers@cygwin.com
Subject: Re: Questions about syscalls.cc
Date: Thu, 4 Aug 2022 17:32:24 +0200	[thread overview]
Message-ID: <YuvmiGChk3soKEaq@calimero.vinschen.de> (raw)
In-Reply-To: <ee8773e6-6d94-abf4-0b69-741d3611f1e4@cornell.edu>

On Aug  4 10:08, Ken Brown wrote:
> 1. Now that we're no longer building newlib's stdio64, am I right that we no
> longer need to export aliases for _open64, _lseek64, _fstat64_r, and
> _stat64_r?

Yes, thanks, I pushed a patch.

> 2. Do we need all those defines at the beginning of syscalls.cc?  I *think*
> I understand the reason for the ones beginning with underscore: We don't
> want newlib's prototypes for these functions because we're exporting aliases
> rather than defining functions.  Right?  But what about fstat, lstat, pread,
> and pwrite?  And why is stat different?

I'm not sure why stat is different and I'm actually rather fuzzy
as to why these masking macros were required at all.  Along the
same lines I'm not sure they are needed anymore at all.  Let me
check...


Corinna

  reply	other threads:[~2022-08-04 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 14:08 Ken Brown
2022-08-04 15:32 ` Corinna Vinschen [this message]
2022-08-04 18:34   ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuvmiGChk3soKEaq@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-developers@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).