From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) by sourceware.org (Postfix) with ESMTPS id E3F263858407 for ; Thu, 4 Aug 2022 15:32:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3F263858407 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MhDAi-1no9db1jvO-00eMRU for ; Thu, 04 Aug 2022 17:32:25 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 61BDEA8096F; Thu, 4 Aug 2022 17:32:24 +0200 (CEST) Date: Thu, 4 Aug 2022 17:32:24 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: Questions about syscalls.cc Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:9gfpvoakaCPtZJ0wn4pS+mRwtlK06oaSBRplv6lhKLSViwo/TM2 OU3qO6rAJUsxZS6p281zS5n+zInzCQChWNWk7LCOlxTAwhTHr7qUNF8gIk0R1jeI0UZjVxL 5V9tleMVzOJijNB3M58xVyadAvVkfoag1GgtlsAr37ZDr+qX7jP9qcPEcaq+kZR0eItiT03 48KkYXxFWAEfgm7FnpCBg== X-UI-Out-Filterresults: notjunk:1;V03:K0:IQ8ZDEx6hwU=:XRkDgcaM6G9BTpA3e4vDri AMDJWs4DP8vflsnx9Petbi2UCzFEEvZsS3/G2QZsL7Q5EAYpoK9oNWfaTeMBNOWU8o0LLxRuX afiRqhKRpXeDnK/cmfqHArIiu+Y0cRpS2R40hwGnvjn+iRKR67CtRxpEy8bg3ZiSvUgd3it+P iVdeG1iNOGlio/JkpcHKWNZ21Vw7ee8mBO753NHxcZZaqedS+jEk149bGcfvPMddlz41K41I1 Oz5nGQIkkPuJjtLI/z14neKpXEpkiMnzx9W6crV9oIF5nyaBinamEIKkC1u/gnrz1QiVF2RU+ PI9zB+aqSpD7bsN7p1vYKkXLTNLmZ2UMRbIcOFwRTl3V4OB2hMhezfmk0pWOcus3g8Ddqg77P Ih2Gj7C6iK4DOHiMdj9sAQ98fIV9KKo1K8KcYgrUBQ6R5OjEUbIO5D1feYyk1e0ceVjA+bohO 26zxuPPaB8A52uwe/mF0QSvJoYbehhPUNGNf0Aa46E85FP4F/t7n4/d/0v0pX+lnZ/jXJ3JRz 3JcykECITDg9teynAzWXogJowmL5tUcjrQscNFQdWN26Alny9Dx1uDCCb2GgFOJkgTtUZUPeG mj0yeQ+mPiOYFaxL/iPAyhiolFDmdIq6vlPLRpFFjdqRkMy9bLVKzkLOyayvw+WGRL0xpUI4v v9y+HS6Pxmfb0+bsWjRWNECkKjO9uoqm6MH8xRX9NPH5FTLq50uNvcAFh7U90CZVR+qFrpBky Slu9JIiBa3gkA2f2gzVQizbWpEbKAZ5ckhFGOeNClS1MF1/5rQrUVGJ/UEw= X-Spam-Status: No, score=-95.7 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_FAIL, SPF_HELO_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2022 15:32:28 -0000 On Aug 4 10:08, Ken Brown wrote: > 1. Now that we're no longer building newlib's stdio64, am I right that we no > longer need to export aliases for _open64, _lseek64, _fstat64_r, and > _stat64_r? Yes, thanks, I pushed a patch. > 2. Do we need all those defines at the beginning of syscalls.cc? I *think* > I understand the reason for the ones beginning with underscore: We don't > want newlib's prototypes for these functions because we're exporting aliases > rather than defining functions. Right? But what about fstat, lstat, pread, > and pwrite? And why is stat different? I'm not sure why stat is different and I'm actually rather fuzzy as to why these masking macros were required at all. Along the same lines I'm not sure they are needed anymore at all. Let me check... Corinna