From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) by sourceware.org (Postfix) with ESMTPS id EBBAC3858407 for ; Thu, 4 Aug 2022 18:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EBBAC3858407 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=cygwin.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cygwin.com Received: from calimero.vinschen.de ([24.134.7.25]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N8XLj-1nOyMz2QZV-014RxB for ; Thu, 04 Aug 2022 20:34:40 +0200 Received: by calimero.vinschen.de (Postfix, from userid 500) id 1E790A8096F; Thu, 4 Aug 2022 20:34:40 +0200 (CEST) Date: Thu, 4 Aug 2022 20:34:40 +0200 From: Corinna Vinschen To: cygwin-developers@cygwin.com Subject: Re: Questions about syscalls.cc Message-ID: Reply-To: cygwin-developers@cygwin.com Mail-Followup-To: cygwin-developers@cygwin.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Provags-ID: V03:K1:HxE6DihhmD8tqbgz/Q2fcuQzZATOiifsh2DCEB4bo9A4kNcWZjy XNDiF68uV0StUibge0oBakdrp+NRzpZ3yKlT2qsOw/6TTiOuvDJAaJOauYlNWAMIuhFuT5y Stq2XgCT+cCJzJGMoVAkOmNbrFojw8xe1hNz0g9DS86LHL4n5YZVssnVYXgkU5OcS5WIZhZ tEVtnV1DOIXMpKj/pNUrQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:DwyW4oMERks=:PqtKimRw9WzvKAQc+6NGXM JIcLGHkTCUq2QW40QvBu2JcIRN4y/BXcjbX4RboVnN5qhPwf5bhNWAbv4pt7wxZT3rTYg4eX0 MZGcH3gEfp1jpcwAC/QhRfLvR4nqT1q4darL5ak+HIFrOK7yGgH+RRskJ5zKOWmqGsCoHscyn hjMRP3wrChH8JWXGKo3Xyf40Ge8CSG2xymo9TLyeTTpcZeFQlxI+QqTrfCgyFBkd8ijsVPYLq TINnbtoMxB2IBICsiKs7+sw1WZdteCuA7n/T5Srynq0MetY4Bvz4Gg+V4NM3hp5yKbRgkiw/L E8RJ9/g9feSgsu/diJfEghKpP/RKeAjYNDSCYhxK7vbBiPibniwOUGRmKJqSLGJX9faeejuM/ H3JRG0Qp2GObmF5S/YTbNF8Fqb6OMoU14B6w8FVwxXVBvDsp1V4PBBTWXAw5uZj+iafqblEBc Ffji7mwmUaSvOqhAt+1iWhhuGZwGDn4YN0RPdds/5IjcqGzgzDWx2oqWZFnWd9f9Bek1g+QCW dLO8cDue86pfO6rsO1TKxwCUupyzGTnIQ8QhflY3gNbBv/NT2De91LUi3Qyj0fsm4VQN6JJZc oSoF13XkOl8EEROp9M4gWiXG5rJHbv68+UzqAn2TeXoZ17ABxNZle16t4ZaHKUdgSDQguJc0B f4c4GmYTyAI0g2VM88+egYW9FBezxtrs7bJ2N64O7KQlQ79+PaKK2ObbkAmy5KNBvLoJSXM6R RKeAA4nJW7bW/lgB7xdb5AtrSpWswHyHA9uybaErrIjj6mmGf+c3/1klmcM= X-Spam-Status: No, score=-95.7 required=5.0 tests=BAYES_00, GOOD_FROM_CORINNA_CYGWIN, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_FAIL, SPF_HELO_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2022 18:34:45 -0000 On Aug 4 17:32, Corinna Vinschen wrote: > On Aug 4 10:08, Ken Brown wrote: > > 1. Now that we're no longer building newlib's stdio64, am I right that we no > > longer need to export aliases for _open64, _lseek64, _fstat64_r, and > > _stat64_r? > > Yes, thanks, I pushed a patch. > > > 2. Do we need all those defines at the beginning of syscalls.cc? I *think* > > I understand the reason for the ones beginning with underscore: We don't > > want newlib's prototypes for these functions because we're exporting aliases > > rather than defining functions. Right? But what about fstat, lstat, pread, > > and pwrite? And why is stat different? > > I'm not sure why stat is different and I'm actually rather fuzzy > as to why these masking macros were required at all. Along the > same lines I'm not sure they are needed anymore at all. Let me > check... I dropped them all. They don't serve a purpose anymore. Thanks for pointing this out. Corinna