From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2126.outbound.protection.outlook.com [40.107.220.126]) by sourceware.org (Postfix) with ESMTPS id 7AB523858402 for ; Tue, 14 Sep 2021 12:38:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7AB523858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cornell.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cornell.edu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XhoqrHqGaajsdJ7M1jCTEYlYV/qEvUcrybr4eLtoUx4+x6WG1wYOG0pxnKDoQm8DcTYH7jkFte4IYqFhfQh5qHfVIxYN4axOiDAiX4lxSCR6yDQy4o9YYS9RHH+w54DsBrF+9nB+TKpTBEFclo/P9BrPdSLyfcolVT+6pp7W3GYWXHqITjbVzbh/1svAk7gtGfdbMr3AI5pSIEQdpuc3NPKxWhP/8BkljYCK80jw8TkGTo4YOK3NxerWyw/jyhg85OIZZ5OKp8ipC50Fm6ugaesRv31b9UAwNlyEVvNAlQIIssVSaDf158ZBfUA7DR/b/RlOcfcjq4JrJLon+lMHuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ld5MidNyVI6tiZoMxl7U57LizytCt3lyGfXm7MNwh7c=; b=mlacTWaMa/XgvPmHolVIVcyr2ZE0Xf2vYQvrnidwNdej3ca005q2ujs9TmvaVNH6FJNPyRYviJ9rm5lQ9M38VJJeHryTTu6pbr79IMbkFZ1W/HRRqU+igS7ZF7tNHOi7GnGhoFRpvjxogoCa27cf0K3FMp/5EdNC9xAQ/LeaJH33hq0lbLX9wtfeEFCpOv2+pulNLEle4gupTw6U5Dk06moSxuaHMPWlfl4XJoVPFbXswPzYNNzxuGf4s2wflQ0uXObp5TKhJkUdWgl0lXnSQ3D7x8W/R8D3ew7Sd7A1uCRuF2+v4GkIOD508AZcKSVYpslLqkbJD0ayaNQzVXkhJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ld5MidNyVI6tiZoMxl7U57LizytCt3lyGfXm7MNwh7c=; b=ByBamoGugkqj8v7gNE+l4xg9iFAgZ7K9oogPBXE6Sxbuz/Rz5019I7WFodbrsUUKM4YWF5jH/KcdXjRu6xmOXMt4bogSCw6guKxAc1NyuYvdq7y/K381EZpawzOYmEymWvRltDSEKtlgRS5IK9Y/OPghVAGRH/NHa1+TvOvSiTg= Authentication-Results: cygwin.com; dkim=none (message not signed) header.d=none;cygwin.com; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN6PR04MB3731.namprd04.prod.outlook.com (2603:10b6:404:d5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Tue, 14 Sep 2021 12:38:11 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::5113:e84a:b38a:7a66]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::5113:e84a:b38a:7a66%6]) with mapi id 15.20.4500.019; Tue, 14 Sep 2021 12:38:11 +0000 Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? To: cygwin-developers@cygwin.com References: <20210911075734.aaf37697ba7db2ad14d911a3@nifty.ne.jp> <20210911113517.f74fc3ac1971bbf04c7a9bd1@nifty.ne.jp> <695ce1f4-4f7d-f3f3-6dd3-087467d67b28@cornell.edu> <20210912174849.3d38107568065a95aeb19c7c@nifty.ne.jp> <20210912200423.667e40eb1adc52461bbefa20@nifty.ne.jp> <20210914043718.f420491c6723f3dc2e2d9753@nifty.ne.jp> <20210914170716.39d5b48d129c9193b410b2f3@nifty.ne.jp> From: Ken Brown Message-ID: Date: Tue, 14 Sep 2021 08:38:10 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR03CA0427.namprd03.prod.outlook.com (2603:10b6:610:10e::30) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 Received: from [IPv6:2603:7081:7e3f:3419:b5d4:1b9b:a270:95c1] (2603:7081:7e3f:3419:b5d4:1b9b:a270:95c1) by CH0PR03CA0427.namprd03.prod.outlook.com (2603:10b6:610:10e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Tue, 14 Sep 2021 12:38:10 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: afd94cfa-0a9b-4b89-f822-08d9777c8363 X-MS-TrafficTypeDiagnostic: BN6PR04MB3731: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yJwLKFrce3FG4T57rU2OEgc7roJDFdBx6vEaymkI2h7H/czk1oO6BtOjxPST9IA2jEyoZMFIb1ArJeuAEW5cvXRoi6L7uWhdgaSC69BuZATp6ehC3+EupfxuEZubzCmjtWtSOc0wYceUIyGurle2rFvdbfivewM0MBqKM2JsjVg2zmemYYzzckumJFFiO3AAHZ27OAc1bxeXHf1+yF4OM3lJIB9+0Bgdh1GNLoCXnd+Yk3e0q5cScVPL7nXuFP/5NF/CDqSzt8M7LcV4teiLOw1HNjvE5Pxn6/9bUJRlEWipClZRRvDEwOBIeQluTtDsEpXNfQxFfmZlEop8l2fKRR6rOv1pFLCDFNwkllCndW3dC6VNbQAhXhAsnylHIoAulWu4jMFD6z/Q1NNR1pKgBo/+iBZNqw5RJGtXmoRhsIfVt/76iFfcCUJWCucxKP3bTpojh4ckvAzKIdh4pEJWJ2SQv829Ug7313Qog9GP0s4IPzMMXMVxh2TcNABSHJKW++scHmh/ssiXCWIYQzeVA7RpH8KE7QVxxCwMJQ7AM9h2foBIPwkgvLx7BHT8Y09T/LiEC66yadkFT5c6gvdgEst+iRqFzKb09B8O6+J0lW/eMvBZ+ilEnLs4fptJB8TVwyRU0SYMwZZi9Dv2dpmFe8+Rug2dqiRh8ZB7SX7F8t8K2eQG83PISeQVlHJg2fm4Any1U9ofIrcqBgFiwUrFui8p6GPXbKiJrFSt7STxFmo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(346002)(396003)(136003)(39860400002)(66946007)(6916009)(66556008)(31686004)(75432002)(36756003)(8936002)(66476007)(38100700002)(31696002)(86362001)(83380400001)(8676002)(2616005)(53546011)(2906002)(6486002)(5660300002)(186003)(316002)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?qTLcisw/TxyRyA37/qanQRNDWlvJcYq1bBfcNQpnpPdYi6VIjwqSQvT4?= =?Windows-1252?Q?r8LDKyI1n6OPgphCV6gNbGdJOrtEmW9nfWNfS1/XUJAF0PP/zR+tTyWj?= =?Windows-1252?Q?ED9gLlcA0BJv/HaW+7ulLS4PuJrE6rUnBUPKGdjieL0Z3079H4F0V5rk?= =?Windows-1252?Q?VhfRQFizEbnBgQ/ockRpQtiolEQ0Wuwso0rYmPIUYLqE8FbI5hgIQhE1?= =?Windows-1252?Q?6d6UUSOJe5U4yPxXcM3h1iIHg1cl2rLNCEazxr1GGgeK1m4R2fE9gviS?= =?Windows-1252?Q?GSTdmE8wJtbNbHYqDLEHBr8E7bYMEFE1aOBvJIejYZXJcBJOinL0rTYw?= =?Windows-1252?Q?dRs7gpOsciAE4gU1IRyAylUSPsYkTczIcUjjOsQJ6j8HmSQERU1tGFSE?= =?Windows-1252?Q?yCR6tfMl04msfx/Qpx0Wkw6YN+ZqRdg8I3Mxv4qpvkck8I7okVBOs62P?= =?Windows-1252?Q?gKz2O0TF95Otqs9X/BOiJeBK3xNOH1J8wKhCbd6W+/lZSG6h5fLK0yZQ?= =?Windows-1252?Q?dXp6KX3E9cfouIXFJ3W900WgAm+yO5gAmLyQzl8PgRMIXkvZWjqZNerX?= =?Windows-1252?Q?OiqrdLcbE6Ll46rWwsvs2kR9zkP0TjBVe0tMEiH4X22k830yTNNHAPcF?= =?Windows-1252?Q?ZHCX6WggYoZ3xBQqFqovsv7GvjR4kCxGzTrxiD+Yz3Jg324FxWn0ZT5O?= =?Windows-1252?Q?sLOxRh8TnXij4Efl0SJ83Jo3JYEoKJUOHDztfimUVUXZbBUSwAkRlQDL?= =?Windows-1252?Q?w5N57RlerH3ffb7JP0cm6lMaKuOJHqPWZUUUiAHqaROrUAIMKjPK06bZ?= =?Windows-1252?Q?M9E6manHIUQq5vMdaamWTndFJo/5/z7AXAHq8egAyr2XDEfqq75p5UPS?= =?Windows-1252?Q?44+9nRR+zkws2UD7/cYyw//4ugfFkxyBngd6e4w6NfitTFB6dzb9YRZ4?= =?Windows-1252?Q?tFWQQUKS2tLvgTlZXOSW8blgp4lRrMTDEw4epwsGDkR9YZhr3gQaMbOX?= =?Windows-1252?Q?658uv+9Yh5SaZ/zjz67dvQZs52NOjS5MWkN6ZSNpY9F6V7ig9ZEa1Pgj?= =?Windows-1252?Q?JJdt5yiBWz3llITVh9mFw/0qMQPVZx1pmQ90YafVGz0prLpmQTSJP/HE?= =?Windows-1252?Q?ATFQ/vRAYl/kGPVerHcEULqDSE+cKN1ZyawUG4z/7GDEY1Dxgg8ZRFDq?= =?Windows-1252?Q?0vydjWe9k87IjlgmyqD3P/BCcC11zQTp+W9KSfZio4QV9iB9+DmC1SvR?= =?Windows-1252?Q?eOFl6hBeaSkymcD1bwl7EVl+++8p7rujuKug36fQGevXfYUgCZAn3PvQ?= =?Windows-1252?Q?AR17xlvezSptoTF+UfAuTQjdSNnR97eKbvWTSR5DEZXVukuu5aNKUznI?= =?Windows-1252?Q?tHeXCUZ6pBvxIv6IvJNHo5VAPfracr6IS4qSNhbCCHPK4Gi/5auas0pZ?= =?Windows-1252?Q?nUAnRGtlkAphrRhfTsJtnmxWVjXuNLtVzWEBHJznQWOn1ieYtupzpvPX?= =?Windows-1252?Q?qnqtQ9+B?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: afd94cfa-0a9b-4b89-f822-08d9777c8363 X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2021 12:38:11.5131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kMcb6CrGGTtUlfxJgQixI+g/v1d4+sQrUpBw7TVnqr1oOashgoEe8F60T678W4MU6RDB6zYmBsrOvWa+kc2acw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB3731 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 12:38:15 -0000 On 9/14/2021 4:47 AM, Corinna Vinschen wrote: > On Sep 14 17:07, Takashi Yano wrote: >> On Mon, 13 Sep 2021 22:15:25 +0200 >> Corinna Vinschen wrote: >>> That should depend on the O_CLOEXEC setting, but identically for >>> all handles in the fhandler. >> >> I found the cause. set_close_on_exec() in fhandler_pipe is missing. >> set_no_inheritance() calls for all adjunct handles are necessary. >> >>> I pushed two more patches to topic/pipe in terms of inheritence, >>> maybe that gives a clue? >> >> I attached two additional patch for this issue. > > Uh oh! This patch to fhandler_base::dup made me check other fhandlers > and, yeah, we have more unconditional inheritence ignoring O_CLOEXEC > (fhandler_tape for instance). We should fix that at one point, but that > requires your patch to go to master first. Let's just keep that in mind > for now. I think the change to fhandler_base::dup was unnecessary (technically), because dtable::dup_worker takes care of that with newfh->set_close_on_exec (!!(flags & O_CLOEXEC)); But the code is certainly more clear after the change, and I agree that it should be changed in the other fhandlers also. Ken