From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2090.outbound.protection.outlook.com [40.107.93.90]) by sourceware.org (Postfix) with ESMTPS id E5F4039B0408 for ; Fri, 17 Jul 2020 12:52:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E5F4039B0408 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NnNT1Cn+gRXShg1v7YC+nNVbO43cqH1lBjO4A0aZKiFJfAXDb/ZUxHmvWukkEfFkUHr62kQ1Eern2CYxOg3Q899PQaLr55LHRNMTJnK9chFX86TrImtHIp7s4HKtG/wFzmygjqbr+duyH1FqrXrqqPv1UMxXiHhyuEV0+l0B26JnVFzMgCwT6hMZH2bSo96wc5hhnb5e6XArbxkFFOUG7gJLzlbL4YJYGpoaQtqP528dVwkap5aqL0hJRG+KhrH/IOuPUSWz+Em/nyrvoFWBjfwdrrHqp/qvd6FDPh9FY7CQ/AQEPetKHvmpB2QmRyZBvhGov5ggZwXRHb2fstkicQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mymydYv9LS4B6jqYCa77mzTjh8R/iJ/39DHKIhDI634=; b=JjLmG+0Lu4rEeI2qtClkyGJIZVTSlQEkAWc00xd3D6bcWXI14pAkktKkfQSMTt+vTLLsQX/DXzO5XFLopSACOFn0E44UJZm7ek1bJnm7VAt547DroMWfLV2y7KRvpqPP5aOpt93A3kOSssSKeJ71s+iMEvLEMbux34h0bS4OpQ5ubl76T+pT85POeTLTi/ozO8n+Q5N0h4KH8UdAAhK4q461ZB8RK1tbALyKzo6O+Txk5eJBd+acR3hkFjA6TVCXqA4z93V2C1t1Kb43nIVTdrB+zdJrvHs38viaD/Akbc84C88IwpUXmE9Cd/ZcfGfmPr8EctBghEDqJgq13WayWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none Received: from MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) by MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Fri, 17 Jul 2020 12:52:17 +0000 Received: from MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::184d:a265:1d48:499a]) by MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::184d:a265:1d48:499a%7]) with mapi id 15.20.3174.027; Fri, 17 Jul 2020 12:52:17 +0000 Subject: Re: New implementation of pseudo console support (experimental) To: cygwin-developers@cygwin.com References: <20200513211609.011d188c3a735b00d55591df@nifty.ne.jp> <20200514182859.c5236a8889ab3081d2e8c937@nifty.ne.jp> <20200514183420.c246647a6d9e396d42c6b47e@nifty.ne.jp> <20200516092956.74369d694d611b1dcd095607@nifty.ne.jp> <20200516164735.2a2ef183788b151e9185ef41@nifty.ne.jp> <20200519224018.746f6324badd8a5762df42b1@nifty.ne.jp> <20200525195332.cf60ab2f38d167a76513740e@nifty.ne.jp> <20200526100955.30b1a2baea517e0565f30db6@nifty.ne.jp> <20200529004024.0c2ac3c68b588bda987e0837@nifty.ne.jp> <20200701204751.27609a8f5701010468521a87@nifty.ne.jp> <20200717111912.GG3784@calimero.vinschen.de> From: Ken Brown Message-ID: Date: Fri, 17 Jul 2020 08:52:15 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20200717111912.GG3784@calimero.vinschen.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH2PR07CA0036.namprd07.prod.outlook.com (2603:10b6:610:20::49) To MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.17] (68.175.129.7) by CH2PR07CA0036.namprd07.prod.outlook.com (2603:10b6:610:20::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.18 via Frontend Transport; Fri, 17 Jul 2020 12:52:16 +0000 X-Originating-IP: [68.175.129.7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 841dac16-9a7d-4289-99d1-08d82a503c61 X-MS-TrafficTypeDiagnostic: MN2PR04MB6176: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1284; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TjBqBkM2S3DcJ/jhkk0E1eG05jCzKc5loye4CiQKB8EQNb0R6vr83H2BzBmgWmx9RomTkL8E1RTBQchjEeRz/nPzdBglIBE0BeezkodkQNSMO+G4YjiK6UO5Cp+NNAwLGcGrKpVnO56rEgvpfOGvDrjMTdnYx6MA8JlUoYF0jVQ4+O+qRIEutpw8m1GDFNxIR9KAFajr7JWRvioFC3aP/ZrUsUn0KMo8OhbiKxEGo5WuEMVUbZk/wkN1dOiEHrOlDAG9H2LwfMgYmwzw8nUrRv/plXa4cZsWi7D+uyFRQSyHu17hTk5geH+wQShli21gnFgqGBTlucg2J+wNDKO4JnoidaXWM805f95AMvdjVFEY4hYgx0kTSR9wPp9nffzV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR04MB6176.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(346002)(39860400002)(136003)(376002)(396003)(186003)(8936002)(8676002)(66476007)(66556008)(86362001)(6486002)(66946007)(53546011)(5660300002)(6916009)(52116002)(2616005)(26005)(16576012)(316002)(75432002)(956004)(83380400001)(31696002)(31686004)(16526019)(2906002)(36756003)(786003)(478600001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: w2+pkKiPxmcGsXVzWZ+Br0MpXcMuWD3W8QxZNo4OTJiM8O14W78xaTuudr2dnfTKbaAXlDVGMxtSNcxaLA+QfUvgSex1P+SgWw6SdYcZjpirz/hhbEM/fEOHKAye6o+vWwz5RXjJvUaTURq2nd7RJIAFUOFzMHVw6LH7S32QT6e6IZcz8kGWyyqGwmYKvIBKXf/es9oMdorMKGvQx6+39ZT6PC7uQ/GXBo5o402BMCXSEYCHjJ4gKvAbV3j69bIEX0bdFYHHHCvkPvIaDhazUG21AKHjpQ3ZUmYFNOzQLflLwhVI2ZtyyXP3tOcsMT/hgGGXDfTpHr8GXLF87L7lWKiSqhQ3xdms2p8d/BltdT2xOWKnTuScgl6lw6EogncdH936scvx1YST6g06OPhslVu/GBHhntDdB26fBhxhoMMcRCVFDJj0hlirq5xOLRxLIu3gyHPRP48EVIbbgX4TnRs5E/StCzIycttSoCIab8s= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 841dac16-9a7d-4289-99d1-08d82a503c61 X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6176.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2020 12:52:17.4173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: krN/tkmwis8OPal1NOn1TPO4fuZk1Leu+CWVZTcQUDJCiriH6tNpyxi/wGAEM7TA2qdoUUVAyQB5CFGcVawgRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6176 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2020 12:52:22 -0000 On 7/17/2020 7:19 AM, Corinna Vinschen wrote: > Hi Takashi, > > On Jul 1 20:47, Takashi Yano via Cygwin-developers wrote: >> On Fri, 29 May 2020 00:40:24 +0900 >> Takashi Yano via Cygwin-developers wrote: >>> On Tue, 26 May 2020 10:09:55 +0900 >>> Takashi Yano via Cygwin-developers wrote: >>>> On Mon, 25 May 2020 19:53:32 +0900 >>>> Takashi Yano via Cygwin-developers wrote: >>>>> On Tue, 19 May 2020 22:40:18 +0900 >>>>> Takashi Yano via Cygwin-developers wrote: >>>>>> On Sat, 16 May 2020 16:47:35 +0900 >>>>>> Takashi Yano via Cygwin-developers wrote: >>>>>>> On Sat, 16 May 2020 09:29:56 +0900 >>>>>>> Takashi Yano via Cygwin-developers wrote: >>>>>>>> Fix a small bug caused when stdio is redirected to another pty. >>>>>>> >>>>>>> Fix another bug caused when stdio is redirected to another pty. >>>>>> >>>>>> Revise the patch to fit the current git head. >>>>> >>>>> Revise the patch again to fit the current git head. >>>> >>>> Make app, which reads stdin, work under gdb. >>> >>> * Prevent ResizePseudoConsole() calls unless the pty is resized. >>> * Revise the patch to fit the current git head. >> >> Revise the patch to fit the current git head. > > are you satisfied with the code? If you want to merge it, > I'd bump Cygwin to 3.2. FWIW, I just installed this patch locally and am seeing noticeable speed improvements. For example, here's the result of running 'make -j13 check' in the info subdirectory of the texinfo source directory. [I chose this test because it uses both FIFOs and ptys.] Without the patch: $ time make -j13 check [...] real 0m20.705s user 0m18.639s sys 0m40.187s With the patch: $ time make -j13 check [...] real 0m9.332s user 0m14.153s sys 0m30.235s Ken