From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-045.btinternet.com (mailomta18-re.btinternet.com [213.120.69.111]) by sourceware.org (Postfix) with ESMTPS id 3F3DA3858C50 for ; Sat, 29 Apr 2023 15:40:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F3DA3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.54.8]) by re-prd-fep-045.btinternet.com with ESMTP id <20230429154041.NEMQ10658.re-prd-fep-045.btinternet.com@re-prd-rgout-005.btmx-prd.synchronoss.net>; Sat, 29 Apr 2023 16:40:41 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 63FE9B9506DD7FD6 X-Originating-IP: [86.140.69.123] X-OWM-Source-IP: 86.140.69.123 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvtddgieejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpedvtdetffekveevjeegheeglefhtdeggfeilefggfdutedufedvgefgieeiffdtveenucfkphepkeeirddugedtrdeiledruddvfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtiegnpdhinhgvthepkeeirddugedtrdeiledruddvfedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtoheptgihghifihhnqdguvghvvghlohhpvghrshestgihghifihhnrdgtohhmpdhrtghpthhtohepnhgrthhhsggrphhprghisehgmhgrihhlrdgtohhmpdhrvghvkffrpehhohhsthekiedqudegtddqieelqdduvdefrdhrrghnghgvkeeiqddugedtrdgsthgtvghnthhrrghlphhluhhsrdgtohhmpdgruhhthhgpuhhsvghrpehjohhnthhurhhnvgihsegsthhinhhtvghr nhgvthdrtghomhdpghgvohfkrfepifeupdfovfetjfhoshhtpehrvgdqphhrugdqrhhgohhuthdqtddthe X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.106] (86.140.69.123) by re-prd-rgout-005.btmx-prd.synchronoss.net (5.8.814) (authenticated as jonturney@btinternet.com) id 63FE9B9506DD7FD6; Sat, 29 Apr 2023 16:40:41 +0100 Message-ID: Date: Sat, 29 Apr 2023 16:40:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] Cygwin: Fix compiling with w32api-headers v11.0.0 To: cygwin-developers@cygwin.com, Biswapriyo Nath References: <20230429132250.842-1-nathbappai@gmail.com> Content-Language: en-GB From: Jon Turney In-Reply-To: <20230429132250.842-1-nathbappai@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29/04/2023 14:22, Biswapriyo Nath wrote: > This solves redefinition of FILE_CS_FLAG_CASE_SENSITIVE_DIR in winnt.h > and fixes the following compiler errors > > ntdll.h:523:3: error: expected identifier before numeric constant > 523 | FILE_CS_FLAG_CASE_SENSITIVE_DIR = 0x01 > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ntdll.h:522:1: note: to match this ‘{’ > 522 | { > | ^ > --- > winsup/cygwin/local_includes/ntdll.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/winsup/cygwin/local_includes/ntdll.h b/winsup/cygwin/local_includes/ntdll.h > index 8c4d008..488e659 100644 > --- a/winsup/cygwin/local_includes/ntdll.h > +++ b/winsup/cygwin/local_includes/ntdll.h > @@ -518,11 +518,6 @@ enum > FILE_RENAME_IGNORE_READONLY_ATTRIBUTE = 0x40 > }; > > -enum > -{ > - FILE_CS_FLAG_CASE_SENSITIVE_DIR = 0x01 > -}; > - I think this probably needs wrapping in a __MINGW64_VERSION_MAJOR check, or the minimum w32api version needs checking in winsup/configure.ac.