From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on20703.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e83::703]) by sourceware.org (Postfix) with ESMTPS id AFF95385DC3B for ; Sat, 21 May 2022 21:22:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AFF95385DC3B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cornell.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cornell.edu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RIngIgE0o+FbPw52zXuS6MfVfETnvNeEELFVPni0ZDklUGSzLSigp/D8bQGbEEpOKtB6rcv56McGwFzPlVzh/Mh0Az3JB/7KrrZjbQnCoVR6cwwo++0qZMCGRTaH+VsDrNUw9PUfbKfXDtgPLRW6AjPJl8eKo3BLJvSTikHd7EmeO7I/2sK/Kfjl9SOR7OgKHXyxEtPrCgzxWN8OkqUS/in42LBjM1/yulqTmBxzt4PR3cd88y/4A/stCYiqe3eCfNe87q3aUa2V44m3CNeLVaVCwjxFFcX+DdVBZCDT2c1X0pD21lUGM0L/vwj6fZTkdLEhnpDzUQABTj6t7wFD9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5vMyA+zHq1vLigAbUAZrS/QwJ6E3o7lgpCBXsaQjqa0=; b=TGFbBJCs7huaJfdBEUm21/ClqHRM2f5oKnQsW4i5FE2JTONAVTp78iXzmCFhnyl08mUXt8ObafxHA9ohK2FHxAKzp6sUOQljRArWT9HvnV0E399O2YU/BFZKIWf+O9u73nwHA8fU6L2uCJp2b0s3Ox+f+xzNrS0hZ43iPBGLWA/e5RaezHTAkqGnJM49ni9iQMqcBWWMGxv3Tt9Z+fJkRFbuKT0LSDxGsRK/wexvIk7JqWpPjvdQ6WUHS+vLY9HlPIxBRMYWTvoAunCoRHKAhBLbo5oXmny1P3HuwiM52vfH+HDCjN7abVUtnk91K/o2rxZNoDV0YlQtoNkWy5jZNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5vMyA+zHq1vLigAbUAZrS/QwJ6E3o7lgpCBXsaQjqa0=; b=L7MZtT1Td3SbOunGEWLK372OSCP5iTLaQk+ePGzr2YIPRlSEMIKTkRp/ae4ib/ZYjrch/053LNHMdYgxnh+dj9hEAD5Od1aNIUrHeqT8CcHlWZTZGjbJiBtzXcWvvcP2gA0GIEI3xlJ+PzZzQ8epV35sVs/TtssMsKR0ac60o3U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by SJ0PR04MB7390.namprd04.prod.outlook.com (2603:10b6:a03:293::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.13; Sat, 21 May 2022 21:22:26 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::ed45:6a5d:b109:673e]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::ed45:6a5d:b109:673e%6]) with mapi id 15.20.5273.018; Sat, 21 May 2022 21:22:25 +0000 Message-ID: Date: Sat, 21 May 2022 17:22:24 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: cygwin-devel From: Ken Brown Subject: mknod bug? Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR20CA0057.namprd20.prod.outlook.com (2603:10b6:208:235::26) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 81562efb-468b-45cc-4b09-08da3b70008c X-MS-TrafficTypeDiagnostic: SJ0PR04MB7390:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t0erTZGSVPpxOpU6mtQSKVWHBTBNVieoGqGjnnmAg67599KlR6NeGiFzybBGettHVN3QHd3Kakox04cvq//OjjnomoTpxkrX/kpvz9zQALJbU3Y+Fp4Iu2+tg++crzaoxWjIN/QNQIU/lL8V+fcvDq03I7OYXV/Ypbrvea/3kHRI02YzSDgOmXR8vzat9ou69qwiakR2J/ekwoTZ+xL3TobueSdATtu6ZGPGrMfs+52paXwu8F0v9Zap4pP08zaawaFNWjMXtiRbE4kg0iQRx51e6VSaeFTzk8d7DYxr1GneVNMTlKscwggnzBX+BoVYJxH7VgVXUF3rqExij0scT0NTKtQ0BOm/tQ1S8xE/44QDT2+GompbwAOlAVoXyjDeK5AwyF394WfmJN9LsXcsfsY7y62PogzZ2siw0bcurxOgLV24HZp0HdC83uVB+gc8KelzqawX/ERyh+d8ogUiEXlFPQOijmajj2Fx9D5deFEHvZeCseHRKyFtzUugqpF+6g7EuCNaE2Jg5bV5Y3K210qe6+IU/1b+j699luRboRkzNo6Nzt09Eeoic2mJhaF9c7Pd5Ub8cTDQFjmxe1ThwHi+MNovL2uLKlQGdIlPYl7sSHRkbyh6aQhOQOO1NncGm2Ix8wFtCrYLy0LrCyW9gmJJH+Ki7iadFIsWnw1+L1BCXd99ScJRgBmGyl2bpc87w1soH/6TeySv9cO2Bsn0m2qTP8gSULeBVtTqUZC73Hk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66946007)(66476007)(7116003)(8676002)(66556008)(38100700002)(6512007)(31696002)(3480700007)(8936002)(5660300002)(83380400001)(2616005)(6486002)(86362001)(508600001)(36756003)(31686004)(75432002)(786003)(316002)(186003)(6916009)(2906002)(6506007)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmhBN0NFbXlKaFBtWUpVd1FFLzVZa2RCRXhyd0tYS3AwTk5ORWRqbld4M2Jw?= =?utf-8?B?Qm1OSDNXRWN1VVJiQ1pzVFV0RHk3c1piZ1N6bUpESklQWXlPcEFQK0l4UVRp?= =?utf-8?B?UU9hL2Y1d2V1L0Rkenlid0wyOHI4QXJER2luTEhZR0ZyaU4yK1ZIcGQ2cHo1?= =?utf-8?B?MWQ5R2I3UEtUbVRtaExteDM0aVN4SWNoVDhCMWxRMXNZOXF5VFNNdjV2S0R6?= =?utf-8?B?bTdMQXJUajJoZ0dhektueFc2N2xRYlY2ZWJRekoyR010bTdYN2R1T3NycnFK?= =?utf-8?B?RUZOQlBMK3JsV1M5cjFlMVlTc0g3UzV4a2JJZWhVQ1lsSGlTL282M05qakp4?= =?utf-8?B?c0IwVlNpUm16ckttdXV5cC8ybWNFMzV5Qlh4TnNiSW5FSGdMRi9qWlVUdEl3?= =?utf-8?B?czZOWWJlT3lPdmFlN28xVVRQOEk0bWZJSFUxc3BvUzlMVzdCcFR1bDdpNUpO?= =?utf-8?B?Y0cySTBlUXJUMjdCc2FoaDdNbjVSTkNDdWN0c0ptR245VjZjclE2U1hpclRi?= =?utf-8?B?TjRyNHNNeDMxZnpLN0lYb3NyT1g0NmI4UzFXTldPc3hJcEwvWnlXdSt0K2VE?= =?utf-8?B?YTNxSFVXZkc1aFEzNTZkdFlpbzYzSzRBMkpsa1RpbjZEaWVKSXNvdktBVU43?= =?utf-8?B?a0EwSmRmcnovbERwMHJXUUdrd1lwVm00aVpxaUtyK0o2TkY5WGN2TU5pTTEx?= =?utf-8?B?ckd3Y01HOTUzQ1MrN1N4YXdnNGd0REZIRGVlK3VqMmxOMWRCeHpjZ2lrM2gx?= =?utf-8?B?ekhDOWRBVERyUjJWQ2hrRy90T3FWeWY1NmovRXkzVW9OU3lEYTVrV1Z0ZGEr?= =?utf-8?B?WElOR3NsQmNVai9MRjRaWVY5U0huM1pnVTFldDBQVWtaMnBLVjF0NlV2eUJx?= =?utf-8?B?RjFhdHJSbjRLcEtWNHhmZStISGtFUzJYckozWk1ybC9iVGhEWkdKU2ZRT0Zh?= =?utf-8?B?ZGFNc0ZuSVA5VkZ2ME1Lb3JnUGVUbGluMlhHbFAvOHdaeEM2MG0rWkJHdGJJ?= =?utf-8?B?YWEwWE4za0piL3NvaXYyQ3JhSlU5blhVQ3dvZGtLNURPUkhpRWtWTlFESm5Q?= =?utf-8?B?cDEvamJ2L2ttaGZwZ1hxTFJLbnJuZEFQQlJSSDJSdmI3aldTNUcvS0k5UU0w?= =?utf-8?B?NUZHWU1IMFpPYlNrMEdEWmFLMTJQd2o5WnRsYXdNZWtFTW53WFBKUURPTjVa?= =?utf-8?B?VmdsTW9hQ2R2YmFhMDZSRFZteUJ2MExwZUdZcExoME1HSkpiMmlQRUljQ0V1?= =?utf-8?B?RVFVdWp4UDc3M3hXdW1DK1VlbkFWWDdsUzZNTXRQUTFHa3FxdEQ3MmJjWGUv?= =?utf-8?B?bEkrRXc1VmJvYXZ4M3ZVZU80U3NROGVIMWlVZ1hCb3FnM21wMXZ0VjFaTFpY?= =?utf-8?B?bUZTa2JSUkFFQWh0emdiY1lrdFd6cHNOMUsyeVVDZWowak1iUHN4WkowNFhj?= =?utf-8?B?c3pWUnBWcVRlZmZkUFVTMXlpblF6aGFsVUx6NjFQN0tVUHZ2b2xoLytJaXN2?= =?utf-8?B?TTlRZHIyc0xBZ0w4ZHFNRXliS2QyaG00ZGVDc2tjank3Qjl5MFJ4ZGJTNzN3?= =?utf-8?B?Q3J5VVpJV0FKcktyUzY4UzArc0pmSys3YXp2c2o4YzJENjNCVmx1QWNpRThR?= =?utf-8?B?cE1iVXFUZU1qMTlRc0FCOGR2MEY5SWhiK2NPaHRxSm56MEtYYy92NEpMQnd6?= =?utf-8?B?ZSs5M1lSSHN4TTBrWVhETG1SakJML29ZMytUUEF5VDdNRWtrdlJUUEoyN0tx?= =?utf-8?B?ZUgxSmZpRmJYdHJnWG10TnFvRHZaaEE2cys4S0VSVHJxYzlNM05NMm5tMHhH?= =?utf-8?B?L0ZuaVFLUXlxOVFaSnhzcWhoUVRjNjY2cjZZRHZpQjh3ekxCdDE1UnhnNUlE?= =?utf-8?B?WE5BVURIN2lIVTR1ZC9yMlNKYStaWHZ1eGw3TFBKLzZsZ1g4ZDJGbWgrUTdw?= =?utf-8?B?c21TQ2RhclJ6UklZQXV0aU0xdHBlM29wUmwxWW5HcUVLd3o4UGNLRFdaVXJ1?= =?utf-8?B?VDRYUkk0eUdYdWxyQ1M4bmYyTy9sOCtML1BTN2hjbndDR0ZSaVh5V2RaS0Z3?= =?utf-8?B?NXlKOURsRldqUjA2cStCYW9UdStEWUtUOHdWVm1PeTNGdzVkbEZkTkNXM2VJ?= =?utf-8?B?UlFwZGxHTFRQWm5YQXJNeENWT2FGV0dBUEVGTHJJK2ZocTcvQ2NyUFlSdTdB?= =?utf-8?B?cG9lZ21YUm5aVm5kWk9hODNzK3d6WGdvQ2hpY2x6TzVJU2hqU3IwNzdMUTky?= =?utf-8?B?NGxBeEdBeGtid1EydzdCWTFLOXo1Uyt0anJ4K1dDbmlFTm5HdlNBaTJtY3RC?= =?utf-8?B?M0d1Ly9GSG9nUkZ3MFpXczQ1Y05OdGcwOGpkY3JDRXJIZlllV3IwbEhLQTJs?= =?utf-8?Q?1DjEr5GVCAal7JAwv0teK6mv0CL3tDg5z+BaGNwLyfswM?= X-MS-Exchange-AntiSpam-MessageData-1: XRvNzRZ9NwcgDQ== X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 81562efb-468b-45cc-4b09-08da3b70008c X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2022 21:22:25.9635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g11oIWnY50q5qCm3EaBJL5T4pbIHS+BNfRApkwfngGMmIhOeJBxzZPWGIDlmKwaGscLddZMd5yTyivhGHmMlEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7390 X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, JMQ_SPF_NEUTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 May 2022 21:22:31 -0000 The definition of mknod in syscalls.cc has a third argument of type __dev16_t instead of dev_t. This doesn't matter on 32-bit Cygwin, because calls to mknod are redirected to mknod32 via NEW_FUNCTIONS in Makefile.am [cygwin-3_3-branch only]. Presumably this definition exists for the sake of old 32-bit apps that were built when dev_t was 16 bits. But it seems to be a clear bug on 64-bit Cygwin. I think we need the following, similar to what we do for many other syscalls: diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index 3a652c4f4..344d1d329 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -3490,11 +3490,15 @@ mknod32 (const char *path, mode_t mode, dev_t dev) return -1; } +#ifdef __i386__ extern "C" int mknod (const char *_path, mode_t mode, __dev16_t dev) { return mknod32 (_path, mode, (dev_t) dev); } +#else +EXPORT_ALIAS (mknod32, mknod) +#endif extern "C" int mkfifo (const char *path, mode_t mode) If I'm right, this is a longstanding bug, and I'm surprised no one has noticed it before. Am I missing something? Ken