From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2097.outbound.protection.outlook.com [40.107.244.97]) by sourceware.org (Postfix) with ESMTPS id 2C7F8385800C for ; Thu, 16 Sep 2021 15:46:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2C7F8385800C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=cornell.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cornell.edu ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eQlEs6ol4SLDalBt9vZrlmP3MOMTRvH43MUSaA2DaZgPfrEWrRcYXaUvqjjWub0udJk4UGJiJE8WU1zh4ZgYzgT1Lntc3HNiLlrWdXvj3/WZwBKSsggLnfC5bKn06JvJ+qO4lac3tgVwHUkKPAhLltD/GEn/lUe00+qvI/KEC+rUpOPRpRApTucbrLufCrmLRQbMQAJQlT/IxtUBYfhTzohKd1BDUaDeLIKX5yxJg5d2UiAdjVRnegzQVor2Y4qQRbFVsle4Bc97cAv3vmC0AuwDr7laklBXPirQBBWFADhvt8IyohZxPzGqgPNlG18JKKN1y/CUhb38uhWh+jxevQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=66sHBVB1FtzpmY1HfGthDjNYfUnUXhS7dP77hft85lw=; b=eWEjXtREsTudKa64jTzbDdy1CDAWgdg73DFJ0KZRRZRLQaN3UyX0fCez/Zr0l6s4GCThpSnqVG065gkSxTlnwCv32f5fFRg2neDQHFFEL1a/7KvxXSvInArcSFhBAa/F38djuDysnJSz31lO9ugKLLDZ6c+lX2Mk2D60YFjtj0lDAICRZ4UvmVz7FBup+QcDEp81F+ZCYgXZ6pp6mA++xKcwILeMJEg/RSWRM6iq1awLS+RCVoHH0/y5V9FEq8WjeNJL4fRoxhd5Qbew+84XhlEOIA9Z/dpyvX10fILWGJu1FzPs+Z06cFOwpV/tukOI+PEppoEpMxr0tcHqgMmVTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=66sHBVB1FtzpmY1HfGthDjNYfUnUXhS7dP77hft85lw=; b=cGtFvVcFQA10CHxhCO8Kjg26FExTMJLR54XSvoK9P3ZROfj0VTuIkE6Jiw0j3IcIbKMNNFtxv03XCb7MMcilaFiO4u9p+D6f4UNem411fVbPt1uKbmDSmw56edWCodFtVxEmSecuZg2JTqPO+i9q1cE2l1nw6TfYi5WQlUMpbJY= Authentication-Results: cygwin.com; dkim=none (message not signed) header.d=none;cygwin.com; dmarc=none action=none header.from=cornell.edu; Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN8PR04MB6372.namprd04.prod.outlook.com (2603:10b6:408:dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 15:46:55 +0000 Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::5113:e84a:b38a:7a66]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::5113:e84a:b38a:7a66%6]) with mapi id 15.20.4523.016; Thu, 16 Sep 2021 15:46:55 +0000 Subject: Re: cygrunsrv + sshd + rsync = 20 times too slow -- throttled? To: cygwin-developers@cygwin.com References: <20210915205433.014102a9c1204687135e1417@nifty.ne.jp> <20210915220450.a96397d8b8159d9adfbdab07@nifty.ne.jp> <3ca95472-9fb2-3e62-3e28-1bd2f85bc018@cornell.edu> <99e3ac84-bee1-4abd-de9a-4ea2e7b62b61@cornell.edu> <20210916180905.5f857dad0568be96ac36cba5@nifty.ne.jp> <20210916220201.63924a67f337ea876954d7c0@nifty.ne.jp> <20210916232756.fe8c744401b6cf703b1fe993@nifty.ne.jp> From: Ken Brown Message-ID: Date: Thu, 16 Sep 2021 11:46:52 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0PR03CA0014.namprd03.prod.outlook.com (2603:10b6:610:b0::19) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) MIME-Version: 1.0 Received: from [IPv6:2603:7081:7e3f:3419:1d84:cb99:9c15:8cd0] (2603:7081:7e3f:3419:1d84:cb99:9c15:8cd0) by CH0PR03CA0014.namprd03.prod.outlook.com (2603:10b6:610:b0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 15:46:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 06db767c-db27-489f-4acc-08d97929357c X-MS-TrafficTypeDiagnostic: BN8PR04MB6372: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L5DiLohNDvelgMchW5rhbpuUzf/S0hi4hQeUbzYtfZ/Csu8ljeigj2Q5SflTe6pTRtwJmmzvOOufgaa88AUb6a4XdOUGSzToXHd5Ej6WL/pFJr8FT+zc5UzM1lG3gCaN+HdlKRe6yNg3Fn5mYGKSaNT7TrKgAdQAr4c/DAsEcMLkZuc74rfRe3KGaItTOYhlSy/hZt2OH2+yu6IBoj4WZxsRyhZ151oAFXiA26a7eYcJEZVolEtqby7zQvmmIEswenqdaE7RKQZ9sxxFM7SsSEOSpHNHvc8bPWlEhE87e+zFsoIWig5SdquSswZ3t8LRy6AEBTn3YEvx4XXeDwYN2fy6u4TRVY9TnOuaeqc4CwhmMcxKLm5AJDE1juWYIpsol/ZNSn+eEYw4i4Mlg1BPkBYfHm32TgpWVp6tKH6/wqTrKH9Z5tYkqm2sScQZf4dHI9ZzYy9wPaamazHnuRGj1kAWa+Kvbbag8hn4AVStWECq4Q4BEQZgO1tfm+sT281ykQIunxA2rVbIXfeaTFs5dew9+4eH1YVy+VMiktcsVApCXUfaVoUJ114CffHfy8wHT559sJWkeU14dqBs06OoLBfynPMIQ3Y+HcUPFUxNoGXX0aMb0j6nKVeG4Vds+qLtqUl85M9B+YVF2C0C/eXCJMeCz6G8+JelhTd664aIi7Q43kyPZh8ZcKrkQLqvGIBKlsNDgJ1vYy2LtyiGpd8JuywDcuDFNCEcY810QugRP00= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(396003)(136003)(39860400002)(38100700002)(53546011)(316002)(2906002)(31686004)(36756003)(6486002)(8676002)(31696002)(186003)(8936002)(6916009)(83380400001)(75432002)(478600001)(2616005)(86362001)(5660300002)(66556008)(66476007)(66946007)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?HTjtoqsnNzLB4KTwC7ok55gZRJBhUqGEJxee1d/1YcyhribMH83JCdNT?= =?Windows-1252?Q?AMyPjGKNbgCmnrSOAW/d9BVwy2qErEZIfStpAr8fThE48wOJ5HQI92Yi?= =?Windows-1252?Q?Y1CrrDSmxDGKs4qI7Uadzifd1zsP+b9liTR8ZRU9UwCgtqvGcp8WT6q8?= =?Windows-1252?Q?cAChEeeQOZLPfGgt2fgy9CNsdvaTv/effr9PZQ3YgjbqqQM0RekiwZD+?= =?Windows-1252?Q?6QJeIAXw0nl4SsOWfOquWg3v6LREuAjGQHLtUznSuYaGsCSKsLWZDl+Y?= =?Windows-1252?Q?cbP/pviRdYsB/Q7in+g8CmlumjgYbjkMzZthxBfM4JXXPI/ebEDBSw/w?= =?Windows-1252?Q?oqc5kuztJm4j37YEoY8M5aeh9TouieARf6fLPW42xmFBBlSqD7Za0AGS?= =?Windows-1252?Q?tLNIsLg1wr0aZjA9J3JHcxJtR1KcG1fV70Nszva3hKTcU3J+3zrCd/Ki?= =?Windows-1252?Q?DQeCZ5ZS9CFXQ1bUrxMAk5FbKIEwDCYwi1z9sdjnOasweVzcUDhgVlLH?= =?Windows-1252?Q?4pxIjp52M5r48avAbvBs/2bKfXvu2UPxvYgErVYXoD58AEpa9+d3IQ+u?= =?Windows-1252?Q?n8nQvS6txSi/s6xcXdCOdyV+xTUIrW7bPSL2t4GXM/NZ0FRRqX/fZ2lT?= =?Windows-1252?Q?QW46UufaxR1cdVN0cWn1fPSX6Ohy1wDvcVPrF3mhKhjSHdXwEP/oa8ca?= =?Windows-1252?Q?Kh7clwgaeqR+yLQpdn1Cn/PBRt0sVdE9fpVA0NytAjsxvXFVXoUecXeC?= =?Windows-1252?Q?jT9yghXG7ywEuodqbM5NL7nN2gHZNdfiN6tvZIy5/9jC3qznpgB+ipXG?= =?Windows-1252?Q?TTls3hmVvEoWmVMwOu1BR7eqXDN7QsPEM80EqHCe8yLpaY2e2nngJSKI?= =?Windows-1252?Q?Fs0g3ozdUqF6FBAr2qGo+KfBPXVjXTXgtu1zS7msAdGZPcXHWS+2ebJk?= =?Windows-1252?Q?XqX92yxcPxO+mh7iAvGY/BORCpAu5w4M7oCnSAbXSI5sylXVxSl8ykxl?= =?Windows-1252?Q?+dHfcFdBWuMcuPA2/bGx7S/mHDce3XCieiIJJCdac86UtAkBoeCik1/9?= =?Windows-1252?Q?6DEkHe5nd2lFb+ompoWqC3h4KB6s1PRI21A20jvP9Vn8LWqiblqwyg1D?= =?Windows-1252?Q?8QbWUjcYfla0Kea7Ed/B097ou9LguqCNfeNzjnAPQ6taStNNzNUU1rkZ?= =?Windows-1252?Q?LsAmrEmEcJe5TJ+Ij/TaM9xVUCctaWHXfEblIZj5Vo/VTUU9E47yLmKQ?= =?Windows-1252?Q?Bepq3GtKO7tp58P0K+F6cCgMFet5X0nZBL3Lxg+TAGfQYbznnJBx2Ti5?= =?Windows-1252?Q?gXlnvqbKoGXZBgkkhwJxgvEch5csaB9lmpSPX4fU84omKqGqlv29AeBH?= =?Windows-1252?Q?rCHmXwqG4onB3NMD1bWaaqxbUeU4zHJPz1t+aqBTsPchnNJM1BvNUSZh?= =?Windows-1252?Q?wHgDsvOldoLXnkkmG6mjYbhX5U2lE0xfRgqJ/F2/UA72/ncNPcYG+sVK?= =?Windows-1252?Q?CBMiujc7?= X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 06db767c-db27-489f-4acc-08d97929357c X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 15:46:55.0342 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8k6CvCOLpomO2swee/DCcMRqncBqBWpTYZShgxdCVywpDLsClvZkdsRVxfgQ/ITW81HOq8mhMl4NduPn0sAgUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB6372 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-developers@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin core component developers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2021 15:46:58 -0000 On 9/16/2021 11:01 AM, Corinna Vinschen wrote: > On Sep 16 23:27, Takashi Yano wrote: >> On Thu, 16 Sep 2021 15:25:46 +0200 >> Corinna Vinschen wrote: >>> [...] >>> It would be great if open_setup() would be converted to a method which >>> is allowed to fail, rather than ignoring errors in sync object creation >>> and having to test the handle throughout the code. Given there's only a >>> single caller of that function (dtable::init_std_file_from_handle), that >>> shouldn't be much work. But it's certainly better than ignoring creation >>> failures in the long run. >> >> I do not have confidence to do this correctly in a short time. >> Leave it as a homework. Or may I leave it to you? > > That's not a short-term problem, but I think it would be good to do this > with a bit more paranoia at creation time and then rely on the handles > being available in the subsequent code. Maybe I can get to it later but > it certainly wouldn't hurt my feelings if one of you guys look into it > while I'm abroad. :) > >> I have attached the patches revised. > > LGTM. I leave it to Ken to take another look and push it. Done. One minor thing I just noticed: If I'm not mistaken, query_hdl, hdl_cnt_mtx, and reader_closed() are used only for pipes, but they're defined in fhandler_pipe_fifo rather than fhandler_pipe. Is there a reason for that? Ken