public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-patches@cygwin.com, Brian Inglis <Brian.Inglis@Shaw.ca>
Subject: Re: [PATCH] fhandler/proc.cc(format_proc_cpuinfo): Add Linux 6.3 cpuinfo
Date: Fri, 12 May 2023 16:36:52 +0100	[thread overview]
Message-ID: <0a50e9ad-59c8-65e9-95f5-f53843fbf918@dronecode.org.uk> (raw)
In-Reply-To: <68bbf3607bdf37fcd32613aa962abe50846d968a.1682994011.git.Brian.Inglis@Shaw.ca>

On 08/05/2023 04:12, Brian Inglis wrote:
> cpuid    0x00000007:0 ecx:7 shstk Shadow Stack support & Windows [20]20H1/[20]2004+
> 		    => user_shstk User mode program Shadow Stack support
> AMD SVM  0x8000000a:0 edx:25 vnmi virtual Non-Maskable Interrrupts
> Sync AMD 0x80000008:0 ebx flags across two output locations

Thanks.  I applied this.

Does this need applying to the 3.4 branch as well?

> ---
>   winsup/cygwin/fhandler/proc.cc | 29 ++++++++++++++++++++++-------

>   
> +      /* cpuid 0x00000007 ecx & Windows [20]20H1/[20]2004+ */
> +      if (maxf >= 0x00000007 && wincap.osname () >= "10.0"
> +					 && wincap.build_number () >= 19041)
> +        {
> +	  cpuid (&unused, &unused, &features1, &unused, 0x00000007, 0);
> +	  ftcprint (features1,  7, "user_shstk");	/* "user shadow stack" */
> +	}
> +

This seems a little odd and maybe worthy of a comment, as surely the CPU 
has the capability irrespective of the OS?


  reply	other threads:[~2023-05-12 15:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08  3:12 Brian Inglis
2023-05-12 15:36 ` Jon Turney [this message]
2023-05-12 18:09   ` Brian Inglis
2023-05-21 20:32     ` Jon Turney
2023-05-22 15:45       ` Brian Inglis
2023-06-05 16:55   ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a50e9ad-59c8-65e9-95f5-f53843fbf918@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=Brian.Inglis@Shaw.ca \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).