From: Jon Turney <jon.turney@dronecode.org.uk>
To: Cygwin Patches <cygwin-patches@cygwin.com>
Subject: Re: [PATCH 11/11] Ensure temporary directory used by tests exists
Date: Mon, 9 Nov 2020 21:01:51 +0000 [thread overview]
Message-ID: <1119060a-04d3-b966-b237-08af004a6337@dronecode.org.uk> (raw)
In-Reply-To: <2c5fbe84-338e-c470-68cf-cefaf5692613@cornell.edu>
On 09/11/2020 17:48, Ken Brown via Cygwin-patches wrote:
> On 11/9/2020 11:25 AM, Jon Turney wrote:
>> On 08/11/2020 19:27, Ken Brown via Cygwin-patches wrote:
>>> On 11/8/2020 1:52 PM, Jon Turney wrote:
>>>> On 08/11/2020 18:19, Ken Brown via Cygwin-patches wrote:
>>>>> On 11/5/2020 2:47 PM, Jon Turney wrote:
>>>>>> +# temporary directory to be used for files created by tests (as
>>>>>> an absolute,
>>>>>> +# /cygdrive path, so it can be understood by the test DLL, which
>>>>>> will have
>>>>>> +# different mount table)
>>>>>> +tmpdir = $(shell cygpath -ma $(objdir)/testsuite/tmp/ | sed -e
>>>>>> 's#^\([A-Z]\):#/cygdrive/\L\1#')
>>>>>
>>>>> This isn't right if the cygdrive prefix is not 'cygdrive'. Maybe
>>>>> use 'proc/cygdrive' instead of 'cygdrive'?
>>>>>
>>>>
>>>> That's how I originally had it. Unfortunately, test ltp/symlink01
>>>> relies on the test directory being specified as a canonicalized
>>>> pathname (i.e. is the same after realpath()).
>>>>
>>>> Since there's no /etc/fstab in the the filesystem relative to the
>>>> test DLL, I think it should always be using the default cygdrive
>>>> prefix?
>>>
>>> But there's a mkdir command that seems to be run in the context of
>>> the user running 'make check'. If the cygdrive prefix is not
>>> 'cygdrive', 'make check' fails as follows:
>>>
>>> ERROR: tcl error sourcing
>>> /home/kbrown/src/cygdll/newlib-cygwin/winsup/testsuite/winsup.api/winsup.exp.
>>>
>>> ERROR: can't create directory "/cygdrive": permission denied
>>> while executing
>>> "file mkdir $tmpdir/$base"
>>>
>>
>> Ah, I see.
>>
>> Maybe something like the attached is needed.
>
> That fixes it, thanks. I get
>
> === winsup Summary ===
>
> # of expected passes 253
> # of unexpected failures 23
> # of unexpected successes 1
> # of expected failures 7
Yup. I get the same numbers.
next prev parent reply other threads:[~2020-11-09 21:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 19:47 [PATCH 00/11] testsuite refurbishment Jon Turney
2020-11-05 19:47 ` [PATCH 01/11] Add testsuite directory to autogen.sh Jon Turney
2020-11-05 19:47 ` [PATCH 02/11] Always configure in testsuite subdirectory Jon Turney
2020-11-05 19:47 ` [PATCH 03/11] Add rule to testsuite Makefile to regenerate it when needed Jon Turney
2020-11-05 19:47 ` [PATCH 04/11] Avoid 'Makefile.in seems to ignore the --datarootdir setting' warning Jon Turney
2020-11-05 19:47 ` [PATCH 05/11] Move adding libltp to VPATH after Makefile.common Jon Turney
2020-11-05 19:47 ` [PATCH 06/11] Define target_builddir autoconf and Makefile variables Jon Turney
2020-11-05 19:47 ` [PATCH 07/11] Detect and use MinGW compilers for testsuite wrappers Jon Turney
2020-11-05 19:47 ` [PATCH 08/11] Use absolute path to libltp includes Jon Turney
2020-11-05 19:47 ` [PATCH 09/11] Check exit code of a test, rather than stdout Jon Turney
2020-11-05 19:47 ` [PATCH 10/11] Set PATH for tests to pick up cygwin0.dll Jon Turney
2020-11-05 19:47 ` [PATCH 11/11] Ensure temporary directory used by tests exists Jon Turney
2020-11-08 18:19 ` Ken Brown
2020-11-08 18:52 ` Jon Turney
2020-11-08 19:27 ` Ken Brown
2020-11-08 23:38 ` Brian Inglis
2020-11-09 16:25 ` Jon Turney
2020-11-09 17:48 ` Ken Brown
2020-11-09 21:01 ` Jon Turney [this message]
2020-11-06 9:44 ` [PATCH 00/11] testsuite refurbishment Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1119060a-04d3-b966-b237-08af004a6337@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).