public inbox for cygwin-patches@cygwin.com
 help / color / mirror / Atom feed
From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: Forgotted appersand
Date: Tue, 02 Apr 2013 09:09:00 -0000	[thread overview]
Message-ID: <20130402090852.GA12961@calimero.vinschen.de> (raw)
In-Reply-To: <CABEPuQL+SF_sV1NDYGHam8KWtgdzBKWqWDzUUgW9c4imQ1oriw@mail.gmail.com>

On Apr  2 12:46, Алексей Павлов wrote:
> Hi!
> On cygwin-64bit-branch I think one appersand is forgotten.
> 
> --- a/winsup/cygwin/fhandler_disk_file.cc
> +++ b/winsup/cygwin/fhandler_disk_file.cc
> @@ -1176,7 +1176,7 @@ fhandler_disk_file::ftruncate (off_t length,
> bool allow_truncate)
>        /* Create sparse files only when called through ftruncate, not when
>  	 called through posix_fallocate. */
>        if (allow_truncate && pc.support_sparse ()
> -	  & !has_attribute (FILE_ATTRIBUTE_SPARSE_FILE)
> +	  && !has_attribute (FILE_ATTRIBUTE_SPARSE_FILE)
>  	  && length >= fsi.EndOfFile.QuadPart + (128 * 1024))
>  	{
>  	  status = NtFsControlFile (get_handle (), NULL, NULL, NULL, &io,

Thanks for catching!  I just applied the patch.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

      reply	other threads:[~2013-04-02  9:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02  8:46 Алексей Павлов
2013-04-02  9:09 ` Corinna Vinschen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130402090852.GA12961@calimero.vinschen.de \
    --to=corinna-cygwin@cygwin.com \
    --cc=cygwin-patches@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).