From: Christopher Faylor <cgf-use-the-mailinglist-please@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: Fix sem_getvalue
Date: Wed, 18 Sep 2013 18:12:00 -0000 [thread overview]
Message-ID: <20130918181245.GC2351@ednor.casa.cgf.cx> (raw)
In-Reply-To: <52397810.1070600@emsys.de>
On Wed, Sep 18, 2013 at 11:53:20AM +0200, Paul Kunysch wrote:
>Hello
>
>In 1.7.24 and 1.7.25 sem_getvalue() returns the current value instead of
>setting the out-parameter and returning 0/-1 for success/error.
>
>I attached a simple fix.
That looks like a reasonable fix. Did you trace through all of the
callers of semaphore::_getvalue to make sure that some of them aren't
relying on the old behavior?
>I don't know if this should be further improved by setting errno to
>EINVAL if STATUS_INVALID_HANDLE == status.
That sounds reasonable too.
>Unfortunately I wasn't able to run and extend the unit tests. Running
>"make check" fails with "No rule to make target `dataascii.o', needed by
>`libltp.a'". The VPATH seems to be extended correctly.
The tests are in a severe case of bit rot unfortunately. It would be nice
if someone made it a mission to improve Cygwin's testing from nonexistent to
something but that is a very unrewarding a job.
cgf
next prev parent reply other threads:[~2013-09-18 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 9:53 Paul Kunysch
2013-09-18 18:12 ` Christopher Faylor [this message]
[not found] <52389689.1030801@emsys.de>
2013-09-25 10:42 ` Paul Kunysch
2013-09-25 14:46 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918181245.GC2351@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).