From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-patches@cygwin.com
Subject: Re: [PATCH] winsup/cygwin: fix compile of path.cc after basename changes
Date: Mon, 06 Jul 2015 20:02:00 -0000 [thread overview]
Message-ID: <20150706200210.GX2918@calimero.vinschen.de> (raw)
In-Reply-To: <1436211686-9256-1-git-send-email-yselkowi@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Jul 6 14:41, Yaakov Selkowitz wrote:
> ---
> winsup/cygwin/path.cc | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
> index 446d746..5eb076f 100644
> --- a/winsup/cygwin/path.cc
> +++ b/winsup/cygwin/path.cc
> @@ -48,7 +48,7 @@
> c: means c:\.
> */
>
> -#define _BASENAME_DEFINED
> +#define basename basename
As part of the sources, this define needs an informative comment,
describing why it's necessary. Ideally not in just three words
following on the same line but in full english preceeding the #define
line. With such a comment and a ChangeLog entry, patch is ok.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-07-06 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1436206232-9776-1-git-send-email-yselkowi@redhat.com>
2015-07-06 19:41 ` Yaakov Selkowitz
2015-07-06 20:02 ` Corinna Vinschen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706200210.GX2918@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).