[PATCH] Update FAQ listing required packages for building Cygwin

[PATCH] Update FAQ listing required packages for building Cygwin

[Jon Turney]

docbook2X is now required for building documentation
libiconv differences between x86_64 and x86 no longer exist

Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
---
 winsup/doc/faq-programming.xml | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/winsup/doc/faq-programming.xml b/winsup/doc/faq-programming.xml
index 3aa773a..1f595f8 100644
--- a/winsup/doc/faq-programming.xml
+++ b/winsup/doc/faq-programming.xml
@@ -680,17 +680,16 @@ rewriting the runtime library in question from specs...
 
 <para>First, you need to make sure you have the necessary build tools
 installed; you at least need <literal>gcc-g++</literal>, <literal>make</literal>,
-<literal>perl</literal>, <literal>cocom</literal>, <literal>gettext</literal>, <literal>gettext-devel</literal>,
-and <literal>zlib-devel</literal>.
-Building for 32-bit Cygwin also requires <literal>libiconv</literal>,
-<literal>mingw64-i686-gcc-g++</literal>, <literal>mingw64-i686-zlib</literal>,
-and <literal>mingw64-x86_64-gcc-core</literal>.
-Building for 64-bit Cygwin also requires <literal>libiconv-devel</literal>,
-<literal>mingw64-x86_64-gcc-g++</literal>, and
+<literal>perl</literal>, <literal>cocom</literal>, <literal>gettext-devel</literal>,
+<literal>libiconv-devel</literal> and <literal>zlib-devel</literal>.
+Building for 32-bit Cygwin also requires
+<literal>mingw64-i686-gcc-g++</literal> and <literal>mingw64-i686-zlib</literal>.
+Building for 64-bit Cygwin also requires
+<literal>mingw64-x86_64-gcc-g++</literal> and
 <literal>mingw64-x86_64-zlib</literal>.
 If you want to run the tests, <literal>dejagnu</literal> is also required.
 Normally, building ignores any errors in building the documentation,
-which requires the <literal>dblatex</literal>,
+which requires the <literal>dblatex</literal>, <literal>docbook2X</literal>,
 <literal>docbook-xml45</literal>, <literal>docbook-xsl</literal>, and
 <literal>xmlto</literal> packages.  For more information on building the
 documentation, see the README included in the <literal>cygwin-doc</literal> package.
-- 
2.8.3

Re: [PATCH] Update FAQ listing required packages for building Cygwin

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

On Jun 28 13:39, Jon Turney wrote:
> docbook2X is now required for building documentation
> libiconv differences between x86_64 and x86 no longer exist

Please apply.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] Update FAQ listing required packages for building Cygwin

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

Hi Jon,

On Jun 28 15:21, Corinna Vinschen wrote:
> On Jun 28 13:39, Jon Turney wrote:
> > docbook2X is now required for building documentation
> > libiconv differences between x86_64 and x86 no longer exist
> 
> Please apply.

Sorry, but that was not quite correct.  Apparently I only skimmed the
log text, not the actual patch.  Doh.

When building 32 bit Cygwin, you need the 64 bit Mingw compiler for
cyglsa64.dll.  The reason is that 32 bit cyglsa.dll won't work on 64 bit
systems, even if Cygwin itself is running under WOW64.  Since we don't
know if the user runs Cygwin on 32 bit or under WOW64, we have to create
*both* cyglsa DLLs for 32 bit Cygwin, while it's obviously sufficient to
build only the 64 bit version for 64 bit Cygwin.

Care to fix this part of your patch?


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] Update FAQ listing required packages for building Cygwin

[Jon Turney]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On 29/06/2016 09:04, Corinna Vinschen wrote:
> Hi Jon,
>
> On Jun 28 15:21, Corinna Vinschen wrote:
>> On Jun 28 13:39, Jon Turney wrote:
>>> docbook2X is now required for building documentation
>>> libiconv differences between x86_64 and x86 no longer exist
>>
>> Please apply.
>
> Sorry, but that was not quite correct.  Apparently I only skimmed the
> log text, not the actual patch.  Doh.
>
> When building 32 bit Cygwin, you need the 64 bit Mingw compiler for
> cyglsa64.dll.  The reason is that 32 bit cyglsa.dll won't work on 64 bit
> systems, even if Cygwin itself is running under WOW64.  Since we don't
> know if the user runs Cygwin on 32 bit or under WOW64, we have to create
> *both* cyglsa DLLs for 32 bit Cygwin, while it's obviously sufficient to
> build only the 64 bit version for 64 bit Cygwin.

Yes, I somehow though it said mingw64-i686-gcc-core rather than 
mingw64-x86_64-gcc-core.

How about the attached?



[-- Attachment #2: 0001-Restore-mingw64-x86_64-gcc-core-in-FAQ-listing-requi.patch --]
[-- Type: text/plain, Size: 1239 bytes --]

From e27cfa4631e9ff7ead7b417e87d160cc20c9d03e Mon Sep 17 00:00:00 2001
From: Jon Turney <jon.turney@dronecode.org.uk>
Date: Wed, 29 Jun 2016 15:08:19 +0100
Subject: [PATCH] Restore mingw64-x86_64-gcc-core in FAQ listing required
 packages

Restore mingw64-x86_64-gcc-core to requirements for 32-bit builds in FAQ
listing required packages, and give reason.

Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>
---
 winsup/doc/faq-programming.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/winsup/doc/faq-programming.xml b/winsup/doc/faq-programming.xml
index 1f595f8..c64ab4a 100644
--- a/winsup/doc/faq-programming.xml
+++ b/winsup/doc/faq-programming.xml
@@ -683,6 +683,7 @@ installed; you at least need <literal>gcc-g++</literal>, <literal>make</literal>
 <literal>perl</literal>, <literal>cocom</literal>, <literal>gettext-devel</literal>,
 <literal>libiconv-devel</literal> and <literal>zlib-devel</literal>.
 Building for 32-bit Cygwin also requires
+<literal>mingw64-x86_64-gcc-core</literal> (for building the cyglsa64 DLL for WoW64),
 <literal>mingw64-i686-gcc-g++</literal> and <literal>mingw64-i686-zlib</literal>.
 Building for 64-bit Cygwin also requires
 <literal>mingw64-x86_64-gcc-g++</literal> and
-- 
2.8.3

Re: [PATCH] Update FAQ listing required packages for building Cygwin

[Corinna Vinschen]

[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]

On Jun 29 15:18, Jon Turney wrote:
> On 29/06/2016 09:04, Corinna Vinschen wrote:
> > Hi Jon,
> > 
> > On Jun 28 15:21, Corinna Vinschen wrote:
> > > On Jun 28 13:39, Jon Turney wrote:
> > > > docbook2X is now required for building documentation
> > > > libiconv differences between x86_64 and x86 no longer exist
> > > 
> > > Please apply.
> > 
> > Sorry, but that was not quite correct.  Apparently I only skimmed the
> > log text, not the actual patch.  Doh.
> > 
> > When building 32 bit Cygwin, you need the 64 bit Mingw compiler for
> > cyglsa64.dll.  The reason is that 32 bit cyglsa.dll won't work on 64 bit
> > systems, even if Cygwin itself is running under WOW64.  Since we don't
> > know if the user runs Cygwin on 32 bit or under WOW64, we have to create
> > *both* cyglsa DLLs for 32 bit Cygwin, while it's obviously sufficient to
> > build only the 64 bit version for 64 bit Cygwin.
> 
> Yes, I somehow though it said mingw64-i686-gcc-core rather than
> mingw64-x86_64-gcc-core.
> 
> How about the attached?

Should be fine, given that cyglsa is plain C.  Please go ahead.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]