* [PATCH] Cygwin: console: Fix code for restoring console mode.
@ 2020-02-17 12:46 Takashi Yano
2020-02-17 12:59 ` Corinna Vinschen
0 siblings, 1 reply; 2+ messages in thread
From: Takashi Yano @ 2020-02-17 12:46 UTC (permalink / raw)
To: cygwin-patches; +Cc: Takashi Yano
- Commit 774b8996d1f3e535e8267be4eb8e751d756c2cec has a bug that
restores console output mode into console input. This patch fixes
the issue.
---
winsup/cygwin/fhandler_console.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
index 2afb5c529..9bfee64d3 100644
--- a/winsup/cygwin/fhandler_console.cc
+++ b/winsup/cygwin/fhandler_console.cc
@@ -1122,7 +1122,7 @@ fhandler_console::close ()
&obi, sizeof obi, NULL);
if (NT_SUCCESS (status) && obi.HandleCount == 1)
if (orig_conout_mode != (DWORD) -1)
- SetConsoleMode (get_handle (), orig_conout_mode);
+ SetConsoleMode (get_output_handle (), orig_conout_mode);
release_output_mutex ();
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Cygwin: console: Fix code for restoring console mode.
2020-02-17 12:46 [PATCH] Cygwin: console: Fix code for restoring console mode Takashi Yano
@ 2020-02-17 12:59 ` Corinna Vinschen
0 siblings, 0 replies; 2+ messages in thread
From: Corinna Vinschen @ 2020-02-17 12:59 UTC (permalink / raw)
To: cygwin-patches
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
On Feb 17 21:46, Takashi Yano wrote:
> - Commit 774b8996d1f3e535e8267be4eb8e751d756c2cec has a bug that
> restores console output mode into console input. This patch fixes
> the issue.
> ---
> winsup/cygwin/fhandler_console.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler_console.cc b/winsup/cygwin/fhandler_console.cc
> index 2afb5c529..9bfee64d3 100644
> --- a/winsup/cygwin/fhandler_console.cc
> +++ b/winsup/cygwin/fhandler_console.cc
> @@ -1122,7 +1122,7 @@ fhandler_console::close ()
> &obi, sizeof obi, NULL);
> if (NT_SUCCESS (status) && obi.HandleCount == 1)
> if (orig_conout_mode != (DWORD) -1)
> - SetConsoleMode (get_handle (), orig_conout_mode);
> + SetConsoleMode (get_output_handle (), orig_conout_mode);
>
> release_output_mutex ();
>
> --
> 2.21.0
I pushed this now, but I let it simmering for a bit. I'll create the
3.1.4 release tomorrow.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Maintainer
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-17 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 12:46 [PATCH] Cygwin: console: Fix code for restoring console mode Takashi Yano
2020-02-17 12:59 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).