From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-patches@cygwin.com
Subject: [PATCH] Cygwin: pty: Add FreeConsole to destructor of pty slave.
Date: Fri, 13 Mar 2020 12:06:49 +0900 [thread overview]
Message-ID: <20200313030649.874-1-takashi.yano@nifty.ne.jp> (raw)
- When pseudo console is closed, all the processes attched to the
pseudo console are terminated. This causes the problem reported
in https://sourceware.org/pipermail/cygwin/2020-March/244046.html.
This patch fixes the issue.
---
winsup/cygwin/fhandler_tty.cc | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index b42e0aeb6..b2e725d5d 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -706,8 +706,15 @@ fhandler_pty_slave::fhandler_pty_slave (int unit)
fhandler_pty_slave::~fhandler_pty_slave ()
{
if (!get_ttyp ())
- /* Why comes here? Who clears _tc? */
- return;
+ {
+ /* Why comes here? Who clears _tc? */
+ if (freeconsole_on_close)
+ {
+ FreeConsole ();
+ pcon_attached_to = -1;
+ }
+ return;
+ }
if (get_pseudo_console ())
{
int used = 0;
--
2.21.0
next reply other threads:[~2020-03-13 3:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 3:06 Takashi Yano [this message]
2020-03-13 9:58 ` Corinna Vinschen
2020-03-16 2:03 ` Takashi Yano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313030649.874-1-takashi.yano@nifty.ne.jp \
--to=takashi.yano@nifty.ne.jp \
--cc=cygwin-patches@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).